open-telemetry
/
opentelemetry-php
mirror of https://github.com/open-telemetry/opentelemetry-php.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove 'include context' parameter from logging examples (#992) 

the param was removed from spec, and our API implementation recently, but
I missed these examples.
This commit is contained in:
Brett McBride 2023-05-05 00:35:24 +10:00 committed by GitHub
parent 952c069792
commit c701693c25
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/logs/features/batch_exporting.php
View File

@ -37,7 +37,7 @@ echo 'Span id: ' . $span->getContext()->getSpanId() . PHP_EOL;
//get a logger, and emit a log record from an EventLogger. The active context (trace id + span id) will be
//attached to the log record
$logger = $loggerProvider->getLogger('demo', '1.0', 'http://schema.url', true, ['foo' => 'bar']);
$logger = $loggerProvider->getLogger('demo', '1.0', 'http://schema.url', ['foo' => 'bar']);
$eventLogger = new EventLogger($logger, 'my-domain');
$record = (new LogRecord(['foo' => 'bar', 'baz' => 'bat', 'msg' => 'hello world']))

4
examples/logs/features/monolog-otel-integration.php
View File

@ -18,6 +18,8 @@ use Psr\Log\LogLevel;
* configured from environment, and autoloaded as part of composer where is can be retrieved from `Globals`.
*
* @see https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/bridge-api.md#usage
*
* We have an official monolog handler, @see https://packagist.org/packages/open-telemetry/opentelemetry-logger-monolog
*/
// create env vars before requiring composer
@ -40,7 +42,7 @@ $otelHandler = new class(LogLevel::INFO) extends AbstractProcessingHandler {
{
parent::__construct($level, $bubble);
$provider ??= Globals::loggerProvider();
$this->logger = $provider->getLogger('monolog-demo', null, null, true, ['logging.library' => 'monolog']);
$this->logger = $provider->getLogger('monolog-demo', null, null, ['logging.library' => 'monolog']);
}
protected function write(array $record): void

2
examples/logs/getting_started.php
View File

@ -30,7 +30,7 @@ echo 'Span id: ' . $span->getContext()->getSpanId() . PHP_EOL;
//get a logger, and emit a log record from an EventLogger. The active context (trace id + span id) will be
//attached to the log record
$logger = $loggerProvider->getLogger('demo', '1.0', 'http://schema.url', true, ['foo' => 'bar']);
$logger = $loggerProvider->getLogger('demo', '1.0', 'http://schema.url', ['foo' => 'bar']);
$eventLogger = new EventLogger($logger, 'my-domain');
$record = (new LogRecord(['foo' => 'bar', 'baz' => 'bat', 'msg' => 'hello world']))