open-telemetry
/
opentelemetry-python-contrib
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Move samplers to SDK package (#1023)

This commit is contained in:
Leighton Chen 2020-08-20 14:02:55 -07:00 committed by GitHub
parent 3e373c1acc
commit 02d48caf17
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
exporter/opentelemetry-exporter-datadog/src/opentelemetry/exporter/datadog/exporter.py
View File

@ -21,6 +21,7 @@ from ddtrace.internal.writer import AgentWriter
from ddtrace.span import Span as DatadogSpan from ddtrace.span import Span as DatadogSpan
import opentelemetry.trace as trace_api import opentelemetry.trace as trace_api
from opentelemetry.sdk.trace import sampling
from opentelemetry.sdk.trace.export import SpanExporter, SpanExportResult from opentelemetry.sdk.trace.export import SpanExporter, SpanExportResult
from opentelemetry.trace.status import StatusCanonicalCode from opentelemetry.trace.status import StatusCanonicalCode
@ -246,7 +247,7 @@ def _get_sampling_rate(span):
return ( return (
span.sampler.rate span.sampler.rate
if ctx.trace_flags.sampled if ctx.trace_flags.sampled
and isinstance(span.sampler, trace_api.sampling.ProbabilitySampler) and isinstance(span.sampler, sampling.ProbabilitySampler)
else None else None
) )

3
exporter/opentelemetry-exporter-datadog/tests/test_datadog_exporter.py
View File

@ -23,6 +23,7 @@ from ddtrace.internal.writer import AgentWriter
from opentelemetry import trace as trace_api from opentelemetry import trace as trace_api
from opentelemetry.exporter import datadog from opentelemetry.exporter import datadog
from opentelemetry.sdk import trace from opentelemetry.sdk import trace
from opentelemetry.sdk.trace import sampling
from opentelemetry.sdk.util.instrumentation import InstrumentationInfo from opentelemetry.sdk.util.instrumentation import InstrumentationInfo
@ -497,7 +498,7 @@ class TestDatadogSpanExporter(unittest.TestCase):
is_remote=False, is_remote=False,
trace_flags=trace_api.TraceFlags(trace_api.TraceFlags.SAMPLED), trace_flags=trace_api.TraceFlags(trace_api.TraceFlags.SAMPLED),
) )
sampler = trace_api.sampling.ProbabilitySampler(0.5) sampler = sampling.ProbabilitySampler(0.5)
span = trace.Span( span = trace.Span(
name="sampled", context=context, parent=None, sampler=sampler name="sampled", context=context, parent=None, sampler=sampler