open-telemetry
/
opentelemetry-python-contrib
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use is_recording flag in jinja, celery, esearch, falcon instrumentations (#1241)

This commit is contained in:
Leighton Chen 2020-10-14 15:07:23 -04:00 committed by GitHub
parent 05ab1e1da1
commit 046bdbefcf
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py
View File

@ -226,9 +226,12 @@ def _start_span(tracer, handler, start_time) -> _TraceContext:
span = tracer.start_span(
_get_operation_name(handler, handler.request),
kind=trace.SpanKind.SERVER,
attributes=_get_attributes_from_request(handler.request),
start_time=start_time,
)
if span.is_recording():
attributes = _get_attributes_from_request(handler.request)
for key, value in attributes.items():
span.set_attribute(key, value)
activation = tracer.use_span(span, end_on_exit=True)
activation.__enter__()
@ -260,15 +263,16 @@ def _finish_span(tracer, handler, error=None):
if not ctx:
return
if reason:
ctx.span.set_attribute("http.status_text", reason)
ctx.span.set_attribute("http.status_code", status_code)
ctx.span.set_status(
Status(
canonical_code=http_status_to_canonical_code(status_code),
description=reason,
if ctx.span.is_recording():
if reason:
ctx.span.set_attribute("http.status_text", reason)
ctx.span.set_attribute("http.status_code", status_code)
ctx.span.set_status(
Status(
canonical_code=http_status_to_canonical_code(status_code),
description=reason,
)
)
)
ctx.activation.__exit__(*finish_args)
context.detach(ctx.token)