open-telemetry
/
opentelemetry-python-contrib
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix traced_request_attrs (#473)

This commit is contained in:
Daisuke Taniwaki 2021-04-30 00:08:18 +09:00 committed by GitHub
parent 3ec77360cb
commit 43e0972aea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -7,8 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased](https://github.com/open-telemetry/opentelemetry-python-contrib/compare/v0.200...HEAD) ## [Unreleased](https://github.com/open-telemetry/opentelemetry-python-contrib/compare/v0.200...HEAD)
### Changed ### Changed
- `opentelemetry-propagator-ot-trace` Use `TraceFlags` object in `extract` - `opentelemetry-propagator-ot-trace` Use `TraceFlags` object in `extract`
([#472](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/472)) ([#472](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/472))
- Set the `traced_request_attrs` of FalconInstrumentor by an argument correctly.
([#473](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/473))
### Added ### Added
- Move `opentelemetry-instrumentation` from core repository - Move `opentelemetry-instrumentation` from core repository

4
instrumentation/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
View File

@ -154,7 +154,7 @@ class _InstrumentedFalconAPI(falcon.API):
trace_middleware = _TraceMiddleware( trace_middleware = _TraceMiddleware(
self._tracer, self._tracer,
kwargs.pop("traced_request_attributes", None), kwargs.pop("traced_request_attributes", _traced_request_attrs),
kwargs.pop("request_hook", None), kwargs.pop("request_hook", None),
kwargs.pop("response_hook", None), kwargs.pop("response_hook", None),
) )
@ -215,7 +215,7 @@ class _TraceMiddleware:
response_hook=None, response_hook=None,
): ):
self.tracer = tracer self.tracer = tracer
self._traced_request_attrs = _traced_request_attrs self._traced_request_attrs = traced_request_attrs
self._request_hook = request_hook self._request_hook = request_hook
self._response_hook = response_hook self._response_hook = response_hook