Fix expected URL in aiohttp instrumentation test (#1772)

* WIP

* Revert "WIP"

This reverts commit 3ed466348e4c172fd96569a0dcb1b15047760cef.

* Fix expected URL in aiohttp instrumentation test

The underlying cause of the issue here is the update of the yarl package
from 1.8.2 to 1.9.1. yarl is used as a dependency in the
opentelemetry-instrumentation-aiohttp package but it is not there where
the issue happens, but in aiohttp who also has yarl as a dependency.

This is why the fix does not touch any relevant part of any
opentelemetry-* code, since it is the return value of aiohttp code who
now has a different value for the URL.

Fixes #1770
This commit is contained in:
Diego Hurtado 2023-04-25 11:44:11 -06:00 committed by GitHub
parent 19fe7713e2
commit 5117098024
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions

View File

@ -122,7 +122,7 @@ class TestAioHttpIntegration(TestBase):
(span_status, None),
{
SpanAttributes.HTTP_METHOD: "GET",
SpanAttributes.HTTP_URL: f"http://{host}:{port}/test-path?query=param#foobar",
SpanAttributes.HTTP_URL: f"http://{host}:{port}/test-path#foobar",
SpanAttributes.HTTP_STATUS_CODE: int(
status_code
),