open-telemetry
/
opentelemetry-python-contrib
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Split up metric instrument constructors (#1254)

This commit is contained in:
Leighton Chen 2020-10-27 22:33:38 -04:00 committed by GitHub
parent 7cf40b1302
commit 53bee8ddc9
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_utilities.py
View File

@ -19,8 +19,6 @@ from time import time
import grpc import grpc
from opentelemetry.sdk.metrics import Counter, ValueRecorder
class RpcInfo: class RpcInfo:
def __init__( def __init__(
@ -47,33 +45,29 @@ class TimedMetricRecorder:
self._span_kind = span_kind self._span_kind = span_kind
if self._meter: if self._meter:
self._duration = self._meter.create_metric( self._duration = self._meter.create_valuerecorder(
name="{}/{}/duration".format(service_name, span_kind), name="{}/{}/duration".format(service_name, span_kind),
description="Duration of grpc requests to the server", description="Duration of grpc requests to the server",
unit="ms", unit="ms",
value_type=float, value_type=float,
metric_type=ValueRecorder,
) )
self._error_count = self._meter.create_metric( self._error_count = self._meter.create_counter(
name="{}/{}/errors".format(service_name, span_kind), name="{}/{}/errors".format(service_name, span_kind),
description="Number of errors that were returned from the server", description="Number of errors that were returned from the server",
unit="1", unit="1",
value_type=int, value_type=int,
metric_type=Counter,
) )
self._bytes_in = self._meter.create_metric( self._bytes_in = self._meter.create_counter(
name="{}/{}/bytes_in".format(service_name, span_kind), name="{}/{}/bytes_in".format(service_name, span_kind),
description="Number of bytes received from the server", description="Number of bytes received from the server",
unit="by", unit="by",
value_type=int, value_type=int,
metric_type=Counter,
) )
self._bytes_out = self._meter.create_metric( self._bytes_out = self._meter.create_counter(
name="{}/{}/bytes_out".format(service_name, span_kind), name="{}/{}/bytes_out".format(service_name, span_kind),
description="Number of bytes sent out through gRPC", description="Number of bytes sent out through gRPC",
unit="by", unit="by",
value_type=int, value_type=int,
metric_type=Counter,
) )
def record_bytes_in(self, bytes_in, method): def record_bytes_in(self, bytes_in, method):