Protect access to Span implementation (#1188)

This commit is contained in:
Amos Law 2020-10-06 17:44:41 -04:00 committed by alrex
parent 724a913393
commit 70782855c5
1 changed files with 11 additions and 7 deletions

View File

@ -42,7 +42,7 @@ class TestZipkinSpanExporter(unittest.TestCase):
is_remote=False, is_remote=False,
) )
self._test_span = trace.Span("test_span", context=context) self._test_span = trace._Span("test_span", context=context)
self._test_span.start() self._test_span.start()
self._test_span.end() self._test_span.end()
@ -154,18 +154,22 @@ class TestZipkinSpanExporter(unittest.TestCase):
) )
otel_spans = [ otel_spans = [
trace.Span( trace._Span(
name=span_names[0], name=span_names[0],
context=span_context, context=span_context,
parent=parent_context, parent=parent_context,
events=(event,), events=(event,),
links=(link,), links=(link,),
), ),
trace.Span( trace._Span(
name=span_names[1], context=parent_context, parent=None name=span_names[1], context=parent_context, parent=None
), ),
trace.Span(name=span_names[2], context=other_context, parent=None), trace._Span(
trace.Span(name=span_names[3], context=other_context, parent=None), name=span_names[2], context=other_context, parent=None
),
trace._Span(
name=span_names[3], context=other_context, parent=None
),
] ]
otel_spans[0].start(start_time=start_times[0]) otel_spans[0].start(start_time=start_times[0])
@ -328,7 +332,7 @@ class TestZipkinSpanExporter(unittest.TestCase):
trace_id, parent_id, is_remote=False trace_id, parent_id, is_remote=False
) )
otel_span = trace.Span( otel_span = trace._Span(
name=span_names[0], context=span_context, parent=parent_context, name=span_names[0], context=span_context, parent=parent_context,
) )
@ -387,7 +391,7 @@ class TestZipkinSpanExporter(unittest.TestCase):
trace_flags=TraceFlags(TraceFlags.SAMPLED), trace_flags=TraceFlags(TraceFlags.SAMPLED),
) )
span = trace.Span(name="test-span", context=span_context,) span = trace._Span(name="test-span", context=span_context,)
span.start() span.start()
span.resource = Resource({}) span.resource = Resource({})