open-telemetry
/
opentelemetry-python-contrib
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove PIPELINE from span name

This commit is contained in:
Srikanth Chekuri 2020-11-16 20:53:50 +05:30
parent edaf0b1611
commit 857581ca51
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
instrumentation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/__init__.py
View File

@ -90,8 +90,7 @@ def _traced_execute_pipeline(func, instance, args, kwargs):
cmds = [_format_command_args(c) for c, _ in instance.command_stack] cmds = [_format_command_args(c) for c, _ in instance.command_stack]
resource = "\n".join(cmds) resource = "\n".join(cmds)
pipeline_cmnds = " ".join([args[0] for args, _ in instance.command_stack]) span_name = " ".join([args[0] for args, _ in instance.command_stack])
span_name = "PIPELINE" + " " + pipeline_cmnds
with tracer.start_as_current_span( with tracer.start_as_current_span(
span_name, kind=trace.SpanKind.CLIENT span_name, kind=trace.SpanKind.CLIENT

2
tests/opentelemetry-docker-tests/tests/redis/test_redis_functional.py
View File

@ -72,7 +72,7 @@ class TestRedisInstrument(TestBase):
spans = self.memory_exporter.get_finished_spans() spans = self.memory_exporter.get_finished_spans()
self.assertEqual(len(spans), 1) self.assertEqual(len(spans), 1)
span = spans[0] span = spans[0]
self._check_span(span, "PIPELINE SET RPUSH HGETALL") self._check_span(span, "SET RPUSH HGETALL")
self.assertEqual( self.assertEqual(
span.attributes.get("db.statement"), span.attributes.get("db.statement"),
"SET blah 32\nRPUSH foo éé\nHGETALL xxx", "SET blah 32\nRPUSH foo éé\nHGETALL xxx",