open-telemetry
/
opentelemetry-python-contrib
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use is_recording flag in aiopg, asyncpg, dbapi, psycopg2, pymemcache, pymongo, redis, sqlalchemy instrumentations (#1212)

This commit is contained in:
Leighton Chen 2020-10-08 15:25:20 -04:00 committed by GitHub
parent 6d83acf834
commit 9ea1b71b00
1 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
instrumentation/opentelemetry-instrumentation-asyncpg/src/opentelemetry/instrumentation/asyncpg/__init__.py
View File

@ -112,9 +112,6 @@ class AsyncPGInstrumentor(BaseInstrumentor):
unwrap(asyncpg.Connection, method) unwrap(asyncpg.Connection, method)
async def _do_execute(self, func, instance, args, kwargs): async def _do_execute(self, func, instance, args, kwargs):
span_attributes = _hydrate_span_from_args(
instance, args[0], args[1:] if self.capture_parameters else None,
)
tracer = getattr(asyncpg, _APPLIED) tracer = getattr(asyncpg, _APPLIED)
exception = None exception = None
@ -122,7 +119,12 @@ class AsyncPGInstrumentor(BaseInstrumentor):
with tracer.start_as_current_span( with tracer.start_as_current_span(
"postgresql", kind=SpanKind.CLIENT "postgresql", kind=SpanKind.CLIENT
) as span: ) as span:
if span.is_recording():
span_attributes = _hydrate_span_from_args(
instance,
args[0],
args[1:] if self.capture_parameters else None,
)
for attribute, value in span_attributes.items(): for attribute, value in span_attributes.items():
span.set_attribute(attribute, value) span.set_attribute(attribute, value)
@ -132,6 +134,7 @@ class AsyncPGInstrumentor(BaseInstrumentor):
exception = exc exception = exc
raise raise
finally: finally:
if span.is_recording():
if exception is not None: if exception is not None:
span.set_status( span.set_status(
Status(_exception_to_canonical_code(exception)) Status(_exception_to_canonical_code(exception))