open-telemetry
/
opentelemetry-python-contrib
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change status codes from grpc status codes, remove setting status in instrumentations except on ERROR (#1282)

This commit is contained in:
Leighton Chen 2020-10-28 17:28:58 -04:00 committed by GitHub
parent 9e2b50a13d
commit c158505157
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
instrumentation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
View File

@ -28,8 +28,8 @@ from asgiref.compatibility import guarantee_single_callable
from opentelemetry import context, propagators, trace from opentelemetry import context, propagators, trace
from opentelemetry.instrumentation.asgi.version import __version__ # noqa from opentelemetry.instrumentation.asgi.version import __version__ # noqa
from opentelemetry.instrumentation.utils import http_status_to_canonical_code from opentelemetry.instrumentation.utils import http_status_to_status_code
from opentelemetry.trace.status import Status, StatusCanonicalCode from opentelemetry.trace.status import Status, StatusCode
def get_header_from_scope(scope: dict, header_name: str) -> typing.List[str]: def get_header_from_scope(scope: dict, header_name: str) -> typing.List[str]:
@ -98,13 +98,13 @@ def set_status_code(span, status_code):
except ValueError: except ValueError:
span.set_status( span.set_status(
Status( Status(
StatusCanonicalCode.UNKNOWN, StatusCode.ERROR,
"Non-integer HTTP status: " + repr(status_code), "Non-integer HTTP status: " + repr(status_code),
) )
) )
else: else:
span.set_attribute("http.status_code", status_code) span.set_attribute("http.status_code", status_code)
span.set_status(Status(http_status_to_canonical_code(status_code))) span.set_status(Status(http_status_to_status_code(status_code)))
def get_default_span_details(scope: dict) -> Tuple[str, dict]: def get_default_span_details(scope: dict) -> Tuple[str, dict]: