open-telemetry
/
opentelemetry-python-contrib
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Span name updated to follow semantic conventions to reduce cardinality (#972)

This commit is contained in:
alrex 2020-08-17 23:50:09 -05:00 committed by GitHub
parent a43d088c3f
commit c9a0fe761b
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
instrumentation/opentelemetry-instrumentation-aiohttp-client/CHANGELOG.md
View File

@ -2,6 +2,9 @@
## Unreleased ## Unreleased
- Updating span name to match semantic conventions
([#972](https://github.com/open-telemetry/opentelemetry-python/pull/972))
## Version 0.12b0 ## Version 0.12b0
Released 2020-08-14 Released 2020-08-14

2
instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
View File

@ -126,7 +126,7 @@ def create_trace_config(
): ):
http_method = params.method.upper() http_method = params.method.upper()
if trace_config_ctx.span_name is None: if trace_config_ctx.span_name is None:
request_span_name = http_method request_span_name = "HTTP {}".format(http_method)
elif callable(trace_config_ctx.span_name): elif callable(trace_config_ctx.span_name):
request_span_name = str(trace_config_ctx.span_name(params)) request_span_name = str(trace_config_ctx.span_name(params))
else: else:

10
instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py
View File

@ -118,7 +118,7 @@ class TestAioHttpIntegration(TestBase):
self.assert_spans( self.assert_spans(
[ [
( (
"GET", "HTTP GET",
(span_status, None), (span_status, None),
{ {
"component": "http", "component": "http",
@ -192,7 +192,7 @@ class TestAioHttpIntegration(TestBase):
self.assert_spans( self.assert_spans(
[ [
( (
"GET", "HTTP GET",
(StatusCanonicalCode.OK, None), (StatusCanonicalCode.OK, None),
{ {
"component": "http", "component": "http",
@ -232,7 +232,7 @@ class TestAioHttpIntegration(TestBase):
self.assert_spans( self.assert_spans(
[ [
( (
"GET", "HTTP GET",
(expected_status, None), (expected_status, None),
{ {
"component": "http", "component": "http",
@ -260,7 +260,7 @@ class TestAioHttpIntegration(TestBase):
self.assert_spans( self.assert_spans(
[ [
( (
"GET", "HTTP GET",
(StatusCanonicalCode.DEADLINE_EXCEEDED, None), (StatusCanonicalCode.DEADLINE_EXCEEDED, None),
{ {
"component": "http", "component": "http",
@ -290,7 +290,7 @@ class TestAioHttpIntegration(TestBase):
self.assert_spans( self.assert_spans(
[ [
( (
"GET", "HTTP GET",
(StatusCanonicalCode.DEADLINE_EXCEEDED, None), (StatusCanonicalCode.DEADLINE_EXCEEDED, None),
{ {
"component": "http", "component": "http",