open-telemetry
/
opentelemetry-python-contrib
mirror of https://github.com/open-telemetry/opentelemetry-python-contrib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Review change 

Don't make function call unnecessarily when span is not recording
This commit is contained in:
Srikanth Chekuri 2020-11-17 21:12:19 +05:30
parent 0b8deb46d8
commit dc98748c50
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
instrumentation/opentelemetry-instrumentation-asyncpg/src/opentelemetry/instrumentation/asyncpg/__init__.py
View File

@ -118,19 +118,22 @@ class AsyncPGInstrumentor(BaseInstrumentor):
tracer = getattr(asyncpg, _APPLIED) tracer = getattr(asyncpg, _APPLIED)
exception = None exception = None
span_attributes = _hydrate_span_from_args( params = getattr(instance, "_params", None)
instance, args[0], args[1:] if self.capture_parameters else None
)
name = "" name = ""
if args[0]: if args[0]:
name = args[0] name = args[0]
elif span_attributes.get("db.name"): elif params and params.get("database"):
name = span_attributes["db.name"] name = params.get("database")
else: else:
name = "postgresql" # Does it ever happen? name = "postgresql" # Does it ever happen?
with tracer.start_as_current_span(name, kind=SpanKind.CLIENT) as span: with tracer.start_as_current_span(name, kind=SpanKind.CLIENT) as span:
if span.is_recording(): if span.is_recording():
span_attributes = _hydrate_span_from_args(
instance,
args[0],
args[1:] if self.capture_parameters else None,
)
for attribute, value in span_attributes.items(): for attribute, value in span_attributes.items():
span.set_attribute(attribute, value) span.set_attribute(attribute, value)