diff --git a/Makefile b/Makefile index 2f912a30c..ccfcfac10 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,5 @@ # All documents to be used in spell check. -ALL_DOCS := $(shell find . -name '*.md' -type f | grep -v ^./node_modules | sort) +ALL_DOCS := $(shell find . -name '*.md' -not -path './.github/*' -type f | grep -v ^./node_modules | sort) TOOLS_DIR := ./.tools MISSPELL_BINARY=$(TOOLS_DIR)/misspell @@ -32,4 +32,5 @@ install-markdown-lint: .PHONY: markdown-lint markdown-lint: - @for f in $(ALL_DOCS); do echo $$f; $(MARKDOWN_LINT) -c .markdownlint.yaml $$f; done + @echo $(ALL_DOCS) + @for f in $(ALL_DOCS); do echo $$f; $(MARKDOWN_LINT) -c .markdownlint.yaml $$f || exit 1; done diff --git a/specification/trace/semantic_conventions/http.md b/specification/trace/semantic_conventions/http.md index 548bb259a..d7e806804 100644 --- a/specification/trace/semantic_conventions/http.md +++ b/specification/trace/semantic_conventions/http.md @@ -86,7 +86,6 @@ Note that the items marked with [1] are different from the mapping defined in th | `http.response_content_length` | The size of the response payload body in bytes. This is the number of bytes transferred excluding headers and is often, but not always, present as the [Content-Length][] header. For requests using transport encoding, this should be the compressed size. | No | | `http.response_content_length_uncompressed` | The size of the uncompressed response payload body after transport decoding. Not set if transport encoding not used. | No | - It is recommended to also use the general [network attributes][], especially `net.peer.ip`. If `net.transport` is not specified, it can be assumed to be `IP.TCP` except if `http.flavor` is `QUIC`, in which case `IP.UDP` is assumed. [network attributes]: span-general.md#general-network-connection-attributes diff --git a/specification/trace/semantic_conventions/span-general.md b/specification/trace/semantic_conventions/span-general.md index d656c358d..dc1bc8af9 100644 --- a/specification/trace/semantic_conventions/span-general.md +++ b/specification/trace/semantic_conventions/span-general.md @@ -82,6 +82,7 @@ Instrumentations SHOULD provide a way for users to configure this name. | `peer.service` | The [`service.name`](../../resource/semantic_conventions/README.md#service) of the remote service. SHOULD be equal to the actual `service.name` resource attribute of the remote service if any. | Examples of `peer.service` that users may specify: + - A Redis cache of auth tokens as `peer.service="AuthTokenCache"`. - A gRPC service `rpc.service="io.opentelemetry.AuthService"` may be hosted in both a gateway, `peer.service="ExternalApiService"` and a backend, `peer.service="AuthService"`.