From 28b6c5aa8819a91202ccf9e5b5ccbada4b43481c Mon Sep 17 00:00:00 2001 From: William Armiros <54150514+willarmiros@users.noreply.github.com> Date: Wed, 27 Jan 2021 12:04:10 -0800 Subject: [PATCH] Lowercased ECS launch types (#1339) * lowercased ECS launch types * updated changelog * updated tables with 2.1 tool Co-authored-by: Armin Ruech Co-authored-by: Bogdan Drutu --- semantic_conventions/resource/cloud_provider/aws/ecs.yaml | 6 +++--- .../resource/semantic_conventions/cloud_provider/aws/ecs.md | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/semantic_conventions/resource/cloud_provider/aws/ecs.yaml b/semantic_conventions/resource/cloud_provider/aws/ecs.yaml index 543639c4c..3c8b0d722 100644 --- a/semantic_conventions/resource/cloud_provider/aws/ecs.yaml +++ b/semantic_conventions/resource/cloud_provider/aws/ecs.yaml @@ -19,12 +19,12 @@ groups: allow_custom_values: false members: - id: ec2 - value: "EC2" + value: "ec2" - id: fargate - value: "Fargate" + value: "fargate" brief: > The [launch type](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/launch_types.html) for an ECS task. - examples: ['EC2', 'Fargate'] + examples: ['ec2', 'fargate'] - id: task.arn type: string brief: > diff --git a/specification/resource/semantic_conventions/cloud_provider/aws/ecs.md b/specification/resource/semantic_conventions/cloud_provider/aws/ecs.md index 57985a6c1..1b6cd2203 100644 --- a/specification/resource/semantic_conventions/cloud_provider/aws/ecs.md +++ b/specification/resource/semantic_conventions/cloud_provider/aws/ecs.md @@ -9,7 +9,7 @@ |---|---|---|---|---| | `aws.ecs.container.arn` | string | The Amazon Resource Name (ARN) of an [ECS container instance](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ECS_instances.html). | `arn:aws:ecs:us-west-1:123456789123:container/32624152-9086-4f0e-acae-1a75b14fe4d9` | No | | `aws.ecs.cluster.arn` | string | The ARN of an [ECS cluster](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/clusters.html). | `arn:aws:ecs:us-west-2:123456789123:cluster/my-cluster` | No | -| `aws.ecs.launchtype` | string | The [launch type](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/launch_types.html) for an ECS task. | `EC2`; `Fargate` | No | +| `aws.ecs.launchtype` | string | The [launch type](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/launch_types.html) for an ECS task. | `ec2`; `fargate` | No | | `aws.ecs.task.arn` | string | The ARN of an [ECS task definition](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definitions.html). | `arn:aws:ecs:us-west-1:123456789123:task/10838bed-421f-43ef-870a-f43feacbbb5b` | No | | `aws.ecs.task.family` | string | The task definition family this task definition is a member of. | `opentelemetry-family` | No | @@ -17,6 +17,6 @@ | Value | Description | |---|---| -| `EC2` | ec2 | -| `Fargate` | fargate | +| `ec2` | ec2 | +| `fargate` | fargate |