Add net.host.name and net.host.ip to rpc server (#2447)

This commit is contained in:
Trask Stalnaker 2022-04-01 22:40:05 -07:00 committed by GitHub
parent fc0090a6ef
commit 33b2703c32
2 changed files with 24 additions and 2 deletions

View File

@ -60,6 +60,16 @@ groups:
- net.peer.ip
- net.peer.name
- include: network
- id: rpc.server
prefix: rpc
extends: rpc
span_kind: server
brief: 'Semantic Convention for RPC server spans'
attributes:
- ref: net.host.name
- ref: net.host.ip
- id: rpc.grpc
prefix: rpc.grpc
extends: rpc
@ -121,6 +131,7 @@ groups:
value: 16
required: always
brief: "The [numeric status code](https://github.com/grpc/grpc/blob/v1.33.2/doc/statuscodes.md) of the gRPC request."
- id: rpc.jsonrpc
prefix: rpc.jsonrpc
extends: rpc
@ -155,6 +166,7 @@ groups:
note: >
This is always required for jsonrpc. See the note in the general
RPC conventions for more information.
- id: rpc.message
prefix: "message" # TODO: Change the prefix to rpc.message?
type: event

View File

@ -11,8 +11,9 @@ This document defines how to describe remote procedure calls
- [Common remote procedure call conventions](#common-remote-procedure-call-conventions)
* [Span name](#span-name)
* [Attributes](#attributes)
* [Common attributes](#common-attributes)
+ [Service name](#service-name)
* [Server attributes](#server-attributes)
* [Events](#events)
* [Distinction from HTTP spans](#distinction-from-http-spans)
- [gRPC](#grpc)
@ -51,7 +52,7 @@ Examples of span names:
`MyServiceReference.ICalculator/Add` reported by the client for .NET WCF calls
- `MyServiceWithNoPackage/theMethod`
### Attributes
### Common attributes
<!-- semconv rpc -->
| Attribute | Type | Description | Examples | Required |
@ -105,6 +106,15 @@ Generally, a user SHOULD NOT set `peer.service` to a fully qualified RPC service
[`service.name`]: ../../resource/semantic_conventions/README.md#service
[`peer.service`]: span-general.md#general-remote-service-attributes
### Server attributes
<!-- semconv rpc.server -->
| Attribute | Type | Description | Examples | Required |
|---|---|---|---|---|
| [`net.host.ip`](span-general.md) | string | Like `net.peer.ip` but for the host IP. Useful in case of a multi-IP host. | `192.168.0.1` | No |
| [`net.host.name`](span-general.md) | string | Local hostname or similar, see note below. | `localhost` | No |
<!-- endsemconv -->
### Events
In the lifetime of an RPC stream, an event for each message sent/received on