Update references from `db.operation` to `db.operation.name` (#904)

This commit is contained in:
Trask Stalnaker 2024-04-08 13:05:09 -07:00 committed by GitHub
parent ff49c9b6fa
commit 49669266d9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 23 additions and 23 deletions

View File

@ -80,7 +80,7 @@ In addition to Cosmos DB attributes, all spans include
| `az.namespace` | `"Microsoft.DocumentDB"` | | `az.namespace` | `"Microsoft.DocumentDB"` |
| `db.system` | `"cosmosdb"` | | `db.system` | `"cosmosdb"` |
| `db.name` | `"database name"` | | `db.name` | `"database name"` |
| `db.operation` | `"ReadItemsAsync"` | | `db.operation.name` | `"ReadItemsAsync"` |
| `server.address` | `"account.documents.azure.com"` | | `server.address` | `"account.documents.azure.com"` |
| `db.cosmosdb.client_id` | `3ba4827d-4422-483f-b59f-85b74211c11d` | | `db.cosmosdb.client_id` | `3ba4827d-4422-483f-b59f-85b74211c11d` |
| `db.cosmosdb.operation_type` | `Read` | | `db.cosmosdb.operation_type` | `Read` |

View File

@ -55,8 +55,8 @@ The **span name** SHOULD be set to a low cardinality value representing the stat
It MAY be a stored procedure name (without arguments), DB statement without variable arguments, operation name, etc. It MAY be a stored procedure name (without arguments), DB statement without variable arguments, operation name, etc.
Since SQL statements may have very high cardinality even without arguments, SQL spans SHOULD be named the Since SQL statements may have very high cardinality even without arguments, SQL spans SHOULD be named the
following way, unless the statement is known to be of low cardinality: following way, unless the statement is known to be of low cardinality:
`<db.operation> <db.name>.<db.collection.name>`, provided that `db.operation` and `db.collection.name` are available. `<db.operation.name> <db.name>.<db.collection.name>`, provided that `db.operation` and `db.collection.name` are available.
If `db.collection.name` is not available due to its semantics, the span SHOULD be named `<db.operation> <db.name>`. If `db.collection.name` is not available due to its semantics, the span SHOULD be named `<db.operation.name> <db.name>`.
It is not recommended to attempt any client-side parsing of `db.statement` just to get these properties, It is not recommended to attempt any client-side parsing of `db.statement` just to get these properties,
they should only be used if the library being instrumented already provides them. they should only be used if the library being instrumented already provides them.
When it's otherwise impossible to get any meaningful span name, `db.name` or the tech-specific database name MAY be used. When it's otherwise impossible to get any meaningful span name, `db.name` or the tech-specific database name MAY be used.

View File

@ -101,7 +101,7 @@ Tracing instrumentations that do so, MUST also set `http.request.method_original
| `server.port` | `9200` | | `server.port` | `9200` |
| `http.request.method` | `"GET"` | | `http.request.method` | `"GET"` |
| `db.statement` | `"{\"query\":{\"term\":{\"user.id\":\"kimchy\"}}}"` | | `db.statement` | `"{\"query\":{\"term\":{\"user.id\":\"kimchy\"}}}"` |
| `db.operation` | `"search"` | | `db.operation.name` | `"search"` |
| `url.full` | `"https://elasticsearch.mydomain.com:9200/my-index-000001/_search?from=40&size=20"` | | `url.full` | `"https://elasticsearch.mydomain.com:9200/my-index-000001/_search?from=40&size=20"` |
| `db.elasticsearch.path_parts.index` | `"my-index-000001"` | | `db.elasticsearch.path_parts.index` | `"my-index-000001"` |
| `db.elasticsearch.cluster.name` | `"e9106fc68e3044f0b1475b04bf4ffd5f"` | | `db.elasticsearch.cluster.name` | `"e9106fc68e3044f0b1475b04bf4ffd5f"` |

View File

@ -30,7 +30,7 @@ described on this page.
## Example ## Example
| Key | Value | | Key | Value |
| :---------------------- | :----------------------------------------------------------- | |:------------------------| :----------------------------------------------------------- |
| Span name | `"products.findAndModify"` | | Span name | `"products.findAndModify"` |
| `db.system` | `"mongodb"` | | `db.system` | `"mongodb"` |
| `server.address` | `"mongodb0.example.com"` | | `server.address` | `"mongodb0.example.com"` |
@ -40,7 +40,7 @@ described on this page.
| `network.transport` | `"tcp"` | | `network.transport` | `"tcp"` |
| `db.name` | `"shopDb"` | | `db.name` | `"shopDb"` |
| `db.statement` | not set | | `db.statement` | not set |
| `db.operation` | `"findAndModify"` | | `db.operation.name` | `"findAndModify"` |
| `db.mongodb.collection` | `"products"` | | `db.mongodb.collection` | `"products"` |
[DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.31.0/specification/document-status.md [DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.31.0/specification/document-status.md

View File

@ -42,7 +42,7 @@ Furthermore, `db.name` is not specified as there is no database name in Redis an
| `network.transport` | `"unix"` | | `network.transport` | `"unix"` |
| `db.name` | not set | | `db.name` | not set |
| `db.statement` | `"HMSET myhash field1 'Hello' field2 'World"` | | `db.statement` | `"HMSET myhash field1 'Hello' field2 'World"` |
| `db.operation` | not set | | `db.operation.name` | not set |
| `db.redis.database_index` | `15` | | `db.redis.database_index` | `15` |
[DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.31.0/specification/document-status.md [DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.31.0/specification/document-status.md

View File

@ -33,7 +33,7 @@ In the case of `EXEC`, this SHOULD be the stored procedure name that is being ex
This is an example of attributes for a MySQL database span: This is an example of attributes for a MySQL database span:
| Key | Value | | Key | Value |
|:------------------------| :----------------------------------------------------------- | |:-----------------------| :----------------------------------------------------------- |
| Span name | `"SELECT ShopDb.orders"` | | Span name | `"SELECT ShopDb.orders"` |
| `db.system` | `"mysql"` | | `db.system` | `"mysql"` |
| `server.address` | `"shopdb.example.com"` | | `server.address` | `"shopdb.example.com"` |
@ -43,7 +43,7 @@ This is an example of attributes for a MySQL database span:
| `network.transport` | `"tcp"` | | `network.transport` | `"tcp"` |
| `db.name` | `"ShopDb"` | | `db.name` | `"ShopDb"` |
| `db.statement` | `"SELECT * FROM orders WHERE order_id = 'o4711'"` | | `db.statement` | `"SELECT * FROM orders WHERE order_id = 'o4711'"` |
| `db.operation` | `"SELECT"` | | `db.operation.name` | `"SELECT"` |
| `db.collection.name` | `"orders"` | | `db.collection.name` | `"orders"` |
[DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.31.0/specification/document-status.md [DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.31.0/specification/document-status.md

View File

@ -44,7 +44,7 @@ groups:
type: span type: span
brief: "Attributes that exist for multiple DynamoDB request types." brief: "Attributes that exist for multiple DynamoDB request types."
attributes: attributes:
- ref: db.operation - ref: db.operation.name
brief: "The same value as `rpc.method`." brief: "The same value as `rpc.method`."
examples: examples:
- GetItem - GetItem