open-telemetry
/
semantic-conventions
mirror of https://github.com/open-telemetry/semantic-conventions.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Require two approvals from different companies before merging the PR (#364) 

Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
This commit is contained in:
Reiley Yang 2023-10-08 22:35:41 -07:00 committed by GitHub
parent 0af7e0efee
commit 4efa49f4e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
CONTRIBUTING.md
View File

@ -157,6 +157,23 @@ To quickly fix typos, use
make misspell-correction make misspell-correction
``` ```
### How to get your PR merged
A PR (pull request) is considered to be **ready to merge** when:
* It has received at least two approvals from the [code
owners](./.github/CODEOWNERS) (if approvals are from only one company, they
won't count).
* There is no `request changes` from the [code owners](./.github/CODEOWNERS).
* It has been at least two working days since the last modification (except for
the trivial updates, such like typo, cosmetic, rebase, etc.). This gives
people reasonable time to review.
* Trivial changes (typos, cosmetic changes, CI improvements, etc.) don't have to
wait for two days.
Any [maintainer](./README.md#contributing) can merge the PR once it is **ready
to merge**.
## Updating the referenced specification version ## Updating the referenced specification version
1. Open the `./internal/tools/update_specification_version.sh` script. 1. Open the `./internal/tools/update_specification_version.sh` script.