open-telemetry
/
semantic-conventions
mirror of https://github.com/open-telemetry/semantic-conventions.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Editorial: Remove overlooked messaging.source attributes from aws lambda examples (#200) 

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
This commit is contained in:
Liudmila Molkova 2023-07-21 07:39:39 -07:00 committed by GitHub
parent b9ca87a4a9
commit 508bf73153
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
docs/faas/aws-lambda.md
View File

@ -116,7 +116,6 @@ See [compatibility](../../supplementary-guidelines/compatibility/aws.md#context-
- [`faas.trigger`][faas] MUST be set to `pubsub`. - [`faas.trigger`][faas] MUST be set to `pubsub`.
- [`messaging.operation`](/docs/messaging/messaging-spans.md) MUST be set to `process`. - [`messaging.operation`](/docs/messaging/messaging-spans.md) MUST be set to `process`.
- [`messaging.system`](/docs/messaging/messaging-spans.md) MUST be set to `AmazonSQS`. - [`messaging.system`](/docs/messaging/messaging-spans.md) MUST be set to `AmazonSQS`.
- [`messaging.destination.kind` or `messaging.source.kind`](/docs/messaging/messaging-spans.md#messaging-attributes) MUST be set to `queue`.
### SQS Message ### SQS Message
@ -209,15 +208,12 @@ Function F: | Span ProcBatch |
| SpanKind | `PRODUCER` | `PRODUCER` | `CONSUMER` | `CONSUMER` | `CONSUMER` | | SpanKind | `PRODUCER` | `PRODUCER` | `CONSUMER` | `CONSUMER` | `CONSUMER` |
| Status | `Ok` | `Ok` | `Ok` | `Ok` | `Ok` | | Status | `Ok` | `Ok` | `Ok` | `Ok` | `Ok` |
| `messaging.system` | `AmazonSQS` | `AmazonSQS` | `AmazonSQS` | `AmazonSQS` | `AmazonSQS` | | `messaging.system` | `AmazonSQS` | `AmazonSQS` | `AmazonSQS` | `AmazonSQS` | `AmazonSQS` |
| `messaging.destination.name` | `Q` | `Q` | | | | | `messaging.destination.name` | `Q` | `Q` | `Q` | `Q` | `Q` |
| `messaging.source.name` | | | `Q` | `Q` | `Q` |
| `messaging.destination.kind` | `queue` | `queue` | | | |
| `messaging.source.kind` | | | `queue` | `queue` | `queue` |
| `messaging.operation` | | | `process` | `process` | `process` | | `messaging.operation` | | | `process` | `process` | `process` |
| `messaging.message.id` | | | | `"a1"` | `"a2"` | | `messaging.message.id` | | | | `"a1"` | `"a2"` |
Note that if Span Prod1 and Span Prod2 were sent to different queues, Span ProcBatch would not have Note that if Span Prod1 and Span Prod2 were sent to different queues, Span ProcBatch would not have
`messaging.source.name` set as it would correspond to multiple sources. `messaging.destination.name` set as it would correspond to multiple queues.
The above requires user code change to create `Span Proc1` and `Span Proc2`. In Java, the user would inherit from The above requires user code change to create `Span Proc1` and `Span Proc2`. In Java, the user would inherit from
[TracingSqsMessageHandler][] instead of Lambda's standard `RequestHandler` to enable them. Otherwise these two spans [TracingSqsMessageHandler][] instead of Lambda's standard `RequestHandler` to enable them. Otherwise these two spans