From 92ffed69527efbf1de36947e93ca414647885706 Mon Sep 17 00:00:00 2001 From: Bradley Grainger Date: Mon, 19 May 2025 08:44:34 -0700 Subject: [PATCH] Fix system name for MySQL (#2276) Co-authored-by: Trask Stalnaker --- .chloggen/2276.yaml | 22 ++++++++++++++++++++++ docs/database/mysql.md | 2 +- model/database/spans.yaml | 2 +- 3 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 .chloggen/2276.yaml diff --git a/.chloggen/2276.yaml b/.chloggen/2276.yaml new file mode 100644 index 000000000..55273383f --- /dev/null +++ b/.chloggen/2276.yaml @@ -0,0 +1,22 @@ +# Use this changelog template to create an entry for release notes. +# +# If your change doesn't affect end users you should instead start +# your pull request title with [chore] or use the "Skip Changelog" label. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: bug_fix + +# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) +component: db + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Fix the `db.system.name` attribute value for MySQL which was incorrectly pointing to `microsoft.sql_server`. + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +# The values here must be integers. +issues: [ 2276 ] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: diff --git a/docs/database/mysql.md b/docs/database/mysql.md index defc9b362..255292889 100644 --- a/docs/database/mysql.md +++ b/docs/database/mysql.md @@ -28,7 +28,7 @@ The Semantic Conventions for *MySQL* extend and override the [Database Semantic Spans representing calls to a MySQL Server adhere to the general [Semantic Conventions for Database Client Spans](database-spans.md). -`db.system.name` MUST be set to `"microsoft.sql_server"` and SHOULD be provided **at span creation time**. +`db.system.name` MUST be set to `"mysql"` and SHOULD be provided **at span creation time**. **Span kind** SHOULD be `CLIENT`. diff --git a/model/database/spans.yaml b/model/database/spans.yaml index c6f196a63..099a46284 100644 --- a/model/database/spans.yaml +++ b/model/database/spans.yaml @@ -229,7 +229,7 @@ groups: brief: > Spans representing calls to a MySQL Server adhere to the general [Semantic Conventions for Database Client Spans](database-spans.md). note: | - `db.system.name` MUST be set to `"microsoft.sql_server"` and SHOULD be provided **at span creation time**. + `db.system.name` MUST be set to `"mysql"` and SHOULD be provided **at span creation time**. attributes: - ref: db.namespace sampling_relevant: true