open-telemetry
/
semantic-conventions
mirror of https://github.com/open-telemetry/semantic-conventions.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Should -> SHOULD (#946) 

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
This commit is contained in:
Trask Stalnaker 2024-04-23 02:47:35 -07:00 committed by GitHub
parent c0e170d51e
commit dd73dba5ac
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/database/database-spans.md
View File

@ -96,7 +96,7 @@ These attributes will usually be the same for all operations performed over the
**[6]:** If using a port other than the default port for this DBMS and if `server.address` is set.
**[7]:** Should be collected by default only if there is sanitization that excludes sensitive information.
**[7]:** SHOULD be collected by default only if there is sanitization that excludes sensitive information.
**[8]:** Semantic conventions for individual database systems SHOULD document whether `network.peer.*` attributes are applicable. Network peer address and port are useful when the application interacts with individual database nodes directly.
If a database operation involved multiple network calls (for example retries), the address of the last contacted node SHOULD be used.

2
docs/database/redis.md
View File

@ -24,7 +24,7 @@ described on this page.
**[1]:** For **Redis**, the value provided for `db.query.text` SHOULD correspond to the syntax of the Redis CLI. If, for example, the [`HMSET` command](https://redis.io/commands/hmset) is invoked, `"HMSET myhash field1 'Hello' field2 'World'"` would be a suitable value for `db.query.text`.
**[2]:** Should be collected by default only if there is sanitization that excludes sensitive information.
**[2]:** SHOULD be collected by default only if there is sanitization that excludes sensitive information.
**[3]:** If a database operation involved multiple network calls (for example retries), the address of the last contacted node SHOULD be used.
<!-- endsemconv -->

2
model/trace/database.yaml
View File

@ -7,7 +7,7 @@ groups:
- ref: db.query.text
requirement_level:
recommended: >
Should be collected by default only if there is sanitization that excludes sensitive information.
SHOULD be collected by default only if there is sanitization that excludes sensitive information.
- ref: db.query.parameter
requirement_level: opt_in