Commit Graph

29 Commits

Author SHA1 Message Date
Giovanni Liva 46b79ae1e7 Consistency between Span and Resource attributes (#777)
* Consistency between Span and Resource attributes

* Address feedback

* Wording
2023-11-16 12:50:59 -05:00
Reiley Yang 4a2a4ef946 DocFX sanity check (#742) 2023-11-16 12:50:59 -05:00
Bogdan Drutu 4f5831ca5f Centralize attributes definition (#722)
* Centralize attributes definition

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/overview.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2023-11-16 12:50:59 -05:00
Patrice Chalin 7a55bf2c53 Ensure common section has a README (#2479) 2023-11-16 12:50:59 -05:00
Tigran Najaryan b1abb50dd6 Implement OTEP 0178: Mapping external data to AnyValue (#2385)
OTEP 0178 [0] proposed this mapping. This PR merges the proposal into specification.
The content of this PR is mostly copy/paste of the text of the OTEP minus the
irrelevant sections such as "Alternates", etc.

0 - https://github.com/open-telemetry/oteps/blob/main/text/0178-mapping-to-otlp-anyvalue.md
2023-11-16 12:50:59 -05:00
Reiley Yang d1296366cf Fix links (#2426) 2023-11-16 12:50:59 -05:00
David Ashpole 5bf1bbed5b Describe how to convert non-string primitives for protocols which only support strings (#2343)
* Describe how to handle converting non-string primitives for protocols that only support strings

* update wording to make clear that only non-string values are converted to strings

* unify language

* Update specification/common/common.md

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2023-11-16 12:50:59 -05:00
Tigran Najaryan a2667a2dec Clarify that attribute keys are unique in collections (#2248)
Attributes keys must be unique. The key/value pair collections in the specification
was always intended to model a map.

There was a recent confusion about this. This change clarifies the spec.

Resolves https://github.com/open-telemetry/opentelemetry-specification/issues/2245
2023-11-16 12:50:59 -05:00
Patrice Chalin 537b07fcd6 Ensure all ToCs are generated using markdown-toc (#2146) 2023-11-16 12:50:59 -05:00
Patrice Chalin 5c85918533 Provide a normative definition of Attribute (singular) rather than Attributes (plural) (#2123)
* Provide a normative definition of Attribute (singular)

- Providing a normative definition of **attribute** (singular)
- Other copyedits

/cc @austinlparker @tedsuo

* Move anchor to make markdown checker happy
2023-11-16 12:50:59 -05:00
Owais Lone 8d35d0c0fd Exempt resources from attribute limits (#1892)
Resources are not susceptible to scenarios where excessive attributes
can be recorded unlike Spans. Resources are also immutable and it can be
hard for some SDKs to apply the limits at source at the time the
attributes are added to a resource. Furthermore, limits and Resources
both are generally defined and passed on to a TracerProvider which
forces a TracerProvider to either mutate the resource or generate a new
one with duplicate attributes in order to apply the limits to it.

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
2023-11-16 12:50:59 -05:00
Owais Lone 8c6e0dd69c Prefer global limit over model-specific default (#1893) 2023-11-16 12:50:59 -05:00
Jakub Malinowski 2ecdb1f1a2 Add an option to limit length of values of attributes and metric values (#1130) 2023-11-16 12:50:59 -05:00
Jakub Malinowski dcf74c311a Rename Metrics labels to attributes (#1775) 2023-11-16 12:50:59 -05:00
Ted Young 7a3f37d933 Add lifecycle statuses to all documents (#1385) 2023-11-16 12:50:59 -05:00
Tigran Najaryan e8587bacc8 Declare freeze of Trace API Specification 1.0 (#1121)
* Declare freeze of Trace Specification 1.0

We want to freeze Trace specification 1.0 so that we no longer accept substantial changes (unless a fundamental problem is found in the spec).

Resolves https://github.com/open-telemetry/opentelemetry-specification/issues/1120
2023-11-16 12:50:59 -05:00
Christian Neumüller 1cbb4af73d Nulls SHOULD NOT be allowed in arrays. (#1214)
* Nulls SHOULD NOT be allowed in arrays.

* Fill in CHANGELOG link

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2023-11-16 12:50:59 -05:00
Tigran Najaryan fb0804ed30 Add guidance on when to use and not use nested namespaces (#1197)
This topic has come up at least 3 times now. I believe a clarification is
warranted. The clarification is aligned with previous recommendations:
https://github.com/open-telemetry/opentelemetry-specification/pull/789#issuecomment-675506855
https://github.com/open-telemetry/opentelemetry-specification/pull/882#issuecomment-690945900
https://github.com/open-telemetry/opentelemetry-specification/pull/1194#issuecomment-722431982
2023-11-16 12:50:59 -05:00
Przemek Maciolek 01e5a6d827 Include attribute name pluralization guidelines (#1115) (#1140) 2023-11-16 12:50:59 -05:00
Christian Neumüller 550a2b904b Remove ordering reqirement for attributes. (#1212)
* Remove ordering for attributes.

* Fill in CHANGELOG link
2023-11-16 12:50:59 -05:00
Christian Neumüller 2d55f5436f Fix absolute links to spec (#1192)
* Remove absolute links where possible.

* Work around semantic conventions.

* Docfx.

* Fix YAML.

* More docfx.
2023-11-16 12:50:59 -05:00
Armin Ruech aa5effe43c Define `null` as an invalid value for attributes and declare attempts to set `null` as undefined behavior (#992) 2023-11-16 12:50:59 -05:00
Tigran Najaryan a59a1b218c Require that names and namespaces are one global space across all semantic convention areas (#832)
* Require that names and namespaces are one global space across all semantic convention areas

We have semantic conventions for Resources, Spans and Metrics (in the future also Logs are expected).
It was not clear if the attribute names across all convention areas should be globally unique.

This commit asserts that conventions are one space, they are not independent spaces with
their own namespaces each.

We prohibit using the same Span or Resource attribute name or metric label name but give them
slightly different meanings or value sets.

Resolves: https://github.com/open-telemetry/opentelemetry-specification/issues/815

* Address PR comments

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2023-11-16 12:50:59 -05:00
Bogdan Drutu 52061e2f52 Fix lint check in makefile, fix errors (#837)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2023-11-16 12:50:59 -05:00
Tigran Najaryan 2096cb3ec5 Extend attribute naming rules to metric labels (#821)
* Extend attribute naming rules to metric labels

We earlier defined naming rules for attributes, however we do not have
similar rules for metric labels. This commit extends the exact same
set of rules to metric labels.

This was brought up in this comment https://github.com/open-telemetry/opentelemetry-specification/pull/807#discussion_r471550053

* Address PR comments
2023-11-16 12:50:59 -05:00
Tigran Najaryan 795086a9a5 Add conventions for attribute names (#807)
* Add conventions for attribute names

Resolves: https://github.com/open-telemetry/opentelemetry-specification/issues/726

* Address PR comments

* Re-word company/application specific attribute recommendations
2023-11-16 12:50:59 -05:00
Giovanni Liva 19fced8d4f Consistency between Span and Resource attributes (#777)
* Consistency between Span and Resource attributes

* Address feedback

* Wording
2023-11-16 12:50:59 -05:00
Reiley Yang c82cc039d7 DocFX sanity check (#742) 2023-11-16 12:50:59 -05:00
Bogdan Drutu 56071a8642 Centralize attributes definition (#722)
* Centralize attributes definition

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/overview.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2023-11-16 12:50:59 -05:00