Commit Graph

154 Commits

Author SHA1 Message Date
Frank Spitulski 84a9ddfe9a Add more attributes for Cassandra to database semantic conventions (#1217)
* feat(cassandra): more tags

* Update semantic_conventions/trace/database.yaml

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update semantic_conventions/trace/database.yaml

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update semantic_conventions/trace/database.yaml

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* incorporate changes

* Update semantic_conventions/trace/database.yaml

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* incorporate feedback

* additional feedback

* revert unchanged file

* Update semantic_conventions/trace/database.yaml

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update specification/trace/semantic_conventions/database.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* split cassandra to separate table

* Update specification/trace/semantic_conventions/database.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-12-09 14:23:23 -08:00
Mateusz Rzeszutek 0c0bae3f6d Add missing thread.* attributes to semconv yaml file (#1262)
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-11-26 17:53:19 +01:00
Mateusz Rzeszutek f6f976a7de Add a SQL span naming suggestion: <db.operation> <db.name>.<db.sql.table> (#1219)
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-11-24 14:31:26 +01:00
Vladimir Šor f2bc1ad6bd Add YAML definition for code-related semantic attributes. (#1229)
* Introduce code-related semantic attributes.

* Generate table for `code` semantic attributes from the yaml spec.

* Update semantic_conventions/trace/general.yaml

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update semantic_conventions/trace/general.yaml

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Generate table for `code` semantic attributes from the yaml spec.

* Revert line-endings-only change

* Better function name for code.function example.

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-11-19 18:55:10 +01:00
Justin Foote be808a12d2 Remove deprecated span status codes from http semantic conventions (#1216) 2020-11-10 08:10:45 -08:00
Justin Foote 2cd9fbb859 Database semantic conventions: Add db.table, allow SQL keyword as db.operation (#1141)
* Add db.table to database semantic conventions

* Fix spacing in db semantic conventions

* Move db.table to SQL-specific call level attributes

* Clarify instructions for setting db.operation to a SQL keyword

* Specify that db.sql.table MUST NOT be set when not applicable

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Add db.table and db.operation to CHANGELOG

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-11-09 19:47:40 +01:00
Anuraag Agrawal 355a7f5740 Use MUST consistently instead of SHALL (#1208)
* Use MUST consistently instead of shall.

* Update specification/trace/semantic_conventions/messaging.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-11-08 15:48:53 -05:00
Yusuke Tsutsumi ce1a267d21 Updating gRPC status semantic conventions (#1156)
* Updating gRPC status semantic conventions

Since the simplification of trace status codes,
they no longer align with gRPC.

Clarifying the expected status code field for gRPC, as
well as the mappings between gRPC and OpenTelemetry status.

* Adding changelog entry

* Addressing feedback

Clarifying that gRPC spans should include the status code number,
rather than leave it ambiguous.

Adding gRPC semantic conventions in the yaml files to reflect these
changes.

* adding trailing whitespace

* Apply suggestions from code review

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* addressing feedback

Ran table-generation to ensure that semantic conventions are added.

Removed tags for rpc.grpc yaml for now (not explicitly used).

* Update specification/trace/semantic_conventions/rpc.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Addressing feedback

re-generating TOC with markdown-toc

There was a conflict with sub-headings matching the same string. As such
qualified all headings.

* Switching gRPC status_code type to enum

gRPC's status_code code is better expressed as an enum.

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-11-06 15:06:46 -08:00
Christian Neumüller aa14918823 Fix absolute links to spec (#1192)
* Remove absolute links where possible.

* Work around semantic conventions.

* Docfx.

* Fix YAML.

* More docfx.
2020-11-04 12:29:48 -08:00
Carlos Alberto Cortez e5de3ac8c1 Revert "Rename SpanContext to SpanReference. (#1075)" (#1127) 2020-10-24 00:16:31 +02:00
Ken Finnigan 8b6a13ad16 Resolve semantic inconsistencies for non traditional messaging (#1027)
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-10-21 15:28:20 +02:00
Giovanni Liva 98d2cc53f8 Add yaml for FaaS trace attributes (#1054)
Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-10-19 18:36:54 +02:00
Carlos Alberto Cortez 06db49aae3 Rename SpanContext to SpanReference. (#1075)
* Rename SpanContext to SpanReference.

* More updates.

* Update CHANGELOG

* Update specification/metrics/api.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/metrics/api.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/metrics/api.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/metrics/api.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/overview.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/overview.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/metrics/api.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Add entry to the compliance matrix.

* Update specification/overview.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-10-14 08:40:18 -07:00
Bogdan Drutu 138b4e4d88 Change Status to be consistent with Link and Event (#1067)
* Change Status to be consistent with Link and Event

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Add changelog entry

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Fix link to status

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/trace/api.md

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

* Update specification/trace/api.md

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

* Fix markdown errors

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/trace/api.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-10-07 11:21:31 -07:00
Giovanni Liva 9f09d2db7e Add yaml semantic conventions for Messaging (#926) 2020-09-29 14:34:02 +02:00
Ted Young bbd284a9d9 Error Flagging with Status Codes (#966)
* StatusSource definition

* Update HTTP status code mapping

* Remove span status

* Apply feedback.

* Remove unused link.

* markdownlint

* spelling

Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
2020-09-24 11:24:31 -07:00
Giovanni Liva 5874138953 Add yaml semantic conventions for RPC (#925) 2020-09-24 15:06:48 +02:00
Armin Ruech f6cd4c2e1a Remove obsolete `http.status_text` from semantic conventions (#972) 2020-09-22 11:49:09 +02:00
Christian Neumüller 0ce8f09464 Exception semantic conventions: Add example & more explanation for exception.escaped. (#946)
* Add example & explanation for exception.escaped.

* Reshuffle paragraphs.

* Remove potentially controversial changes.

* Fill in CHANGELOG link.

* Address review comments.

* Wording

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>

* Use actual OTel-Java API.

* Revert "Use actual OTel-Java API."

This reverts commit d359f477017d4ec0f71191eabae6b1edecee79fb.

* Clarify CHANGELOG

* Re-generate tables.

* Typo in CHANGELOG.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Clarify exception escaped description.

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-09-19 08:24:46 -04:00
Armin Ruech 044aef6378 Add semantic convention for source code attributes (#901) 2020-09-15 17:33:58 +02:00
Giovanni Liva 5f0ed87925 Add yaml semantic conventions for Exception (#927) 2020-09-15 15:30:38 +02:00
Giovanni Liva a50ad7376b Add yaml semantic conventions for Database (#928)
* Add yaml semantic conventions for Database

* Address feedback
2020-09-11 09:15:46 -07:00
Christian Neumüller 0da3c1a599 Add exception.escaped attribute. (#784)
* Add exception.escaped attribute.

This reverts commit 80ea27df4dd858b686d91ef37dad89aa8cd89439.

* New wording for API change.

* Remove additional condition for escaped parameter.

* Remove exception.escaped from the API.

* Add CHANGELOG entry.

* Wrong PR# in CHANGELOG.

* Wrong wrong PR# in CHANGELOG (hey anagrams!).

* Closing )

* Typos

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-09-08 07:44:34 -07:00
Gene Liverman 7f54e65cf7 Fix the rendering of the table (#921)
* Fix table display

* Update specification/trace/semantic_conventions/span-general.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-09-04 11:21:30 -07:00
Tigran Najaryan 6d12dec4d9 Delete sentence about using span name when faas.name is absent (#915)
As pointed out here https://github.com/open-telemetry/opentelemetry-specification/pull/888#discussion_r478866767
if faas.name is not set, the Instrumentation probably doesn't know the name
and thus the span name would most likely also not contain it.

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-09-03 13:13:50 -07:00
Armin Ruech 3c241627c3 Fix Ruby link reference in exceptions.md (#917) 2020-09-02 20:37:52 +02:00
Armin Ruech f6f5ce62ef Add semantic conventions for outgoing FaaS invocations (#862) 2020-09-02 17:18:46 +02:00
Tigran Najaryan a5f6991ebe Clarify function name conventions (#888) 2020-08-28 01:28:30 +02:00
Giovanni Liva 521dfd99aa YAML Model for Semantic Conventions (#571)
* First model draft

* Fix checkstyle

* Generate network table from YAML

* HTTP semantic convention tables

* Fix requirements order

* Add code and basic documentation

* Missing \n

* Remove tool

* Add General and HTTP semantic convention

* Update table style

* yaml->semantic_conventions

* Fix small errors

* Fix docfx errors

* Update Makefile to use otel Docker repo

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-08-27 13:18:51 -07:00
Bogdan Drutu be35f68e5a Rename CorrelationContext to Baggage (#857)
* Rename CorrelationContext to Baggage

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-08-25 23:15:07 -07:00
Bogdan Drutu 11997ecad6 Fix lint check in makefile, fix errors (#837)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-08-19 14:43:05 -07:00
Mateusz Rzeszutek 6e96f1bbee Add semantic conventions for thread.name and thread.id span attributes (#789) 2020-08-18 17:55:42 +02:00
Anuraag Agrawal 3bb80b2ad1 Add link to exceptions from folder README (#795) 2020-08-13 07:33:39 -07:00
Christian Neumüller 1d03f8f5ec Fix exception.stacktrace recommendation for Ruby. (#765)
* Fix exception.stacktrace recommendation for Ruby.

All other stacktraces use the full message (including type, message,
etc), for Ruby only the plain stacktrace.

* Don't downgrade Ruby version.
2020-08-12 18:40:26 -07:00
Reiley Yang 3c720edee4 DocFX sanity check (#742) 2020-07-27 19:51:44 +02:00
Matthew Wear 18c42b60ca Exception reporting specification (#697)
* Add semantic conventions for errors

* Update error.type description

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* update semantic conventions for exceptions

* add details for attributes; remove log.severity; add API details

* rename exceptions.md -> exception-reporting.md

* more accurately describe format for java

* alphabetize languages in stacktrace representation table

* prefer dynamic type over static type

* add log.severity convention

* Revert "add log.severity convention"

This reverts commit 137556e44bf74e6d76a17bd81943702a460cb9de.

* rename stacktrace -> exception.stacktrace

* move file to semantic conventions directory

* move RecordException to API

* fix formatting

Co-authored-by: Armin Ruech <armin.ruech@gmail.com>
2020-07-17 12:52:48 -04:00
Armin Ruech c724898be9 Adapt semantic conventions for the span name of messaging systems (#690)
* Adapt messaging semantic conventions to include the operation in the span name

* Specify that the operation name must match the respective attribute if the suggested span name format is used

* Update span names in examples

* Consolidate definition of operation names into a separate section

* Consolidate capitalization

* Reference Conversation ID definition

* Consolidate MD syntax

* Organize definitions

* Organize definitions

* Reference definitions

* Allow artificial destinations as span name if neither destination name nor conversation ID are suitable

* Do not use conversation IDs for span name

* Wording

Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com>

* Fix typo

* Add more links and guidance on messaging.operation

* Fix changelog

Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com>
2020-07-15 13:14:56 -07:00
Anuraag Agrawal 72cb7df3e3 Add mapping for nginx 499 http status (#677) 2020-07-10 17:56:07 +02:00
Armin Ruech ad04016439 Fix Redis sample (db.redis.database_index was missing) (#692) 2020-07-09 19:26:56 +02:00
Armin Ruech c45e0c33a7 Revise and extend semantic conventions for databases (#575) 2020-07-01 19:29:01 +02:00
Anuraag Agrawal 2c07f78112 Add peer.service semantic convention to indicate the name of a target… (#652)
* Add peer.service semantic convention to indicate the name of a target remote service.

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Simplify

* Remove fallback wording

* Needs to be configured using instrumentation

* CHANGELOG

* Clarify relationship with rpc.service and peer.service and some examples

* Clarify example

* Move peer.service / rpc.service relationship explanation to rpc doc.

* Apply suggestions from code review

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/trace/semantic_conventions/span-general.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Cleanup

* Tweak

* Update specification/trace/semantic_conventions/rpc.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update CHANGELOG.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update specification/trace/semantic_conventions/span-general.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* TOC

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-06-30 09:32:23 -07:00
Anuraag Agrawal 9a1b74f9c1 Add semantic conventions for http content size (#641)
* Add semantic conventions for http content size

* Suffix not midfix
2020-06-25 18:02:02 -04:00
Armin Ruech ed21f09e46 Extend semantic conventions for RPC and allow non-gRPC calls (#604)
* Generalize RPC semantic conventions to allow non-gRPC spans

* Add method name to attributes

* Require specifying `net.transport` for non-IP connections

* Do not require providing the port when it's not available

* Add package name to rpc.service and make it optional when not applicable or unknown

* Add note and example distinguishing the service.name resource attribute from rpc.service

* Distinguish RPC spans from HTTP spans

* Improve wording

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Improve wording

* Improve wording even more

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Clarify span name format

* Update changelog

* rpc.method: required -> recommended

* rpc.service: required -> recommended

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-06-17 10:58:26 -07:00
Armin Ruech 4ba638ad0d Add span attribute to indicate cold starts of Function as a Service executions (#650)
* Add `faas.coldstart` attribute

* Update changelog
2020-06-15 11:15:02 -07:00
Armin Ruech 79707b7df9 Link from trace (and metric) semantic conventions to resources (#603) 2020-05-14 10:11:11 -07:00
Armin Ruech 709940084a Fix HTTP span example (#576)
`host.port` was renamed to `net.host.port` in #349
2020-04-28 15:29:29 +02:00
Christian Neumüller b03e37895b Clarify messaging.system. (#558)
I'm not sure what this should have to do with vendors, according to the examples, this would be the actual system names themselves. Otherwise the vendor for kafka would probably be "Apache", for example.
2020-04-22 07:35:51 -07:00
Armin Ruech 587693abbf Add payload size to messaging semantic conventions (#550) 2020-04-17 18:07:41 +02:00
Armin Ruech b477c8dbba Clarify span status guidance for HTTP spans (#537) 2020-04-14 16:54:50 +02:00
Giovanni Liva 8119013630 Add missing link (#561) 2020-04-10 07:35:33 -07:00
Armin Ruech 4d1da099a0 Fix markdown-link-check and dead links (#555) 2020-04-09 16:36:01 +02:00
Giovanni Liva e85fca0fc1 Add Semantic Conventions for Function as a Service (#471) 2020-04-07 17:12:45 +02:00
Armin Ruech 929e370037 Define span attributes for messaging systems (#418) 2020-04-07 17:08:56 +02:00
Bogdan Drutu 0dceae42ab Move specifications into sub-directories per signal (#546)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-04-06 17:25:53 -04:00