Commit Graph

9 Commits

Author SHA1 Message Date
Armin Ruech 561ad88d7f Update semantic conventions to distinguish int from double (#1550) 2021-03-18 17:06:10 +01:00
Yuri Shkuro 55c4909ebb Fix capitalization of MUST NOT/SHOULD NOT (#1404)
* Fix capitalization of MUST NOT/SHOULD NOT

* remove redudndant clause
2021-02-05 15:30:06 -08:00
Ted Young eeff36dfd4 Add lifecycle statuses to all documents (#1385) 2021-02-04 15:06:46 +01:00
Sergey Kanzhelev 4f13d9c80b regenerated tables after https://github.com/open-telemetry/build-tools/pull/24 (#1342) 2021-01-14 00:04:10 -08:00
Yusuke Tsutsumi ce1a267d21 Updating gRPC status semantic conventions (#1156)
* Updating gRPC status semantic conventions

Since the simplification of trace status codes,
they no longer align with gRPC.

Clarifying the expected status code field for gRPC, as
well as the mappings between gRPC and OpenTelemetry status.

* Adding changelog entry

* Addressing feedback

Clarifying that gRPC spans should include the status code number,
rather than leave it ambiguous.

Adding gRPC semantic conventions in the yaml files to reflect these
changes.

* adding trailing whitespace

* Apply suggestions from code review

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* addressing feedback

Ran table-generation to ensure that semantic conventions are added.

Removed tags for rpc.grpc yaml for now (not explicitly used).

* Update specification/trace/semantic_conventions/rpc.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Addressing feedback

re-generating TOC with markdown-toc

There was a conflict with sub-headings matching the same string. As such
qualified all headings.

* Switching gRPC status_code type to enum

gRPC's status_code code is better expressed as an enum.

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-11-06 15:06:46 -08:00
Giovanni Liva 5874138953 Add yaml semantic conventions for RPC (#925) 2020-09-24 15:06:48 +02:00
Anuraag Agrawal 2c07f78112 Add peer.service semantic convention to indicate the name of a target… (#652)
* Add peer.service semantic convention to indicate the name of a target remote service.

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Simplify

* Remove fallback wording

* Needs to be configured using instrumentation

* CHANGELOG

* Clarify relationship with rpc.service and peer.service and some examples

* Clarify example

* Move peer.service / rpc.service relationship explanation to rpc doc.

* Apply suggestions from code review

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/trace/semantic_conventions/span-general.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Cleanup

* Tweak

* Update specification/trace/semantic_conventions/rpc.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update CHANGELOG.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update specification/trace/semantic_conventions/span-general.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* TOC

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-06-30 09:32:23 -07:00
Armin Ruech ed21f09e46 Extend semantic conventions for RPC and allow non-gRPC calls (#604)
* Generalize RPC semantic conventions to allow non-gRPC spans

* Add method name to attributes

* Require specifying `net.transport` for non-IP connections

* Do not require providing the port when it's not available

* Add package name to rpc.service and make it optional when not applicable or unknown

* Add note and example distinguishing the service.name resource attribute from rpc.service

* Distinguish RPC spans from HTTP spans

* Improve wording

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Improve wording

* Improve wording even more

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Clarify span name format

* Update changelog

* rpc.method: required -> recommended

* rpc.service: required -> recommended

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-06-17 10:58:26 -07:00
Bogdan Drutu 0dceae42ab Move specifications into sub-directories per signal (#546)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-04-06 17:25:53 -04:00