Commit Graph

106 Commits

Author SHA1 Message Date
Armin Ruech 741ac62a15 Bump semantic conventions tool to v0.11.0 and refine enum wording (#2399) 2022-03-04 17:51:37 +01:00
Trask Stalnaker 3aa566575f Add table for well-known rpc.system values (#2377) 2022-03-03 14:38:54 +01:00
Patrice Chalin e16e1f5952 [editorial] Remove repeated sentence in trace semconv (#2352)
Context: #2236, at https://github.com/open-telemetry/opentelemetry-specification/pull/2236/files#r807345305
2022-02-15 14:04:05 -08:00
Armin Ruech 8c9de82151 Pin markdownlint-cli version and apply fixes (#2320)
* Pin markdownlint-cli version

* Apply markdownlint fixes
2022-02-07 10:24:33 -08:00
Carlos Alberto Cortez d62ad18c75 Add opentracing.ref_type semantic convention. (#2297) 2022-01-31 11:14:02 -06:00
Armin Ruech 5799c847fb Add link from FaaS trace to resource attributes (#2256) 2022-01-10 18:00:53 +00:00
Liudmila Molkova 6ecce73b9b Upgrade semconv generator to v0.8.0 (#2236)
* Upgrade semconv generator to v0.8.0

* update specs with semconv gen 0.8.0

* makefile
2022-01-03 14:09:21 -08:00
Tigran Najaryan 7652ed48fa Prohibit usage of retired names in semantic conventions (#2191)
* Prohibit usage of retired names in semantic conventions

This change adds a prohibition clause that requires that no old
metric or attribute name is used for a new attribute.

This is important to ensure reversibility of schema transformation
(converting from a new version to an old version of schema).

Without this restriction the following is possible:

Schema version 1. Attribute A exists.
Schema version 2. Attribute A is renamed to B. Appropriate schema file is created.
Schema version 3. Attribute A is introduced (a completely different new attribute).

Now attempting to go from Version 3 to version 1 is impossible since it requires
renaming B to A (for the change in version 2), but a different attribute A already exists.

* Fix based on comments

* Add changelog entry

Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
2021-12-13 10:04:41 -08:00
Patrice Chalin c543bb9036 [editorial] trace/semantic_conventions/span-general: add missing anchor closing tag (#2083)
Add a missing `</a>` closing tag for the `<a name="nettransport-attribute">` element. Without the closing tag, then entire page after that is taken as content of the anchor, which isn't correct and it breaks table formatting on the website.
2021-10-29 17:06:56 +02:00
Patrice Chalin b008a3a230 trace/semantic_conventions/http: add missing markdown link definition (#2081)
Closes #2079
2021-10-29 15:24:31 +02:00
Patrice Chalin 9f3ad38a9a URL anchor fix: `##` -> `#` (#2075) 2021-10-28 19:22:43 +02:00
alrex e5aa93af07 minor rephrasing in traces/metrics semantic conventions (#2048) 2021-10-21 15:37:43 +02:00
Christian Neumüller 924016dd1a Discourage faas.trigger for client/outgoing spans. (#1921)
* faas.trigger for client/outgoing.
2021-10-20 15:19:39 +02:00
Yuri Shkuro d9fbb6f32c Add Makefile target to auto-generate TOC via markdown-toc (#2020) 2021-10-15 15:04:22 +00:00
Liudmila Molkova 8c7fb44a4e Define HTTP attributes that should be provided at span creation time (#1916) 2021-10-14 14:49:14 +02:00
aaron ai 94b32ee631 Add specific attributes for Apache RocketMQ (#1904) 2021-10-13 11:02:25 +00:00
meteorlxy 3e51df22d7 [semantic conventions] add tencent cloud as a cloud provider (#2006)
* feat: add tencent cloud as a cloud provider

* chore: tweaks

* chore: tweaks

* chore: lint

* chore: changelog

* chore: tweaks

* chore: tweaks

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2021-10-12 19:02:27 +00:00
Nikita Salnikov-Tarnovski 5161633296 Don't set Span.Status for 4xx http status codes for SERVER spans (#1998)
* Don't set Span.Status for 4xx http status codes for SERVER spans
2021-10-12 13:03:23 +02:00
Trask Stalnaker d42afabd91 Remove db.cassandra.keyspace and db.hbase.namespace, and clarify db.name (#1973)
Fixes #1760

## Changes

Removes `db.cassandra.keyspace` and `db.hbase.namespace` (in preference for using `db.name`).

Clarifies `db.name` in the case where a database product provides multiple concepts that could be mapped to `db.name`.
2021-10-08 11:58:31 +00:00
Bogdan Drutu db9fbcf0c7 Avoid using gRPC when generic RPC systems have same properties (#1914)
* Avoid using gRPC when generic RPC systems have same properties

The concept of "streaming" is supported by multiple protocols including gRPC, but also others.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/trace/semantic_conventions/rpc.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2021-09-28 23:59:15 +00:00
Mateusz Rzeszutek 3758cba58b Capture HTTP request/response headers as span attributes (#1898)
* Capture HTTP request/response headers as span attributes

* Reference footnote [2]

* code review suggestions

* code review suggestions

* code review comments

* normalize HTTP header names

* Update specification/trace/semantic_conventions/http.md

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

* code review suggestion

* Add a CHANGELOG entry

* code review suggestions

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
2021-09-21 14:10:45 -04:00
Christian Neumüller 30fed0f050 Clarify some cases for http.host and http.client_ip. (#1890)
* Clarify some cases for http.host and http.client_ip.

* Fill in PR#.
2021-09-07 19:18:49 +00:00
Christian Neumüller 525baf1b76 Add event semantic conventions, update semantic convention generator to v0.5.0 (#1843)
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2021-09-03 16:59:33 +02:00
Ken Finnigan ca8c79d418 Add `consumer_id` to identify the consumer (#1810)
Resolves #1796
2021-08-23 20:27:08 +02:00
Joao Grassi 9b2611ca84 Adjust .NET casing (#1883) 2021-08-23 10:02:35 +02:00
Christian Neumüller 3fffd053af Consistently format enums, fix non-identifier IDs. (#1863) 2021-08-20 16:12:03 +02:00
(Eliseo) Nathaniel Ruiz Nowell 5bcb639d1d Lambda instrumentations should check if X-Ray parent context is valid (#1867) 2021-08-17 14:28:52 +02:00
Ken Finnigan f62dd99dc1 Update trace example for Kafka messaging (#1807) 2021-08-16 16:36:27 +02:00
legendecas 227b4ff1b1 [semantic conventions] add alibaba cloud as a cloud provider (#1831)
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
2021-08-03 11:22:31 +00:00
Bryce Buchanan cbc2e3953c Mobile spec additions (#1759)
* added spec changes per #1647

* added 'wired' as possible value to `net.host.connection_type`

* fixed spacing in CHANGELOG.md

* added mobile carrier attributes to  semantic_conventions/trace/general.yaml

* fixed issue revealed by

* reverted extra space per markdownlint

* made connection_type allow custom values

* added additional space

* removed manually added table & ran generator tool

* separated connection.type & connection.subtype

* updated changelog to reflect iteration

* added literal radio tech to connection.subtype table

* added  as option for connect.type

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
2021-07-12 09:32:33 -07:00
Christian Neumüller 25f029b2e2 Rework FaaS semantic conventions. (#1781) 2021-07-06 14:34:09 +02:00
Christian Neumüller ecec5145dc Remove examples from enums. (#1779) 2021-06-29 12:54:59 -07:00
Armin Ruech d56add2b1b Bump semconvgen to 0.4.1 (#1771) 2021-06-22 18:00:48 +02:00
Christian Neumüller 795e4ec00f Remove rpc.jsonrpc.method, clarify rpc.method instead. (#1748)
* Remove rpc.jsonrpc.method, clarify rpc.method instead.

* Add PR#.

* Clarify client side code.namespace/function.

* Use "ref" instead of "constraint: any_of".

This should be changed back once
https://github.com/open-telemetry/build-tools/issues/33
is resolved & the updated build tools available.

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2021-06-14 16:59:09 -07:00
Rob Crowe c8201c16aa Add cockroachdb to db.system semantic conventions (#1725) 2021-05-28 16:26:21 +02:00
Eric Mustin e9035a0368 Add memcached to db.system semantic conventions (#1689)
* Add memcached to db.system semantic conventions

As we already use `memcached` to represent the `db.system` Memcached in opentelemetry-python, I believe we should add to the specification recommendation e606542981/instrumentation/opentelemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py (L160)
2021-05-17 16:51:06 +02:00
Rostislav Kirillov d10c8523b2 added JSON RPC specific attributes (#1643) 2021-05-07 18:13:43 +02:00
Robert Pająk 786bc86d2b Add possibility to disable `db.statement` (#1659) 2021-05-03 23:21:57 +02:00
Amir Blum f15465b5ba add rabbitmq to semantic conventions yaml (#1651)
* add rabbitmq to semantic conventions yaml

* add example for rabbitmq routing key

* messaging.rabbitmq - use required syntax

* messaging.rabbitmq generate markdown table from yaml

* update changelog with adding rabbitmq to yaml

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2021-04-27 08:36:28 -07:00
Anuraag Agrawal 6c1ab84bb2 Add details for filling resource for AWS Lambda. (#1610) 2021-04-15 19:00:34 +02:00
Jaana Dogan bc85b047c2 Have consistent formatting for semantic convention enums (#1598)
* Have consistent formatting for semantic convention enums

Currently, semantic convention enum values are not consistent.
For example, os.type values are all capitals whereas
cloud.infrastructure_service values are underscored lowercase.
This change improves the inconsistencies.

We also expect language implementations to autogenerate code
from enum values. Each language has their own conventions for
constant variable identifiers and we expect the consistent
formatting is going to help the language implementors.

Fixes #1519.
2021-04-15 17:43:00 +02:00
James Sherlock a1c1110c37 [semantic conventions] trivial: Amend Azure FaaS Description (#1595)
* Fix Azure Member Brief

Azure currently has an incorrect description associated with it. This fixes it 😄

* Update faas.md

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2021-04-05 15:21:59 -07:00
Anuraag Agrawal c94d2d1498 AWS SDK common and dynamodb conventions (#1422)
Co-authored-by: William Armiros <54150514+willarmiros@users.noreply.github.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2021-03-30 18:53:48 +02:00
Anuraag Agrawal 0f98135322 Add semantic conventions for instrumenting AWS Lambda. (#1442) 2021-03-24 22:28:16 +01:00
Armin Ruech f2db090205 Update to latest semconv table generator to fix int enum issue (#1564) 2021-03-22 13:51:59 +01:00
Armin Ruech 561ad88d7f Update semantic conventions to distinguish int from double (#1550) 2021-03-18 17:06:10 +01:00
Robert Pająk c3d71dffc8 http.url MUST NOT contain credentials (#1502) 2021-03-05 15:20:04 +01:00
Yaniv Davidi b5f94d5fe7 Add elasticsearch to db.system semantic conventions (#1463) 2021-02-25 23:47:00 +01:00
Yuri Shkuro 55c4909ebb Fix capitalization of MUST NOT/SHOULD NOT (#1404)
* Fix capitalization of MUST NOT/SHOULD NOT

* remove redudndant clause
2021-02-05 15:30:06 -08:00
Ted Young eeff36dfd4 Add lifecycle statuses to all documents (#1385) 2021-02-04 15:06:46 +01:00