Commit Graph

7 Commits

Author SHA1 Message Date
Tigran Najaryan a59a1b218c Require that names and namespaces are one global space across all semantic convention areas (#832)
* Require that names and namespaces are one global space across all semantic convention areas

We have semantic conventions for Resources, Spans and Metrics (in the future also Logs are expected).
It was not clear if the attribute names across all convention areas should be globally unique.

This commit asserts that conventions are one space, they are not independent spaces with
their own namespaces each.

We prohibit using the same Span or Resource attribute name or metric label name but give them
slightly different meanings or value sets.

Resolves: https://github.com/open-telemetry/opentelemetry-specification/issues/815

* Address PR comments

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2023-11-16 12:50:59 -05:00
Bogdan Drutu 52061e2f52 Fix lint check in makefile, fix errors (#837)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2023-11-16 12:50:59 -05:00
Tigran Najaryan 2096cb3ec5 Extend attribute naming rules to metric labels (#821)
* Extend attribute naming rules to metric labels

We earlier defined naming rules for attributes, however we do not have
similar rules for metric labels. This commit extends the exact same
set of rules to metric labels.

This was brought up in this comment https://github.com/open-telemetry/opentelemetry-specification/pull/807#discussion_r471550053

* Address PR comments
2023-11-16 12:50:59 -05:00
Tigran Najaryan 795086a9a5 Add conventions for attribute names (#807)
* Add conventions for attribute names

Resolves: https://github.com/open-telemetry/opentelemetry-specification/issues/726

* Address PR comments

* Re-word company/application specific attribute recommendations
2023-11-16 12:50:59 -05:00
Giovanni Liva 19fced8d4f Consistency between Span and Resource attributes (#777)
* Consistency between Span and Resource attributes

* Address feedback

* Wording
2023-11-16 12:50:59 -05:00
Reiley Yang c82cc039d7 DocFX sanity check (#742) 2023-11-16 12:50:59 -05:00
Bogdan Drutu 56071a8642 Centralize attributes definition (#722)
* Centralize attributes definition

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/overview.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2023-11-16 12:50:59 -05:00