Commit Graph

1777 Commits

Author SHA1 Message Date
Anuraag Agrawal 355a7f5740 Use MUST consistently instead of SHALL (#1208)
* Use MUST consistently instead of shall.

* Update specification/trace/semantic_conventions/messaging.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-11-08 15:48:53 -05:00
Yusuke Tsutsumi ce1a267d21 Updating gRPC status semantic conventions (#1156)
* Updating gRPC status semantic conventions

Since the simplification of trace status codes,
they no longer align with gRPC.

Clarifying the expected status code field for gRPC, as
well as the mappings between gRPC and OpenTelemetry status.

* Adding changelog entry

* Addressing feedback

Clarifying that gRPC spans should include the status code number,
rather than leave it ambiguous.

Adding gRPC semantic conventions in the yaml files to reflect these
changes.

* adding trailing whitespace

* Apply suggestions from code review

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* addressing feedback

Ran table-generation to ensure that semantic conventions are added.

Removed tags for rpc.grpc yaml for now (not explicitly used).

* Update specification/trace/semantic_conventions/rpc.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Addressing feedback

re-generating TOC with markdown-toc

There was a conflict with sub-headings matching the same string. As such
qualified all headings.

* Switching gRPC status_code type to enum

gRPC's status_code code is better expressed as an enum.

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-11-06 15:06:46 -08:00
Christian Neumüller bf1d9c6471 Rework headings of process semantic convention, add TOC. (#1191) 2020-11-04 12:34:42 -08:00
Christian Neumüller aa14918823 Fix absolute links to spec (#1192)
* Remove absolute links where possible.

* Work around semantic conventions.

* Docfx.

* Fix YAML.

* More docfx.
2020-11-04 12:29:48 -08:00
Christian Neumüller 9ec26f31ed Overhaul process command-line resource conventions. (#1137)
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-11-03 11:50:38 +01:00
Yuri Shkuro f06e3a22e2 Replace CAN with MAY (#1150) 2020-10-28 12:51:19 -04:00
Carlos Alberto Cortez e5de3ac8c1 Revert "Rename SpanContext to SpanReference. (#1075)" (#1127) 2020-10-24 00:16:31 +02:00
Ken Finnigan 8b6a13ad16 Resolve semantic inconsistencies for non traditional messaging (#1027)
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-10-21 15:28:20 +02:00
Giovanni Liva 98d2cc53f8 Add yaml for FaaS trace attributes (#1054)
Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-10-19 18:36:54 +02:00
Aaron Abbott 3146dc01dc System metrics semantic conventions (#937)
* System metrics semantic conventions

Conventions from [OTEP
119](https://github.com/open-telemetry/oteps/pull/119)

* change process count to UpDownSumObserver

* fix system.cpu.utilization, use better example

* first several comments

* add description columns, update units to UCUM

* markdown-toc

* clarify OS process level metrics

* clarify load average exapmle

* move general conventions + OTEP 108 into README.md

* renamed swap -> paging

* add addition fs labels

* fix links

* fix link

* Update specification/metrics/semantic_conventions/README.md

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>

* Update specification/metrics/semantic_conventions/README.md

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>

* fix tigran comments

* add disk io_time and operation_time

* add descriptions/footnotes for dropped packets and net errors

* lint, more info for net dropped packets/errors

* "dropped_packets" -> "dropped"

* Apply suggestions from James' code review

Co-authored-by: James Bebbington <jbebbington@google.com>

* comments from James' code review

* clarify windows perf counter

* Update specification/metrics/semantic_conventions/README.md

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>

* reflow text

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: James Bebbington <jbebbington@google.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
2020-10-15 12:07:07 -07:00
Josh Suereth b48cb0cff0 Fix typo in cloud resource convention. (#1097)
* Fix type in cloud convention.

* Run auto-md tool, cool!
2020-10-15 09:53:56 -07:00
Carlos Alberto Cortez 06db49aae3 Rename SpanContext to SpanReference. (#1075)
* Rename SpanContext to SpanReference.

* More updates.

* Update CHANGELOG

* Update specification/metrics/api.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/metrics/api.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/metrics/api.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/metrics/api.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/overview.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/overview.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/metrics/api.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Add entry to the compliance matrix.

* Update specification/overview.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-10-14 08:40:18 -07:00
Giovanni Liva d07e2e8431 Add yaml for FaaS and Host resource attributes (#1056)
* Add yaml for FaaS and Host resource attributes

* Address feedback

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-10-12 17:02:45 +02:00
Giovanni Liva f474696cfd Add yaml for K8s and OS resource attributes (#1057) 2020-10-09 16:04:18 +02:00
Giovanni Liva 31ec13ca2d Add yaml for Cloud, Container, and Deployment resource attributes (#1055) 2020-10-09 16:02:07 +02:00
Bogdan Drutu 138b4e4d88 Change Status to be consistent with Link and Event (#1067)
* Change Status to be consistent with Link and Event

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Add changelog entry

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Fix link to status

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/trace/api.md

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

* Update specification/trace/api.md

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>

* Fix markdown errors

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/trace/api.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-10-07 11:21:31 -07:00
Giovanni Liva 9315f21f9d Add telemetry and service yaml (#1026) 2020-09-30 17:16:04 -07:00
Michael Lavers 596552eb0b Fix HTTP Metric Semantics Typos (#1039) 2020-09-30 17:19:50 +02:00
Giovanni Liva 9f09d2db7e Add yaml semantic conventions for Messaging (#926) 2020-09-29 14:34:02 +02:00
Jay Camp b971d97b32 Explicitly specify cloud.provider values for common cloud providers (#1018)
* Explicitly specify cloud.provider values for common cloud providers

Before some cloud provider values were given as an examples but it was still
left open to interpretation about what that meant. This makes it more explicit
that these are known values for those particular cloud providers.

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-09-29 14:12:05 +02:00
Ted Young bbd284a9d9 Error Flagging with Status Codes (#966)
* StatusSource definition

* Update HTTP status code mapping

* Remove span status

* Apply feedback.

* Remove unused link.

* markdownlint

* spelling

Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
2020-09-24 11:24:31 -07:00
Giovanni Liva 5874138953 Add yaml semantic conventions for RPC (#925) 2020-09-24 15:06:48 +02:00
Justin Foote a319ffaf62 Add README describing use of semantic convention YAML models (#980) 2020-09-23 16:08:31 +02:00
Anuraag Agrawal cb368a7a64 Add process.runtime.name / version describing executing runtime (#882)
* Add process.runtime.name / version to capture information about executing runtime.

* .NET core probably considered reference implementation going forward.

* Changelog

* Cleanups

* Fix go compiler

* Compiler

* Update specification/resource/semantic_conventions/process.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Java not constants

* Space

* Ecilpse:

* Add TODOs

* Avoid direct links

* Revert "Avoid direct links"

This reverts commit 7906c266570d993eaef28357d3cd25065be4d658.

* Try direct link

* Update Ruby

* Update specification/resource/semantic_conventions/process.md

Co-authored-by: Tristan Sloughter <t@crashfast.com>

* Consistency

* lint

* Android

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Tristan Sloughter <t@crashfast.com>
2020-09-22 11:25:07 -07:00
Armin Ruech f6cd4c2e1a Remove obsolete `http.status_text` from semantic conventions (#972) 2020-09-22 11:49:09 +02:00
Christian Neumüller 0ce8f09464 Exception semantic conventions: Add example & more explanation for exception.escaped. (#946)
* Add example & explanation for exception.escaped.

* Reshuffle paragraphs.

* Remove potentially controversial changes.

* Fill in CHANGELOG link.

* Address review comments.

* Wording

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>

* Use actual OTel-Java API.

* Revert "Use actual OTel-Java API."

This reverts commit d359f477017d4ec0f71191eabae6b1edecee79fb.

* Clarify CHANGELOG

* Re-generate tables.

* Typo in CHANGELOG.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Clarify exception escaped description.

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-09-19 08:24:46 -04:00
Tigran Najaryan 22acfb9aa6 Fix reference to service.instance.id (#957)
Was previously incorrectly referenced as service.id.
2020-09-16 16:01:56 +02:00
Armin Ruech 044aef6378 Add semantic convention for source code attributes (#901) 2020-09-15 17:33:58 +02:00
Giovanni Liva 5f0ed87925 Add yaml semantic conventions for Exception (#927) 2020-09-15 15:30:38 +02:00
Giovanni Liva a50ad7376b Add yaml semantic conventions for Database (#928)
* Add yaml semantic conventions for Database

* Address feedback
2020-09-11 09:15:46 -07:00
Carlos Alberto Cortez 91e93292b8 Use Deployment Environment in Resources' README instead of Environment. (#851) 2020-09-08 20:09:48 +02:00
Christian Neumüller 0da3c1a599 Add exception.escaped attribute. (#784)
* Add exception.escaped attribute.

This reverts commit 80ea27df4dd858b686d91ef37dad89aa8cd89439.

* New wording for API change.

* Remove additional condition for escaped parameter.

* Remove exception.escaped from the API.

* Add CHANGELOG entry.

* Wrong PR# in CHANGELOG.

* Wrong wrong PR# in CHANGELOG (hey anagrams!).

* Closing )

* Typos

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-09-08 07:44:34 -07:00
Gene Liverman 7f54e65cf7 Fix the rendering of the table (#921)
* Fix table display

* Update specification/trace/semantic_conventions/span-general.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-09-04 11:21:30 -07:00
Tigran Najaryan 6d12dec4d9 Delete sentence about using span name when faas.name is absent (#915)
As pointed out here https://github.com/open-telemetry/opentelemetry-specification/pull/888#discussion_r478866767
if faas.name is not set, the Instrumentation probably doesn't know the name
and thus the span name would most likely also not contain it.

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-09-03 13:13:50 -07:00
Armin Ruech 3c241627c3 Fix Ruby link reference in exceptions.md (#917) 2020-09-02 20:37:52 +02:00
Armin Ruech f6f5ce62ef Add semantic conventions for outgoing FaaS invocations (#862) 2020-09-02 17:18:46 +02:00
gfuller1 c2a9e386a4 Add semantic conventions for HTTP metrics (#739)
* add http metric label spec

* typo

* update attribute locations and clarify which to inlcude, alter and exclude

* add metric instruments list

* simplify intro sections, add requirement columns, clarify labels, fix normative directives and more

* fix HTTP strings

* add count metric instrument and shorten duration metric name

* remove dependency on http.md, add more notes and examples and general cleanup

* replace span.kind with type

* add missing labels and cleanup links

* substitution->alternatives and remove section not needed

* make request count metric instrument plural

* formatting

* clarify type column

* update intro and fix units

* breakout metric instrument table

* remove http.route since it is the same as http.target after http.target is simplified

* update net labels to link to definition

* add lowercase requirement to http.scheme

* formatting

Co-authored-by: gfuller <gfuller@newrelic.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-08-30 08:43:14 -07:00
Tigran Najaryan a5f6991ebe Clarify function name conventions (#888) 2020-08-28 01:28:30 +02:00
Giovanni Liva 521dfd99aa YAML Model for Semantic Conventions (#571)
* First model draft

* Fix checkstyle

* Generate network table from YAML

* HTTP semantic convention tables

* Fix requirements order

* Add code and basic documentation

* Missing \n

* Remove tool

* Add General and HTTP semantic convention

* Update table style

* yaml->semantic_conventions

* Fix small errors

* Fix docfx errors

* Update Makefile to use otel Docker repo

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-08-27 13:18:51 -07:00
Bogdan Drutu be35f68e5a Rename CorrelationContext to Baggage (#857)
* Rename CorrelationContext to Baggage

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-08-25 23:15:07 -07:00
Anuraag Agrawal 9b449af77e Remove version convention / semver prefix from versions. (#873)
* Remove version convention / semver prefix from versions.

* Moar

* api.md

* Examples of version strings.

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* spaec

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-08-25 18:49:52 -07:00
Emmanuel Courreges a69a84b879 Add "Deployment / environment" subsection in "Environment" (#606)
Merge "Deployment Service / Kubernetes" section into "Environment" section for consistency
Create deployment_environment.md for new deployment.environment attribute

Signed-off-by: CI-Bot for Emmanuel Courreges <emmanuel.courreges@orange.com>
2020-08-21 16:01:15 +02:00
Bogdan Drutu ad8e02ae9a Remove duplicate hostname attribute (#838) 2020-08-20 21:11:40 +02:00
Bogdan Drutu 11997ecad6 Fix lint check in makefile, fix errors (#837)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-08-19 14:43:05 -07:00
Mateusz Rzeszutek 6e96f1bbee Add semantic conventions for thread.name and thread.id span attributes (#789) 2020-08-18 17:55:42 +02:00
Nikita Salnikov-Tarnovski 36eb583e87 Add semantic convention for telemetry.auto.version (#799) 2020-08-17 09:41:58 -07:00
Anuraag Agrawal 3bb80b2ad1 Add link to exceptions from folder README (#795) 2020-08-13 07:33:39 -07:00
Christian Neumüller 1d03f8f5ec Fix exception.stacktrace recommendation for Ruby. (#765)
* Fix exception.stacktrace recommendation for Ruby.

All other stacktraces use the full message (including type, message,
etc), for Ruby only the plain stacktrace.

* Don't downgrade Ruby version.
2020-08-12 18:40:26 -07:00
Akash Suresh a6f219b6bb k8s: Differentiate container spec name and container name (#762) 2020-08-07 17:57:46 +02:00
Reiley Yang be2fe2e3cf Clarify how to make progress on a PR (#745) 2020-08-06 16:19:18 +02:00