Commit Graph

954 Commits

Author SHA1 Message Date
Anuraag Agrawal cb368a7a64 Add process.runtime.name / version describing executing runtime (#882)
* Add process.runtime.name / version to capture information about executing runtime.

* .NET core probably considered reference implementation going forward.

* Changelog

* Cleanups

* Fix go compiler

* Compiler

* Update specification/resource/semantic_conventions/process.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Java not constants

* Space

* Ecilpse:

* Add TODOs

* Avoid direct links

* Revert "Avoid direct links"

This reverts commit 7906c266570d993eaef28357d3cd25065be4d658.

* Try direct link

* Update Ruby

* Update specification/resource/semantic_conventions/process.md

Co-authored-by: Tristan Sloughter <t@crashfast.com>

* Consistency

* lint

* Android

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Tristan Sloughter <t@crashfast.com>
2020-09-22 11:25:07 -07:00
Armin Ruech f6cd4c2e1a Remove obsolete `http.status_text` from semantic conventions (#972) 2020-09-22 11:49:09 +02:00
Christian Neumüller 0ce8f09464 Exception semantic conventions: Add example & more explanation for exception.escaped. (#946)
* Add example & explanation for exception.escaped.

* Reshuffle paragraphs.

* Remove potentially controversial changes.

* Fill in CHANGELOG link.

* Address review comments.

* Wording

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>

* Use actual OTel-Java API.

* Revert "Use actual OTel-Java API."

This reverts commit d359f477017d4ec0f71191eabae6b1edecee79fb.

* Clarify CHANGELOG

* Re-generate tables.

* Typo in CHANGELOG.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Clarify exception escaped description.

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-09-19 08:24:46 -04:00
Tigran Najaryan 22acfb9aa6 Fix reference to service.instance.id (#957)
Was previously incorrectly referenced as service.id.
2020-09-16 16:01:56 +02:00
Armin Ruech 044aef6378 Add semantic convention for source code attributes (#901) 2020-09-15 17:33:58 +02:00
Giovanni Liva 5f0ed87925 Add yaml semantic conventions for Exception (#927) 2020-09-15 15:30:38 +02:00
Giovanni Liva a50ad7376b Add yaml semantic conventions for Database (#928)
* Add yaml semantic conventions for Database

* Address feedback
2020-09-11 09:15:46 -07:00
Carlos Alberto Cortez 91e93292b8 Use Deployment Environment in Resources' README instead of Environment. (#851) 2020-09-08 20:09:48 +02:00
Christian Neumüller 0da3c1a599 Add exception.escaped attribute. (#784)
* Add exception.escaped attribute.

This reverts commit 80ea27df4dd858b686d91ef37dad89aa8cd89439.

* New wording for API change.

* Remove additional condition for escaped parameter.

* Remove exception.escaped from the API.

* Add CHANGELOG entry.

* Wrong PR# in CHANGELOG.

* Wrong wrong PR# in CHANGELOG (hey anagrams!).

* Closing )

* Typos

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-09-08 07:44:34 -07:00
Gene Liverman 7f54e65cf7 Fix the rendering of the table (#921)
* Fix table display

* Update specification/trace/semantic_conventions/span-general.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-09-04 11:21:30 -07:00
Tigran Najaryan 6d12dec4d9 Delete sentence about using span name when faas.name is absent (#915)
As pointed out here https://github.com/open-telemetry/opentelemetry-specification/pull/888#discussion_r478866767
if faas.name is not set, the Instrumentation probably doesn't know the name
and thus the span name would most likely also not contain it.

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-09-03 13:13:50 -07:00
Armin Ruech 3c241627c3 Fix Ruby link reference in exceptions.md (#917) 2020-09-02 20:37:52 +02:00
Armin Ruech f6f5ce62ef Add semantic conventions for outgoing FaaS invocations (#862) 2020-09-02 17:18:46 +02:00
gfuller1 c2a9e386a4 Add semantic conventions for HTTP metrics (#739)
* add http metric label spec

* typo

* update attribute locations and clarify which to inlcude, alter and exclude

* add metric instruments list

* simplify intro sections, add requirement columns, clarify labels, fix normative directives and more

* fix HTTP strings

* add count metric instrument and shorten duration metric name

* remove dependency on http.md, add more notes and examples and general cleanup

* replace span.kind with type

* add missing labels and cleanup links

* substitution->alternatives and remove section not needed

* make request count metric instrument plural

* formatting

* clarify type column

* update intro and fix units

* breakout metric instrument table

* remove http.route since it is the same as http.target after http.target is simplified

* update net labels to link to definition

* add lowercase requirement to http.scheme

* formatting

Co-authored-by: gfuller <gfuller@newrelic.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-08-30 08:43:14 -07:00
Tigran Najaryan a5f6991ebe Clarify function name conventions (#888) 2020-08-28 01:28:30 +02:00
Giovanni Liva 521dfd99aa YAML Model for Semantic Conventions (#571)
* First model draft

* Fix checkstyle

* Generate network table from YAML

* HTTP semantic convention tables

* Fix requirements order

* Add code and basic documentation

* Missing \n

* Remove tool

* Add General and HTTP semantic convention

* Update table style

* yaml->semantic_conventions

* Fix small errors

* Fix docfx errors

* Update Makefile to use otel Docker repo

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-08-27 13:18:51 -07:00
Bogdan Drutu be35f68e5a Rename CorrelationContext to Baggage (#857)
* Rename CorrelationContext to Baggage

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-08-25 23:15:07 -07:00
Anuraag Agrawal 9b449af77e Remove version convention / semver prefix from versions. (#873)
* Remove version convention / semver prefix from versions.

* Moar

* api.md

* Examples of version strings.

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* spaec

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-08-25 18:49:52 -07:00
Emmanuel Courreges a69a84b879 Add "Deployment / environment" subsection in "Environment" (#606)
Merge "Deployment Service / Kubernetes" section into "Environment" section for consistency
Create deployment_environment.md for new deployment.environment attribute

Signed-off-by: CI-Bot for Emmanuel Courreges <emmanuel.courreges@orange.com>
2020-08-21 16:01:15 +02:00
Bogdan Drutu ad8e02ae9a Remove duplicate hostname attribute (#838) 2020-08-20 21:11:40 +02:00
Bogdan Drutu 11997ecad6 Fix lint check in makefile, fix errors (#837)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-08-19 14:43:05 -07:00
Mateusz Rzeszutek 6e96f1bbee Add semantic conventions for thread.name and thread.id span attributes (#789) 2020-08-18 17:55:42 +02:00
Nikita Salnikov-Tarnovski 36eb583e87 Add semantic convention for telemetry.auto.version (#799) 2020-08-17 09:41:58 -07:00
Anuraag Agrawal 3bb80b2ad1 Add link to exceptions from folder README (#795) 2020-08-13 07:33:39 -07:00
Christian Neumüller 1d03f8f5ec Fix exception.stacktrace recommendation for Ruby. (#765)
* Fix exception.stacktrace recommendation for Ruby.

All other stacktraces use the full message (including type, message,
etc), for Ruby only the plain stacktrace.

* Don't downgrade Ruby version.
2020-08-12 18:40:26 -07:00
Akash Suresh a6f219b6bb k8s: Differentiate container spec name and container name (#762) 2020-08-07 17:57:46 +02:00
Reiley Yang be2fe2e3cf Clarify how to make progress on a PR (#745) 2020-08-06 16:19:18 +02:00
Reiley Yang 3c720edee4 DocFX sanity check (#742) 2020-07-27 19:51:44 +02:00
Bogdan Drutu 7bc2b83d58 Add semantic conventions for all Kubernetes objects (#732)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-07-25 13:49:59 -07:00
Bogdan Drutu 41869b89aa Split resource semantic conventions in smaller files (#727)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-07-23 09:49:11 -04:00
Matthew Wear 18c42b60ca Exception reporting specification (#697)
* Add semantic conventions for errors

* Update error.type description

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* update semantic conventions for exceptions

* add details for attributes; remove log.severity; add API details

* rename exceptions.md -> exception-reporting.md

* more accurately describe format for java

* alphabetize languages in stacktrace representation table

* prefer dynamic type over static type

* add log.severity convention

* Revert "add log.severity convention"

This reverts commit 137556e44bf74e6d76a17bd81943702a460cb9de.

* rename stacktrace -> exception.stacktrace

* move file to semantic conventions directory

* move RecordException to API

* fix formatting

Co-authored-by: Armin Ruech <armin.ruech@gmail.com>
2020-07-17 12:52:48 -04:00
Armin Ruech c724898be9 Adapt semantic conventions for the span name of messaging systems (#690)
* Adapt messaging semantic conventions to include the operation in the span name

* Specify that the operation name must match the respective attribute if the suggested span name format is used

* Update span names in examples

* Consolidate definition of operation names into a separate section

* Consolidate capitalization

* Reference Conversation ID definition

* Consolidate MD syntax

* Organize definitions

* Organize definitions

* Reference definitions

* Allow artificial destinations as span name if neither destination name nor conversation ID are suitable

* Do not use conversation IDs for span name

* Wording

Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com>

* Fix typo

* Add more links and guidance on messaging.operation

* Fix changelog

Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com>
2020-07-15 13:14:56 -07:00
Armin Ruech f89b9c568c Add resource semantic conventions for operating systems (#693) 2020-07-15 16:22:13 +02:00
Anuraag Agrawal 72cb7df3e3 Add mapping for nginx 499 http status (#677) 2020-07-10 17:56:07 +02:00
Tyler Yahn 99707b5a5c Update resource `process.*` descriptions (#695)
Not all Unix based OSs have `procfs` (Darwin) or have it enabled by
default (FreeBSD). Update the description to be specific to Linux
systems.
2020-07-09 23:15:10 -07:00
Armin Ruech ad04016439 Fix Redis sample (db.redis.database_index was missing) (#692) 2020-07-09 19:26:56 +02:00
Armin Ruech c45e0c33a7 Revise and extend semantic conventions for databases (#575) 2020-07-01 19:29:01 +02:00
Armin Ruech 34b9300fbb Exclude github.com from markdown-link-check (#675) 2020-07-01 03:24:22 +02:00
Anuraag Agrawal 2c07f78112 Add peer.service semantic convention to indicate the name of a target… (#652)
* Add peer.service semantic convention to indicate the name of a target remote service.

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Simplify

* Remove fallback wording

* Needs to be configured using instrumentation

* CHANGELOG

* Clarify relationship with rpc.service and peer.service and some examples

* Clarify example

* Move peer.service / rpc.service relationship explanation to rpc doc.

* Apply suggestions from code review

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/trace/semantic_conventions/span-general.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Cleanup

* Tweak

* Update specification/trace/semantic_conventions/rpc.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update CHANGELOG.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update specification/trace/semantic_conventions/span-general.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* TOC

* Apply suggestions from code review

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-06-30 09:32:23 -07:00
Lei Wang 2296634e18 Add semantic conventions for container id (#673)
* Add semantic conventions for container id

* Update specification/resource/semantic_conventions/README.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update specification/resource/semantic_conventions/README.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2020-06-30 08:25:40 -07:00
James Bebbington cdbda6cddb Added semantic conventions for the "process" resource (#635) 2020-06-29 18:00:03 -07:00
Anuraag Agrawal 9a1b74f9c1 Add semantic conventions for http content size (#641)
* Add semantic conventions for http content size

* Suffix not midfix
2020-06-25 18:02:02 -04:00
Armin Ruech 4c3d548b9b Fix CODEOWNERS syntax (#670) 2020-06-24 15:58:48 +02:00
Bogdan Drutu ce81cfa2d5 Update codeowners to support area owners (#661)
* Update codeowners to support area owners

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update CODEOWNERS

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-06-22 10:22:14 -07:00
Armin Ruech ed21f09e46 Extend semantic conventions for RPC and allow non-gRPC calls (#604)
* Generalize RPC semantic conventions to allow non-gRPC spans

* Add method name to attributes

* Require specifying `net.transport` for non-IP connections

* Do not require providing the port when it's not available

* Add package name to rpc.service and make it optional when not applicable or unknown

* Add note and example distinguishing the service.name resource attribute from rpc.service

* Distinguish RPC spans from HTTP spans

* Improve wording

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Improve wording

* Improve wording even more

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Clarify span name format

* Update changelog

* rpc.method: required -> recommended

* rpc.service: required -> recommended

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2020-06-17 10:58:26 -07:00
Armin Ruech 4ba638ad0d Add span attribute to indicate cold starts of Function as a Service executions (#650)
* Add `faas.coldstart` attribute

* Update changelog
2020-06-15 11:15:02 -07:00
Joshua MacDonald 7c078b1ad7 Makefile fixes (#615)
* Makefile fixes

* Use a for-loop

* Fix markdownlint too
2020-05-20 09:31:16 -07:00
Armin Ruech 79707b7df9 Link from trace (and metric) semantic conventions to resources (#603) 2020-05-14 10:11:11 -07:00
Armin Ruech 960eb9992b [build] Improve markdown-link-check output (#602)
* Improve markdown-link-check output

* Introduce errors to check if the build works

* Revert "Introduce errors to check if the build works"

This reverts commit b31f46f8f8ea22f0fdddfabf5233b32d34114520.

* Merge markdown-link-check and enforce-markdown-link-check

* Make Makefile more readable
2020-05-13 15:19:10 -07:00
Armin Ruech 709940084a Fix HTTP span example (#576)
`host.port` was renamed to `net.host.port` in #349
2020-04-28 15:29:29 +02:00