Commit Graph

868 Commits

Author SHA1 Message Date
Jakub Malinowski 2ecdb1f1a2 Add an option to limit length of values of attributes and metric values (#1130) 2023-11-16 12:50:59 -05:00
Jakub Malinowski dcf74c311a Rename Metrics labels to attributes (#1775) 2023-11-16 12:50:59 -05:00
Tigran Najaryan 71df386e08 Clarify usage of "otel." attribute namespace (#1640)
I noticed developers adding their own attributes to this namespace
without going through the specification. We need to regulate this
namespace through the specification, just like we do it for other
semantic conventions.
2023-11-16 12:50:59 -05:00
Ted Young 7a3f37d933 Add lifecycle statuses to all documents (#1385) 2023-11-16 12:50:59 -05:00
Tigran Najaryan e8587bacc8 Declare freeze of Trace API Specification 1.0 (#1121)
* Declare freeze of Trace Specification 1.0

We want to freeze Trace specification 1.0 so that we no longer accept substantial changes (unless a fundamental problem is found in the spec).

Resolves https://github.com/open-telemetry/opentelemetry-specification/issues/1120
2023-11-16 12:50:59 -05:00
Christian Neumüller 1cbb4af73d Nulls SHOULD NOT be allowed in arrays. (#1214)
* Nulls SHOULD NOT be allowed in arrays.

* Fill in CHANGELOG link

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
2023-11-16 12:50:59 -05:00
Tigran Najaryan fb0804ed30 Add guidance on when to use and not use nested namespaces (#1197)
This topic has come up at least 3 times now. I believe a clarification is
warranted. The clarification is aligned with previous recommendations:
https://github.com/open-telemetry/opentelemetry-specification/pull/789#issuecomment-675506855
https://github.com/open-telemetry/opentelemetry-specification/pull/882#issuecomment-690945900
https://github.com/open-telemetry/opentelemetry-specification/pull/1194#issuecomment-722431982
2023-11-16 12:50:59 -05:00
Przemek Maciolek 01e5a6d827 Include attribute name pluralization guidelines (#1115) (#1140) 2023-11-16 12:50:59 -05:00
Christian Neumüller 550a2b904b Remove ordering reqirement for attributes. (#1212)
* Remove ordering for attributes.

* Fill in CHANGELOG link
2023-11-16 12:50:59 -05:00
Christian Neumüller 2d55f5436f Fix absolute links to spec (#1192)
* Remove absolute links where possible.

* Work around semantic conventions.

* Docfx.

* Fix YAML.

* More docfx.
2023-11-16 12:50:59 -05:00
Armin Ruech aa5effe43c Define `null` as an invalid value for attributes and declare attempts to set `null` as undefined behavior (#992) 2023-11-16 12:50:59 -05:00
Tigran Najaryan a59a1b218c Require that names and namespaces are one global space across all semantic convention areas (#832)
* Require that names and namespaces are one global space across all semantic convention areas

We have semantic conventions for Resources, Spans and Metrics (in the future also Logs are expected).
It was not clear if the attribute names across all convention areas should be globally unique.

This commit asserts that conventions are one space, they are not independent spaces with
their own namespaces each.

We prohibit using the same Span or Resource attribute name or metric label name but give them
slightly different meanings or value sets.

Resolves: https://github.com/open-telemetry/opentelemetry-specification/issues/815

* Address PR comments

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2023-11-16 12:50:59 -05:00
Bogdan Drutu 52061e2f52 Fix lint check in makefile, fix errors (#837)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2023-11-16 12:50:59 -05:00
Tigran Najaryan 2096cb3ec5 Extend attribute naming rules to metric labels (#821)
* Extend attribute naming rules to metric labels

We earlier defined naming rules for attributes, however we do not have
similar rules for metric labels. This commit extends the exact same
set of rules to metric labels.

This was brought up in this comment https://github.com/open-telemetry/opentelemetry-specification/pull/807#discussion_r471550053

* Address PR comments
2023-11-16 12:50:59 -05:00
Tigran Najaryan 795086a9a5 Add conventions for attribute names (#807)
* Add conventions for attribute names

Resolves: https://github.com/open-telemetry/opentelemetry-specification/issues/726

* Address PR comments

* Re-word company/application specific attribute recommendations
2023-11-16 12:50:59 -05:00
Giovanni Liva 19fced8d4f Consistency between Span and Resource attributes (#777)
* Consistency between Span and Resource attributes

* Address feedback

* Wording
2023-11-16 12:50:59 -05:00
Reiley Yang c82cc039d7 DocFX sanity check (#742) 2023-11-16 12:50:59 -05:00
Bogdan Drutu 56071a8642 Centralize attributes definition (#722)
* Centralize attributes definition

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/common/common.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

* Update specification/overview.md

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>

Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
2023-11-16 12:50:59 -05:00
Alexander Wert 2817a7fa5b
Temp fix for separation of resource and semantic attributes (#524)
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Co-authored-by: Josh Suereth <joshuasuereth@google.com>
2023-11-16 11:53:14 -05:00
Alexander Wert 971383f4a5
Changed `messaging.system` attribute type to an open enum (#517)
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
2023-11-16 13:41:39 +01:00
Alexander Wert a4c60f7464
Updated CODEOWNERS for http-approvers (#516)
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
2023-11-15 13:30:29 +01:00
Chris Mark 711776a059
Move k8s atrributes to the registry (#506)
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
2023-11-15 09:23:46 +01:00
Chris Mark d30d7fc021
Fix process registry (#515)
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
2023-11-14 13:39:49 +01:00
Chris Mark 4f89cd7848
[.github/CODEOWNERS] Add semconv container/k8s approvers (#510)
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
2023-11-14 12:26:14 +01:00
Anna Levenberg 30ea09f5c4
docs(messaging): add gcp_pubsub as a messaging system (#490)
Co-authored-by: Johannes Tax <johannes@johannes.tax>
Co-authored-by: Joao Grassi <joao@joaograssi.com>
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
2023-11-13 17:53:26 +01:00
Alexandra Konrad d9c24b436e
move OS to registry (#501)
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
2023-11-13 16:43:28 +01:00
Trask Stalnaker 68457cbe7a
Fix typo (#507)
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
2023-11-13 16:21:01 +01:00
Alexandra Konrad 200d20f899
Move host to the registry (#498)
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
2023-11-13 16:16:37 +01:00
Severin Neumann 659f03c71e
Add Semantic conventions for TLS/SSL encrypted communication (#21)
Signed-off-by: svrnm <neumanns@cisco.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
2023-11-13 15:29:04 +01:00
Pablo Baeyens f6fec98892
[model/resource] Change `host.cpu.model.family` and `host.cpu.model.id` to be strings (#499)
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
2023-11-13 12:23:30 +01:00
Trask Stalnaker 55a6575a8f
Update `jvm.gc.duration` histogram buckets to `[ 0.01, 0.1, 1, 10 ]` (#317) 2023-11-13 08:47:44 +01:00
Trask Stalnaker cfdcc9ee82
Add `http.flavor` and `http.user_agent` to list of deprecated attributes (#503)
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
2023-11-12 10:10:09 +01:00
Alexandra Konrad e2952cf5a2
Move error namespace to the registry (#500)
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
2023-11-10 15:15:12 -06:00
Alexandra Konrad 3a8220c677
move device to the registry (#497)
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
2023-11-10 15:02:40 -06:00
Alexandra Konrad a1b924ca85
move process to registry (#502)
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
2023-11-10 14:53:46 -06:00
Alexander Wert 6a9acefdbf
Moved client, server, source, destination attributes to the registry (#391)
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
2023-11-09 10:19:03 -06:00
Alexander Wert e3da931d08
Add `code.stacktrace` attribute (#435)
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
2023-11-09 08:17:32 -06:00
Tristan Sloughter 65a3cc743f
change Erlang managed thread attribute to be the Erlang process (#491)
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
2023-11-07 18:38:11 +01:00
Ben Blackmore 39af37d093
docs: explain deployment.environment impact on service identity (#481)
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
2023-11-07 13:54:51 +01:00
Josh Suereth da1dbb567f
Staging the 1.23.0 release. (#489)
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
2023-11-03 12:55:57 -04:00
Liudmila Molkova 09b0b64990
Mark HTTP semantic conventions as stable (#377)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-11-03 12:05:54 -04:00
Trask Stalnaker 0de415c57d
Make `user_agent.original` and `http.request.header.*` attributes sampling relevant on HTTP server spans (#467) 2023-11-02 13:47:08 -04:00
Alexander Wert d6a478d8dc
Moved `messaging.*` attributes to the registry (#444)
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
2023-11-02 17:18:27 +01:00
Pablo Baeyens c34ca409ad
[resource/host] Define host.mac semantic convention (#340)
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Co-authored-by: Josh Suereth <joshuasuereth@google.com>
2023-11-02 12:05:54 -04:00
Trask Stalnaker 08c1d9f340
Change sampling relevant from MUST to SHOULD (and update build-tools version) (#486) 2023-11-02 16:41:11 +01:00
Trask Stalnaker 1eb70c4d74
Remove outdated `http.request.header.host` guidance (#479)
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
2023-11-01 09:09:56 +01:00
Trask Stalnaker 69d6d4fd67
Change `network.protocol.name` from opt-in to conditionally required (#478) 2023-11-01 09:04:51 +01:00
Johannes Tax 514d737d85
Update messaging "Receive", "Deliver", and "Create" operations according to OTEP 220 (#284)
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
2023-10-31 15:10:11 +01:00
Trask Stalnaker 8ff4ea6821
Make `client.address` sampling relevant on HTTP server spans (#469)
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
2023-10-31 11:08:23 +01:00
Liudmila Molkova a8535bdeb3
Make url.scheme opt in for HTTP client metrics and make server.port required (#459)
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
2023-10-31 10:59:22 +01:00