This PR clarifies semantic conventions for HTTP retries and redirects and defines a span structure and linking as well as span attributes for retries. Changes were discussed recently at Instrumentation SIG meetings.
This change addresses a scenario which is in the scope for bringing the existing HTTP semantic conventions for tracing to an initial stable state, see related [otep #174](https://github.com/open-telemetry/oteps/pull/174).
Fixes#1760
## Changes
Removes `db.cassandra.keyspace` and `db.hbase.namespace` (in preference for using `db.name`).
Clarifies `db.name` in the case where a database product provides multiple concepts that could be mapped to `db.name`.
* Avoid using gRPC when generic RPC systems have same properties
The concept of "streaming" is supported by multiple protocols including gRPC, but also others.
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
* Update specification/trace/semantic_conventions/rpc.md
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
* added spec changes per #1647
* added 'wired' as possible value to `net.host.connection_type`
* fixed spacing in CHANGELOG.md
* added mobile carrier attributes to semantic_conventions/trace/general.yaml
* fixed issue revealed by
* reverted extra space per markdownlint
* made connection_type allow custom values
* added additional space
* removed manually added table & ran generator tool
* separated connection.type & connection.subtype
* updated changelog to reflect iteration
* added literal radio tech to connection.subtype table
* added as option for connect.type
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
* Remove rpc.jsonrpc.method, clarify rpc.method instead.
* Add PR#.
* Clarify client side code.namespace/function.
* Use "ref" instead of "constraint: any_of".
This should be changed back once
https://github.com/open-telemetry/build-tools/issues/33
is resolved & the updated build tools available.
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
* Have consistent formatting for semantic convention enums
Currently, semantic convention enum values are not consistent.
For example, os.type values are all capitals whereas
cloud.infrastructure_service values are underscored lowercase.
This change improves the inconsistencies.
We also expect language implementations to autogenerate code
from enum values. Each language has their own conventions for
constant variable identifiers and we expect the consistent
formatting is going to help the language implementors.
Fixes#1519.
* Fix Azure Member Brief
Azure currently has an incorrect description associated with it. This fixes it 😄
* Update faas.md
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
* Add db.table to database semantic conventions
* Fix spacing in db semantic conventions
* Move db.table to SQL-specific call level attributes
* Clarify instructions for setting db.operation to a SQL keyword
* Specify that db.sql.table MUST NOT be set when not applicable
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
* Add db.table and db.operation to CHANGELOG
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
* Updating gRPC status semantic conventions
Since the simplification of trace status codes,
they no longer align with gRPC.
Clarifying the expected status code field for gRPC, as
well as the mappings between gRPC and OpenTelemetry status.
* Adding changelog entry
* Addressing feedback
Clarifying that gRPC spans should include the status code number,
rather than leave it ambiguous.
Adding gRPC semantic conventions in the yaml files to reflect these
changes.
* adding trailing whitespace
* Apply suggestions from code review
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
* addressing feedback
Ran table-generation to ensure that semantic conventions are added.
Removed tags for rpc.grpc yaml for now (not explicitly used).
* Update specification/trace/semantic_conventions/rpc.md
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
* Addressing feedback
re-generating TOC with markdown-toc
There was a conflict with sub-headings matching the same string. As such
qualified all headings.
* Switching gRPC status_code type to enum
gRPC's status_code code is better expressed as an enum.
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Trask Stalnaker