fix(asinput): Remove control of state.value from asInput

fix(asinput): Remove control of state.value from asInput
This commit is contained in:
Michael Roytman 2017-12-08 13:42:32 -05:00 committed by GitHub
commit 213b4faed1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 2 deletions

View File

@ -41,7 +41,7 @@ describe('asInput()', () => {
const wrapper = mount(<InputTestComponent {...props} />);
expect(wrapper.find('label').text()).toEqual(props.label);
expect(wrapper.find('#description-asInput1').text()).toEqual(props.description);
expect(wrapper.state('value')).toEqual(props.value);
expect(wrapper.prop('value')).toEqual(props.value);
});
it('creates generic prop id', () => {
@ -81,6 +81,21 @@ describe('asInput()', () => {
expect(wrapper.find('small').prop('id')).toEqual(`description-${testId}`);
});
it('overrides state value when props value changes', () => {
const initValue = 'foofoo';
const newValue = 'barbar';
const props = {
...baseProps,
value: initValue,
};
const wrapper = mount(<InputTestComponent {...props} />);
expect(wrapper.state('value')).toEqual(initValue);
wrapper.setProps({
value: newValue,
});
expect(wrapper.state('value')).toEqual(newValue);
});
describe('fires', () => {
it('blur handler', () => {
const spy = jest.fn();
@ -149,7 +164,7 @@ describe('asInput()', () => {
const err = wrapper.find('.form-control-feedback');
expect(err.exists()).toEqual(true);
expect(err.text()).toEqual(validationResult.validationMessage);
// expect(err.hasClass('invalid-feedback')).toEqual(true);
expect(err.hasClass('invalid-feedback')).toEqual(true);
const dangerIcon = wrapper.find('.fa-exclamation-circle');
expect(dangerIcon.exists()).toEqual(true);

View File

@ -46,6 +46,14 @@ const asInput = (WrappedComponent, labelFirst = true) => {
};
}
componentWillReceiveProps(nextProps) {
if (nextProps.value !== this.props.value) {
this.setState({
value: nextProps.value,
});
}
}
getDescriptions() {
// possible future work: multiple feedback msgs?
const errorId = `error-${this.state.id}`;