From 1f76ae125a87d34733e3a1b83d35daa6e2275424 Mon Sep 17 00:00:00 2001
From: Neil MacDougall <nmacdougall@suse.com>
Date: Wed, 22 Feb 2023 09:52:46 +0000
Subject: [PATCH] Added PR feedback

---
 gulpfile.js  | 19 ++++++++++---------
 package.json |  3 +++
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/gulpfile.js b/gulpfile.js
index 6d5e7cb..0239b38 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -102,15 +102,16 @@ gulp.task('bootstrap', function() {
     .pipe(gulp.dest(VERSION_DIST));
 });
 
-gulp.task('livereload', function() {
-  gulp.watch('./gulpfile.js', ['server:reload']);
-  gulp.watch('styles/**', ['css']);
-  gulp.watch('src/**', ['js']);
-  gulp.watch('templates/**', ['js']);
-  gulp.watch('partials/**', ['js']);
+gulp.task('livereload', function(cb) {
+  gulp.watch('./gulpfile.js', gulp.series('server:reload'));
+  gulp.watch('styles/**', gulp.series('css'));
+  gulp.watch('src/**', gulp.series('js'));
+  gulp.watch('templates/**', gulp.series('js'));
+  gulp.watch('partials/**', gulp.series('js'));
+  cb();
 })
 
-gulp.task('src', gulp.series('js','minjs','css','mincss','bootstrap'));
+gulp.task('src', gulp.series('minjs','mincss','bootstrap'));
 
 gulp.task('tarball', gulp.series('src', function() {
   return gulp.src([VERSION_DIST+'/**'], {base: DIST})
@@ -119,10 +120,10 @@ gulp.task('tarball', gulp.series('src', function() {
     .pipe(gulp.dest(DIST));
 }));
 
-gulp.task('build', gulp.series('src', 'tarball'), () => {});
+gulp.task('build', gulp.series('tarball'), () => {});
 gulp.task('default', gulp.series('build'));
 
-gulp.task('server', gulp.series('build','livereload', function() {
+gulp.task('server', gulp.series('build', 'livereload', function() {
   var cors = function(req, res, next) {
     res.setHeader('Access-Control-Allow-Origin', '*');
     next();
diff --git a/package.json b/package.json
index 9810339..0ce0190 100644
--- a/package.json
+++ b/package.json
@@ -13,6 +13,9 @@
     "type": "git",
     "url": "https://github.com/rancherio/api-ui.git"
   },
+  "engine": {
+    "node": ">= 14.14"
+  },  
   "scripts": {
     "start": "./node_modules/.bin/gulp server",
     "clean": "./node_modules/.bin/gulp clean",