rancher
/
dashboard
mirror of https://github.com/rancher/dashboard.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

code cleanup + fix breaking logic on unit test with non-existance of nodes to clone + add unit test (#10737)

This commit is contained in:
Alexandre Alves 2024-04-02 17:19:29 +01:00 committed by GitHub
parent 72440c3597
commit 00e4f83c34
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 55 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
shell/components/Carousel.vue
View File

@ -121,17 +121,23 @@ export default {
const slideTrack = document.getElementById('slide-track'); const slideTrack = document.getElementById('slide-track');
if (this.slider.length === 1) { if (this.slider.length === 1) {
// singleSlide.style = 'width: 100%; max-width: 100%';
slideTrack.style = 'transform:translateX(0%); width:100%; left:0'; slideTrack.style = 'transform:translateX(0%); width:100%; left:0';
} else { } else {
const node = document.getElementById('slide0'); const node = document.getElementById('slide0');
const clone = node.cloneNode(true);
if (node) {
const clone = node.cloneNode(true);
slideTrack.appendChild(clone);
}
const nodeLast = document.getElementById(`slide${ this.slider.length - 1 }`); const nodeLast = document.getElementById(`slide${ this.slider.length - 1 }`);
const cloneLast = nodeLast.cloneNode(true);
slideTrack.appendChild(clone); if (nodeLast) {
slideTrack.insertBefore(cloneLast, slideTrack.children[0]); const cloneLast = nodeLast.cloneNode(true);
slideTrack.insertBefore(cloneLast, slideTrack.children[0]);
}
} }
const lastSeenCluster = sessionStorage.getItem(carouselSeenStorageKey); const lastSeenCluster = sessionStorage.getItem(carouselSeenStorageKey);
@ -142,7 +148,7 @@ export default {
} }
this.autoScrollSlideInterval = setInterval(this.autoScrollSlide, 5000); this.autoScrollSlideInterval = setInterval(this.autoScrollSlide, 5000);
}, }
}; };

43
shell/components/__tests__/Carousel.test.ts Normal file
View File

@ -0,0 +1,43 @@
import { mount } from '@vue/test-utils';
import Carousel from '@shell/components/Carousel.vue';
describe('component: Carousel', () => {
it('should render component with the correct data applied', async() => {
const sliders = [
{
key: 'key-0',
repoName: 'some-repo-name-0',
chartNameDisplay: 'chart-name-display-0',
chartDescription: 'chart-description-0'
},
{
key: 'key-1',
repoName: 'some-repo-name-1',
chartNameDisplay: 'chart-name-display-1',
chartDescription: 'chart-description-1'
},
{
key: 'key-2',
repoName: 'some-repo-name-2',
chartNameDisplay: 'chart-name-display-2',
chartDescription: 'chart-description-2'
},
{
key: 'key-3',
repoName: 'some-repo-name-3',
chartNameDisplay: 'chart-name-display-3',
chartDescription: 'chart-description-3'
}
];
const wrapper = mount(Carousel, {
propsData: { sliders },
mocks: { $store: { getters: { clusterId: () => 'some-cluster-id' } } }
});
// testing https://github.com/rancher/dashboard/issues/9975
sliders.forEach((slider, index) => {
expect(wrapper.find(`#slide${ index } h1`).html()).toContain(slider.chartNameDisplay);
});
});
});