rancher
/
dashboard
mirror of https://github.com/rancher/dashboard.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

clear empty comment, remove expanded type + add comment about dupe 

- fixes bad definition of getValue?: () => any (should accept a prop)
This commit is contained in:
Richard Cox 2025-09-18 11:30:24 +01:00
parent 9c747f1c4f
commit 31362577fe
2 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
shell/components/ResourceTable.vue
View File

@ -317,7 +317,6 @@ export default {
// add custom table columns provided by the extensions ExtensionPoint.TABLE_COL hook // add custom table columns provided by the extensions ExtensionPoint.TABLE_COL hook
// gate it so that we prevent errors on older versions of dashboard // gate it so that we prevent errors on older versions of dashboard
if (this.$store.$plugin?.getUIConfig) { if (this.$store.$plugin?.getUIConfig) {
//
const extensionCols = getApplicableExtensionEnhancements(this, ExtensionPoint.TABLE_COL, TableColumnLocation.RESOURCE, this.$route); const extensionCols = getApplicableExtensionEnhancements(this, ExtensionPoint.TABLE_COL, TableColumnLocation.RESOURCE, this.$route);
// Try and insert the columns before the Age column // Try and insert the columns before the Age column

18
shell/core/types.ts
View File

@ -130,20 +130,8 @@ export type Card = {
component: Function; component: Function;
}; };
export type TableColumn = { // Duplication of HeaderOptions?
name?: string; export type TableColumn = any;
label?: string;
labelKey?: string;
sort?: string | string[];
search?: string | string[];
value?: string;
getValue?: () => any;
width?: number;
default?: string;
formatter?: string;
canBeVariable?: boolean;
defaultSort?: boolean;
};
/** Definition of a tab (options that can be passed when defining an extension tab enhancement) */ /** Definition of a tab (options that can be passed when defining an extension tab enhancement) */
export type Tab = { export type Tab = {
@ -341,7 +329,7 @@ export interface HeaderOptions {
formatterOpts?: any; formatterOpts?: any;
/** /**
* Provide a function which accets a row and returns the value that should be displayed in the column * Provide a function which accepts a row and returns the value that should be displayed in the column
* @param row This can be any value which represents the row * @param row This can be any value which represents the row
* @returns Can return {@link string | number | null | undefined} to display in the column * @returns Can return {@link string | number | null | undefined} to display in the column
*/ */