From 5be03a9a266f46ba9e4b5fbaa0ec5159851dadcc Mon Sep 17 00:00:00 2001
From: scures <scurescu@suse.com>
Date: Mon, 5 Sep 2022 12:16:35 +0200
Subject: [PATCH] Persists fetched data and user selection between pages

---
 .../components/application/AppSource.vue      | 48 +++++++++++++++----
 shell/components/form/GithubPicker.vue        | 41 +++++++++++++++-
 2 files changed, 78 insertions(+), 11 deletions(-)

diff --git a/pkg/epinio/components/application/AppSource.vue b/pkg/epinio/components/application/AppSource.vue
index fa20feb5ce..462df7c0b7 100644
--- a/pkg/epinio/components/application/AppSource.vue
+++ b/pkg/epinio/components/application/AppSource.vue
@@ -29,10 +29,18 @@ interface GitUrl {
   branch: string
 }
 
-interface GitHub {
+type GithubAPIData = {
+  repos: any[],
+      branches: any[],
+      commits: any[]
+}
+export interface GitHub {
   usernameOrOrg?: string,
-  url: string
+  repo: string,
   commit: string,
+  branch: string,
+  url: string,
+  sourceData: GithubAPIData
 }
 
 interface BuilderImage {
@@ -122,8 +130,15 @@ export default Vue.extend<Data, any, any, any>({
 
       github: {
         usernameOrOrg: this.source?.github.usernameOrOrg || '',
-        url:           this.source?.github.url || '',
+        repo:           this.source?.github.repo || '',
         commit:        this.source?.github.commit || '',
+        branch:        this.source?.github.branch || '',
+        url:           this.source?.github.url || '',
+        sourceData:    this.source?.github.sourceData || {
+          repos:    [],
+          branches: [],
+          commits:  []
+        }
       },
 
       builderImage: {
@@ -153,11 +168,12 @@ export default Vue.extend<Data, any, any, any>({
       APPLICATION_SOURCE_TYPE
     };
   },
-
   mounted() {
     if (!this.appChart) {
       Vue.set(this, 'appChart', this.appCharts[0].value);
     }
+
+    this.$emit('valid', false);
     this.update();
   },
 
@@ -280,20 +296,30 @@ export default Vue.extend<Data, any, any, any>({
 
       this.update();
     },
-    githubData({ repo, selectedAccOrOrg, commit }: {
-      commit: string,
+    githubData({
+      repo, selectedAccOrOrg, branch, commitSha, sourceData
+    }: {
+      commitSha: string,
       selectedAccOrOrg: string,
       repo: string,
+      branch: string,
+      sourceData: GithubAPIData
     }) {
-      const url = `https://github.com/${ selectedAccOrOrg }/${ repo }`;
+      if (!!selectedAccOrOrg && !!repo && !!commitSha && !!branch) {
+        const url = `https://github.com/${ selectedAccOrOrg }/${ repo }`;
 
-      if (url.length && selectedAccOrOrg.length) {
         this.github.usernameOrOrg = selectedAccOrOrg;
         this.github.url = url;
-        this.github.commit = commit;
+        this.github.commit = commitSha;
+        this.github.branch = branch;
+        this.github.repo = repo;
+        this.github.sourceData = sourceData;
 
         this.update();
         this.$emit('valid', true);
+      } else {
+        this.update();
+        this.$emit('valid', false);
       }
     }
   },
@@ -463,7 +489,9 @@ export default Vue.extend<Data, any, any, any>({
       </div>
     </template>
     <template v-else-if="type === APPLICATION_SOURCE_TYPE.GIT_HUB">
-      <GithubPicker @githubData="githubData" />
+      <KeepAlive>
+        <GithubPicker :selection="source.github" @githubData="githubData" />
+      </KeepAlive>
     </template>
     <Collapse :open.sync="open" :title="'Advanced Settings'" class="mt-30 mb-30 source">
       <template>
diff --git a/shell/components/form/GithubPicker.vue b/shell/components/form/GithubPicker.vue
index 75ec4523c1..438bdaa8bc 100644
--- a/shell/components/form/GithubPicker.vue
+++ b/shell/components/form/GithubPicker.vue
@@ -15,6 +15,12 @@ export default {
     LabeledInput,
   },
 
+  props: {
+    selection: {
+      type:     Object,
+      default: null
+    }
+  },
   data() {
     const commitsTableHeaders = [
       {
@@ -80,6 +86,19 @@ export default {
     };
   },
 
+  mounted() {
+    // Keeps the selected repo/branch/commit when the user switches between steps
+    if (this.selection) {
+      this.selectedAccOrOrg = this.selection.usernameOrOrg;
+      this.selectedRepo = this.selection.repo;
+      this.selectedBranch = this.selection.branch;
+
+      // API calls data
+      this.repos = this.selection.sourceData.repos;
+      this.branches = this.selection.sourceData.branches;
+      this.commits = this.selection.sourceData.commits;
+    }
+  },
   computed: {
     preparedRepos() {
       return this.prepareArray(this.repos);
@@ -96,6 +115,15 @@ export default {
       this.selectedRepo = null;
       this.selectedBranch = null;
       this.selectedCommit = false;
+
+      this.communicateReset();
+    },
+    communicateReset() {
+      this.$emit('githubData', {
+        selectedAccOrOrg: this.selectedAccOrOrg,
+        repo:             this.selectedRepo,
+        commitSha:        this.selectedCommit,
+      });
     },
     async fetchRepos() {
       try {
@@ -112,6 +140,9 @@ export default {
           if (this.oldUsername !== this.selectedAccOrOrg) {
             this.oldUsername = this.selectedAccOrOrg;
 
+            // Resets state, just in case.
+            this.communicateReset();
+
             return this.reset();
           }
         }
@@ -129,6 +160,8 @@ export default {
       this.selectedBranch = null;
       this.selectedCommit = false;
 
+      this.communicateReset();
+
       try {
         const res = await this.$store.dispatch('github/fetchBranches', { repo: this.selectedRepo, username: this.selectedAccOrOrg });
 
@@ -147,6 +180,8 @@ export default {
       this.showSelections = false;
       this.selectedCommit = false;
 
+      this.communicateReset();
+
       try {
         const res = await this.$store.dispatch('github/fetchCommits', {
           repo:     this.selectedRepo,
@@ -210,10 +245,14 @@ export default {
           repo:             this.selectedRepo,
           branch:           this.selectedBranch,
           commitSha:        this.selectedCommit.sha,
+          sourceData:       {
+            repos:    this.repos,
+            branches: this.branches,
+            commits:  this.commits
+          }
 
         });
 
-        this.$emit('valid', true);
         this.showSelections = true;
       }