From 7fa934cfa86e2912244413253fdc6b526236a10c Mon Sep 17 00:00:00 2001 From: Cody Jackson Date: Wed, 4 Aug 2021 12:25:53 -0700 Subject: [PATCH] Inform the users that legacy features aren't supported in k8s 1.21+ https://github.com/rancher/dashboard/issues/3589 --- assets/translations/en-us.yaml | 1 + edit/provisioning.cattle.io.cluster/rke2.vue | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/assets/translations/en-us.yaml b/assets/translations/en-us.yaml index 324666729a..01bfac548e 100644 --- a/assets/translations/en-us.yaml +++ b/assets/translations/en-us.yaml @@ -994,6 +994,7 @@ cluster: kubernetesVersion: label: Kubernetes Version toolsTip: Use the new Cluster Tools to manage and install Monitoring, Logging and other tools + legacyWarning: The legacy feature flag is enabled and not all legacy features are supported in Kubernetes 1.21+. name: label: Cluster Name placeholder: A unique name for the cluster diff --git a/edit/provisioning.cattle.io.cluster/rke2.vue b/edit/provisioning.cattle.io.cluster/rke2.vue index 55d2e3a6ed..089538f200 100644 --- a/edit/provisioning.cattle.io.cluster/rke2.vue +++ b/edit/provisioning.cattle.io.cluster/rke2.vue @@ -37,6 +37,8 @@ import Questions from '@/components/Questions'; import { normalizeName } from '@/components/form/NameNsDescription.vue'; import ClusterMembershipEditor from '@/components/form/Members/ClusterMembershipEditor'; +import { LEGACY } from '@/store/features'; +import semver from 'semver'; import ACE from './ACE'; import AgentEnv from './AgentEnv'; import DrainOptions from './DrainOptions'; @@ -239,6 +241,7 @@ export default { computed: { ...mapGetters({ allCharts: 'catalog/charts' }), + ...mapGetters({ features: 'features/get' }), rkeConfig() { return this.value.spec.rkeConfig; @@ -590,6 +593,17 @@ export default { return versions.filter(x => !!x); }, + + showk8s21LegacyWarning() { + const isLegacyEnabled = this.features(LEGACY); + + if (!isLegacyEnabled) { + return false; + } + const selectedVersion = semver.coerce(this.value.spec.kubernetesVersion); + + return semver.satisfies(selectedVersion, '>=1.21.0'); + } }, watch: { @@ -1014,7 +1028,7 @@ export default { - +