From d3c5516adcc2303a025e86a6c045869203c06ae5 Mon Sep 17 00:00:00 2001 From: Westly Wright Date: Tue, 18 Aug 2020 10:33:56 -0700 Subject: [PATCH 1/3] update service labels component value path rancher/dashboard#985 --- edit/service.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edit/service.vue b/edit/service.vue index 0f7d1629ab..be0c1eceb0 100644 --- a/edit/service.vue +++ b/edit/service.vue @@ -325,7 +325,7 @@ export default {
From a9cc4e39dcca97b6764bcc1481320e8ec769204d Mon Sep 17 00:00:00 2001 From: Westly Wright Date: Tue, 18 Aug 2020 10:42:52 -0700 Subject: [PATCH 2/3] expose target port for headless service types i think this check was left over from before i pulled this code out into ServicePorts component rancher/dashboard#1028 --- components/form/ServicePorts.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/form/ServicePorts.vue b/components/form/ServicePorts.vue index 56601043b2..e78c29fbf8 100644 --- a/components/form/ServicePorts.vue +++ b/components/form/ServicePorts.vue @@ -125,7 +125,7 @@ export default { - + @@ -173,7 +173,7 @@ export default { @input="queueUpdate" /> - + {{ row.targetPort }} Date: Tue, 18 Aug 2020 11:47:37 -0700 Subject: [PATCH 3/3] Default tabbed comp to use history replace state instead of push state rancher/dashboard#820 --- components/Tabbed/index.vue | 19 +++++++++++++++++-- edit/service.vue | 2 +- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/components/Tabbed/index.vue b/components/Tabbed/index.vue index f330f375b4..83ee9efdfb 100644 --- a/components/Tabbed/index.vue +++ b/components/Tabbed/index.vue @@ -38,6 +38,11 @@ export default { scrollOnChange: { type: Boolean, default: false + }, + + tabsUseHistoryReplace: { + type: Boolean, + default: true, } }, @@ -168,7 +173,11 @@ export default { select(name/* , event */) { const { sortedTabs, - $route: { hash: routeHash }, + tabsUseHistoryReplace, + $route: { + hash: routeHash, + fullPath + }, } = this; const selected = this.find(name); @@ -183,7 +192,13 @@ export default { } if (routeHash !== hashName) { - window.location.hash = `#${ name }`; + if (tabsUseHistoryReplace) { + const fullPathWOHash = fullPath.includes('#') ? fullPath.split('#')[0] : fullPath; + + window.history.replaceState(null, '', `${ fullPathWOHash }#${ name }`); + } else { + window.location.hash = `#${ name }`; + } } for ( const tab of sortedTabs ) { diff --git a/edit/service.vue b/edit/service.vue index be0c1eceb0..c7f8c26e03 100644 --- a/edit/service.vue +++ b/edit/service.vue @@ -204,7 +204,7 @@ export default {
- +