Address PR feedback

This commit is contained in:
Neil MacDougall 2023-02-09 20:37:07 +00:00
parent e0487bf8d5
commit b1ac45d18e
2 changed files with 8 additions and 61 deletions

View File

@ -17,19 +17,19 @@ export default {
<div>
<div class="row">
<div class="col span-6">
<UnitInput
v-model="value.auditInterval"
label="Audit interval"
suffix="Seconds"
<UnitInput
v-model="value.auditInterval"
label="Audit interval"
suffix="Seconds"
/>
</div>
</div>
<div class="row mt-10">
<div class="col span-6">
<UnitInput
v-model="value.constraintViolationsLimit"
label="Constraint violations limit"
suffix=""
<UnitInput
v-model="value.constraintViolationsLimit"
label="Constraint violations limit"
suffix="Violations"
/>
</div>
</div>

View File

@ -1,53 +0,0 @@
<script>
import { Checkbox } from '@components/Form/Checkbox';
import { Banner } from '@components/Banner';
export default {
components: { Banner, Checkbox },
props: {
value: {
type: Object,
default: () => {
return {};
}
}
},
computed: {
mustSelectOne() {
if (!this.value.prom2teams.enabled && !this.value.sachet.enabled) {
return 'error';
}
return 'info';
}
},
mounted() {
if (this.mustSelectOne === 'error') {
this.value.sachet.enabled = true;
}
}
};
</script>
<template>
<div>
<Banner :color="mustSelectOne">
{{ t('rancherAlertingDrivers.selectOne') }}
</Banner>
<div class="row">
<div class="col span-6">
<Checkbox
v-model="value.prom2teams.enabled"
label-key="rancherAlertingDrivers.msTeams"
/>
</div>
</div>
<div class="row">
<div class="col span-6">
<Checkbox
v-model="value.sachet.enabled"
label-key="rancherAlertingDrivers.sms"
/>
</div>
</div>
</div>
</template>