From d0801db34da22de43a2ac8705776a54e88708f7c Mon Sep 17 00:00:00 2001 From: Phillip Rak Date: Tue, 21 Oct 2025 13:42:44 -0700 Subject: [PATCH] Pass validation when configurating users and groups The github app auth provider was preventing admins from configuring users and groups because validation will fail without a client secret. Other auth providers, like `shell/edit/auth/oidc.vue`, get around this by short-circuiting to true when not editing the config. Signed-off-by: Phillip Rak --- shell/edit/auth/github.vue | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/shell/edit/auth/github.vue b/shell/edit/auth/github.vue index 75b2d576d6..09292e0a77 100644 --- a/shell/edit/auth/github.vue +++ b/shell/edit/auth/github.vue @@ -97,6 +97,11 @@ export default { }, validationPassed() { + // Allows for configuring authorized users and groups + if ( this.model.enabled && !this.editConfig ) { + return true; + } + if (!this.model.clientId || !this.model.clientSecret) { return false; }