Commit Graph

61 Commits

Author SHA1 Message Date
Alexandre Alves faa7fe3b60
A11y report fixes (#14530)
* fix item 2: All page content should be contained by landmarks

* fix item 4. Elements must only use permitted ARIA attributes

* fix item 6. ARIA attributes must conform to valid values

* fix bug on item 6. and fix item 7. <ul> and <ol> must only directly contain <li>, <script> or <template> elements

* fix item 8. Interactive controls must not be nested

* fix item 10. ARIA toggle fields must have an accessible name

* fix item 11. autocomplete attribute must be used correctly

* fix item 12. Form elements must have labels

* fix item 14. ARIA input fields must have an accessible name

* fix item 15. Buttons must have discernible text

* fix item 16. Images must have alternative text

* working on item 17

* finish fix item 17. ARIA role should be appropriate for the element

* fix wrong role in hidden inputs

* address pr comments
2025-07-10 10:09:09 +01:00
Francesco Torchia 788b26a664
KeyValue clean-up
- remove protectedKeys and toggleFilter
- add keyErrors for key field

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2025-07-03 16:35:37 +02:00
Siva Kanakala 5192b2501f
fix-onPaste-Keyvalue (#13071) 2025-07-02 08:50:37 +01:00
edenhernandez-suse bcc638d818 Fleet settings minor issues - headings, button sizes 2025-06-27 13:53:31 +02:00
Francesco Torchia 86fbbd3930
Fleet fix GitRepo paths add comments
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2025-06-19 12:15:48 +02:00
Francesco Torchia 275cb5f450
Fleet fix GitRepo paths labels and tooltips
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2025-06-19 11:54:55 +02:00
Francesco Torchia a7aa6eeaf5
Fleet fix gitrepo paths css
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2025-06-19 11:54:52 +02:00
Francesco Torchia a5608820e8
Fleet add GitRepoPaths component and wire it in gtirepo pages
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2025-06-19 11:54:46 +02:00
Alexandre Alves 387891f61f
improve a11y in some of our most used components in Rancher Dashboard (#14343)
* improve a11y in some of our most used components in Rancher Dashboard

* revert changes to roles on keyvalue component
2025-06-04 08:50:48 +01:00
Alexandre Alves 42efc9d3c5
fix some a11y items on ArrayList and KeyValue (#13832) 2025-03-25 09:28:51 +00:00
Mo Mesgin 2a30d37567 Merge branch 'master' of github.com:rancher/dashboard into 13470-keyvalue 2025-02-27 08:32:26 -08:00
Mo Mesgin 4289c9e3da use global css class to hide elements 2025-02-27 08:31:39 -08:00
Mo Mesgin 60ac57d278 hide filtered items in KeyValue 2025-02-26 15:31:30 -08:00
Francesco Torchia aa9ac4d60a
Fleet: add plus icons to buttons
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2025-02-26 10:28:11 +01:00
Alexandre Alves 84c234383a
Fix textual descriptions for cluster appearance in multiple places (#13416)
* Fix textual descriptions for cluster appearance in multiple places

* address pr comments

* address pr comments
2025-02-24 09:00:54 +00:00
Phillip Rak a0f09abd11
Improve accessibility of `KeyValue.vue` (#13261)
* Add aria labels to KeyValue inputs

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Add button roles to KeyValue

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Add aria labels for grid structure

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Add rowgroup and row to KeyValue grid structure

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Add aria-labels to buttons

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

---------

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-02-10 09:54:18 +00:00
Yonas Berhe 23ba8dde87 automation: services tests 2025-01-31 15:26:56 -08:00
Francesco Torchia eac3deaa4b
Add harvester features
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2024-11-13 15:38:36 +01:00
Cody Jackson 5052c2a8e8 Enabling `vue/require-explicit-emits` linting rule
https://github.com/rancher/dashboard/issues/11961
2024-09-19 09:58:53 -07:00
Phillip Rak b68adb3833 Revert "Refactoring the plain element <input> data bindings"
This reverts commit 7f1536d9cf.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-27 15:39:02 -07:00
Cody Jackson d47ce13f28 Fixed the remaining lint warnings and errors
The chart.test.ts is likely more broken now than it was. This can be fixed later.
2024-08-22 16:07:04 -07:00
Cody Jackson 909affa02f Replacing $emit('input' with $emit('update:value'
This should've been done in the migration script and will be fixed for the next run.
2024-08-22 16:07:03 -07:00
Cody Jackson 9b829c55ea Ran `yarn lint --fix` 2024-08-22 16:05:36 -07:00
Cody Jackson d5ce4fff2e Run the vue3 migration script
Commands run:

➤ yarn migrate
➤ git clean -fdx
➤ nvm use 20
➤ yarn
2024-08-22 16:05:36 -07:00
Cody Jackson 7f1536d9cf Refactoring the plain element <input> data bindings
Performing this change so the vue3 migration script can modify all @input, @v-model of components without changing plain elements. This will reduce the number of vue3 compiler errors.
2024-08-22 16:04:52 -07:00
Nancy f4fbf0068c
GKE: fix node pool taint effect options (#11339)
* update gke node pools to use NO_SCHEDULE PREFER_NO_SCHEDULE and NO_EXECUTE as taint effect options

* fix gke node pool test

* fix taints default add value and tests
2024-07-03 07:20:37 -07:00
andy.lee 677b1f1b24 fix: support colon as separator when onPaste context in label key field
Signed-off-by: andy.lee <andy.lee@suse.com>
2024-05-07 16:20:49 +08:00
Giuseppe Leo c298d64d95
Replace default values of props using global variables with computed case (#10848)
* Replace store global var with i18n global var for props default value

* Replace props default values using i18n from state to computed values

* Added empty default value

* Add linting corrections not automatically triggered on save

* Fix typo
2024-04-22 11:03:07 +02:00
Nancy 86001e4532
Fix KeyValue behaviour when parent component updates value prop (#10643)
* remove legacy items except for project config-maps and secrets

* add kv test

* add a watcher to keyvalue to ensure that it updates when the parent component changes the value being displayed

* add keyvalue unit tests to cover add and remove buttons

* remove testing code

* remove more test code

* use isequal instead of json stringify

---------

Co-authored-by: Mo Mesgin <mmesgin@Mos-M2-MacBook-Pro.local>
2024-03-26 10:52:41 -07:00
yonasberhe23 3099aefcab
ui automation: global settings (#9458)
* ui automation: global settings

---------

Co-authored-by: Yonas Berhe <yberhe@Yonass-MacBook-Pro.local>
2024-02-01 15:06:03 -08:00
Nancy 4cca5faf81
AKS provisioning extension (#9669)
Adds a built-in AKS provisioning extension to replace the embedded ember pages, as well as modifications to the provisioning UI to support other non-rke2 provisioning extensions
2024-01-11 07:52:45 -08:00
Phillip Rak a6b3c1c927 Create e2e test for `configmap`
This test allows us to assert that blocks containing long lines (over 80 characters) entered into a configmap value field will output the correct value upon saving. The intent of this test is to assert that the regression described in #10044 is resolved and will not be reintroduced if further changes are made to `create-yaml`.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2023-12-12 10:57:05 -07:00
Richard Cox 0245a8cb93 Merge remote-tracking branch 'upstream/master' into epinio/resolve-conflicts-with-master 2023-06-23 18:00:14 +01:00
Giuseppe Leo 01eeb0548f
Add recommended lint rules globally (#8997)
* Update configuration

* Create default config for eslint

* Restore plugin:vue/recommended

* Add exceptions and overrides

* Correct manually remaining issues

* Adding further picked exceptions groupped up

* Fix or disable specific cases manually and singularly

* Add naming linting exception

* Remove unused variable in component

* Move rules to default

* Autocorrect rancher/components linting issues

* Configure VSCode to use multiple files, to display linting for rancher components

* Disable jest lint hook restriction for string list component

* Autofix
2023-06-23 17:02:55 +02:00
Francesco Torchia b2bf86bb08
Merge remote-tracking branch 'upstream/master' into merge-master-to-epinio-dev 2023-06-22 12:58:57 +02:00
richa e7fbf0dfcd
Onenter newline textarea (#9116)
* Added test for preventDefault

* Added test for prevent default event on keypress Enter in CruResource component

* Removed test console log

* Fixed lint

* Added data-testid to form

* Fixed lint

* Add new line on pressing enter

* Test enter new line

* Test textarea Enter button in CruResource form

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

---------

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Co-authored-by: Francesco Torchia <francesco.torchia@suse.com>
2023-06-20 15:43:34 +02:00
Francesco Torchia 55fd701fca
Fix Upload button position in case of scroll
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-06-20 10:18:36 +02:00
Francesco Torchia 55f023bb9c
Assign file name as key field when unddefined
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-06-20 10:18:36 +02:00
Francesco Torchia c5860f82e8
Make upload button always visible
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-06-20 10:18:35 +02:00
Francesco Torchia 9049a25f77
Fix upload label translation
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-06-20 10:18:35 +02:00
Francesco Torchia d3f8100ef9
Add upload button to values field of KeyValue component
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-06-20 10:18:35 +02:00
Neil MacDougall 3db04f1e9a
Changes to support custom node driver UI extensions (#8735)
* Changes to support custom node driver UI extensions

* Fix bad merge

* Fix merge

* Fix bad merge

* Revert changes that are more impactful for now

* Add mock for $plugin

* Fix lint issue

* Address PR feedback

* Fix bad rebase

* Fix merge issues

* Removed unused import

* Fix merge issue

* Add back in missing validation for roles

* Fix unit test
2023-05-25 15:37:16 +01:00
Phillip Rak ade3c9f4e7 Replace all instances of `v-tooltip` with `v-clean-tooltip`
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2023-05-18 15:39:14 -07:00
Francesco Torchia 7653bc3ca6
[KeyValue] test multiline field
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-05-11 17:13:13 +02:00
Francesco Torchia 98c91ce5a3
improve code comments
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-04-28 09:48:13 +02:00
Francesco Torchia d91e79b5b4
move text area css into CodeMirror component
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-04-28 09:22:08 +02:00
Francesco Torchia b326ee6369
move text-area options to codeMirror component
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-04-28 09:02:48 +02:00
Francesco Torchia f86e303246
rename "cm" for codeMirrors variables
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-04-28 08:57:01 +02:00
Francesco Torchia e2c58c8c61
KeyValue, fix value field indexing
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-04-28 08:22:12 +02:00
Francesco Torchia ae8b606e64
KeyValue, fix text font in value multiline fields
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-03-29 15:59:58 +02:00