Commit Graph

61 Commits

Author SHA1 Message Date
Neil MacDougall cbc94e3f8e
Remove icon-fw and other unused icon classes (#15158) 2025-08-14 21:39:23 +01:00
Siva Kanakala 9ce164ae50 add unique :key to each component 2025-07-22 10:39:10 +05:30
Alexandre Alves f206b540e8
fix problem with extra space and scroll on settings banner page (#14320)
* fix problem with extra space and scroll on settings banner page

* add v-if to windowmanager + prevent focus on slideInPanelManager close button if there is no slide in panel visible

* remove weird trigger-focus-trap on close button

* address flaky e2e tests
2025-05-15 08:45:17 +01:00
Phillip Rak dc30093509
Replace container logs actions with new dropdown menu component (#14172)
* Create new `useDropdownItem` composable

This composable defines common methods that can be shared across different dropdown menu item types.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Create new `RcDropdownMenuItemCheckbox` component

`RcDropdownMenuItemCheckbox` specifies the styles and behaviors for a menu items that acts as a checkbox.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Create a select item dropdown component

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Move container actions into dedicated component

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Toggle container logs actions based on environment

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Fix type for labeledSelect component ref

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Replace trigger mixin data with event.stop

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Fix typo: LocaleSelector

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

---------

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-05-06 10:50:09 -07:00
Phillip Rak dcad2cc321 Make terminal and editor escape sequence `Shift+Escape`
The escape key conflicts with modal editing when working in VIM mode. Using `Shift+Escape` helps to prevent that conflict.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-03-05 14:38:08 -07:00
Alexandre Alves 871ebd1b9f
fix issue (#13571) 2025-03-04 12:22:50 +00:00
Alexandre Alves 3970a9ff63
fix misc issues for a11y (#13519)
* fix misc issues for a11y

* fix prop + fix issue with white area not resizing as whole shell window

* improve aria labels for shell resize
2025-02-28 15:56:18 +00:00
Alexandre Alves 9664a29373
Fix issue with configmap description and pressing `space` shifting focus (#13509)
* update computed patterns that use refs

* update pattern
2025-02-26 09:45:34 +00:00
Alexandre Alves 52b516a5d9
Fix Header keyboard navigation (#13369)
* address header accessibility issues

* fix codemirror component not using refs + improve logic to check yaml editor focus on app modal

* add missing optional chaining

* fix unit test

* fix some failing e2e tests

* fix lint issue

* revert changes to namespaceFilter + revert changes to e2e tests

* revert e2e changes

* revert e2e changes

* add fix for configmap e2e test

* add unique name for configmap resource creation test

* test e2e fix

* address pr comments
2025-02-21 08:51:39 +00:00
Alexandre Alves 2786ad7612
add missing alt to image elements (#13383) 2025-02-13 11:44:10 +00:00
Phillip Rak 0568efe051 Fix Container Shell unit tests
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-12-02 15:53:11 -07:00
Phillip Rak 0832160a54 Update ContainerShell error messages
This updates the error messages printed to provide clarity by adding:

1. a timestamp and log level to the messages
2. human-readable explanation when `/bin/sh` is missing from a container

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-12-02 14:54:06 -07:00
Phillip Rak 3099018762 Use `writeln` instead of `write`
This uses `writeln` instead of `write` so that logs can default to printing in the terminal on multiple lines.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-12-02 14:54:06 -07:00
Jordon Leach 8e18f2e18c
ContainerShell window manager fixes (#11973)
* Remove border when terminal window is focused

Remove deep selector from non-scoped style

Migrate vue-resize library to vue3-resize

* Fix codeMirrorRef instance name

* Missing semicolon
2024-09-20 08:42:32 -04:00
Cody Jackson 5052c2a8e8 Enabling `vue/require-explicit-emits` linting rule
https://github.com/rancher/dashboard/issues/11961
2024-09-19 09:58:53 -07:00
Mo Mesgin 682a09cae5 replace trigger with triggers 2024-09-11 10:56:45 -07:00
Mo Mesgin 296f1a4cc5 replace old names/props from v-tooltip with new ones from floating-vue 2024-09-10 14:48:52 -07:00
Nancy 85c5c28c22
Vue3 fix unit tests (#11776)
* remove $set from AKS validators

* fix cruGKE not rendering

* fix most aks unit tests

* fix crueks and eks config unit tests

* fix eks networking and nodegroup unit tests

* fix gke unit tests

* fix consumption gauge test

* fix namespacefilter tests

* fix command and taints unit tests

* fix questions unit tests

* fix hpa and service unit tests

* fix registryconfigs unit tests

* fix job unit tests

* fix longhorn unit tests

* fix addextensionsrepos unit tests

* fix rke2 basics unit tests

* fix container shell unit tests

* fix last aks pool test

* fix mount tests

* fix namespace and pv unit tests

* fix codemirror unit tests

* clean up aks, boolean, namespacefilter unit tests

* fix namespacefilter test

* remove redundant test case
2024-09-10 08:07:21 -07:00
Mo Mesgin 6c6eec8e47 Merge branch 'master' of github.com:rancher/dashboard into 11684-popover-fix 2024-09-03 12:02:58 -07:00
Phillip Rak 1846eb8d32 Update virtual scroll behavior
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-30 10:24:58 -07:00
Alexandre Alves 60026587c3 fixing tooltips and metions of tooltips and dropdowns wherever I could find them 2024-08-30 15:49:34 +01:00
Phillip Rak b68adb3833 Revert "Refactoring the plain element <input> data bindings"
This reverts commit 7f1536d9cf.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-27 15:39:02 -07:00
Cody Jackson 8d59cd5914 Skipping all failing unit tests for the Vue3 merge. 2024-08-22 21:12:40 -07:00
Phillip Rak a71857ce7d Unit test updates - partially fixed
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-22 16:09:56 -07:00
Cody Jackson e22f306431 Changed how we styled ContainerShell
I couldn't get scoped to work with slotted and deep pseudo selectors. More investigation would be needed
2024-08-22 16:09:55 -07:00
Phillip Rak 7874da578f Fix slot syntax
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-22 16:09:54 -07:00
cnotv 78d70353c5 Unit test: Migrate unit tests with the script 2024-08-22 16:07:03 -07:00
Phillip Rak 399696ae73 Upgrade `v-tooltip` to `floating-vue`
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-22 16:05:37 -07:00
Cody Jackson 9b829c55ea Ran `yarn lint --fix` 2024-08-22 16:05:36 -07:00
Cody Jackson d5ce4fff2e Run the vue3 migration script
Commands run:

➤ yarn migrate
➤ git clean -fdx
➤ nvm use 20
➤ yarn
2024-08-22 16:05:36 -07:00
Cody Jackson 7f1536d9cf Refactoring the plain element <input> data bindings
Performing this change so the vue3 migration script can modify all @input, @v-model of components without changing plain elements. This will reduce the number of vue3 compiler errors.
2024-08-22 16:04:52 -07:00
Alexandre Alves 0b1a331c3a
recreate pr 9831 + fix e2e tests (#10245)
Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2024-01-10 17:09:53 +00:00
LiuYan c9bb8a19f0
fix(ContainerLogs): fix display error if log is truncated (#10197)
* fix(ContainerLogs): fix display error if log is truncated

* test(ContainerLogs): adding test cases for truncated log processing

* add test for empty string

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2024-01-02 17:37:29 +00:00
Neil MacDougall 29d8f34ba5
Fix for Monitoring Helm chart sometimes adds empty selector (#10085)
* Fix for Monitoring Helm chart sometimes adds empty selector

* Correct close icon styling

* Tweak close icon width

* Fix lint issues
2023-12-14 13:23:25 +00:00
Alexandre Alves 6637583874
remove "process." mentions from Dashboard and adjust code (#10119)
* remove process.client and process.server mentions and adjust code

* fix a couple of missing conditions for process.server

* remove commented line

* remove process.static

* fix lint errors

* uncomment code

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2023-12-13 08:41:26 +00:00
Neil MacDougall fdb061bfbb
Fix bug with container log formatting (#9967)
* Fix bug with container log formatting

* Fix lint issue
2023-11-03 09:05:32 +00:00
Sean-McQ 5c2f28b4dc
this was a older line that got relocated up into the getSocketUrl method (#9462)
* this was a older line that got relocated up into the getSocketUrl method

* Fixes compiler warnings
2023-08-02 11:04:18 -04:00
Alexandre Alves 9462c5a817
fix issue with height on containerShell (#9448)
* fix issue with height on containerShell

* fix issue properly

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2023-07-31 11:46:19 +01:00
Neil MacDougall 02e6e84f41
When execing into a container, try linux and windows commands when we can't determine if the node is windows (#9241)
* When execing into a container, try linux and windows commands when we can't determine if the node is windows

* Fix lint

* Lint: Remove trailing white space

* Use error message rather than last error

* extra failover, caching last working os against pod, errors, tests

* add __mocks__ folders to eslint ignore patterns

* standard user test fix

* removed unnecessary try/catch logic

* Revert "removed unnecessary try/catch logic"

This reverts commit c263131927.

---------

Co-authored-by: Sean <sean.mchugh@suse.com>
2023-07-28 21:28:03 -04:00
Giuseppe Leo 01eeb0548f
Add recommended lint rules globally (#8997)
* Update configuration

* Create default config for eslint

* Restore plugin:vue/recommended

* Add exceptions and overrides

* Correct manually remaining issues

* Adding further picked exceptions groupped up

* Fix or disable specific cases manually and singularly

* Add naming linting exception

* Remove unused variable in component

* Move rules to default

* Autocorrect rancher/components linting issues

* Configure VSCode to use multiple files, to display linting for rancher components

* Disable jest lint hook restriction for string list component

* Autofix
2023-06-23 17:02:55 +02:00
Shavindra c1e3897792
Remove empty selector from prometheus. (#8889)
* Remove empty prometheus selector values from API request.
* Add E2E for Prometheus selector.
2023-06-01 20:13:33 +02:00
codyrancher 8147edf9df Add the ability to execute a container shell command immediately after the shell connects. 2023-05-25 21:52:29 +03:00
Bastian Hofmann d6bbae46a6
Fix multi select styling (#7843)
* Fix multi select styling so that the form field expands if not all items fit into a single line anymore.

Fixes https://github.com/rancher/dashboard/issues/7842

Signed-off-by: Bastian Hofmann <mail@bastianhofmann.de>

* Remove duplication in _select.scss

* Fix select heights in ContainerLogs, ContainerShell, ApplicationLogs and ApplicationShell components

Signed-off-by: Bastian Hofmann <mail@bastianhofmann.de>

Signed-off-by: Bastian Hofmann <mail@bastianhofmann.de>
2023-01-12 23:01:07 +00:00
Nancy Butler d4a9bef75c move stuff again 2023-01-09 10:48:42 -07:00
Nancy Butler 53774ce38c move harvester-mgr stuff 2023-01-09 10:48:42 -07:00
Francesco Torchia d2de096f14
xterm, align theme properties to version 5.x
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2023-01-03 17:12:42 +01:00
Francesco Torchia ae27f57eeb
Terminal, restrict drag&drop to tabs bar
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2022-12-16 17:10:27 +01:00
Francesco Torchia 9a093baa6c
Merge pull request #7666 from torchiaf/fix/7148
fix terminal crash
2022-12-14 11:10:49 +01:00
Francesco Torchia 53f9282841
Window Manager, fix bottom actions layout
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2022-12-09 16:24:58 +01:00
Francesco Torchia 4b12313b0d
fix terminal crash
- Bump version, xterm.js
- adapt new version to the Dashboard

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2022-12-09 11:48:59 +01:00