Commit Graph

46 Commits

Author SHA1 Message Date
codyrancher 3bf76256e7
Fixes an issue where workload yaml editors didn't show errors (#14846)
Fixes #14728
2025-07-25 09:11:26 -07:00
Alexandre Alves faa7fe3b60
A11y report fixes (#14530)
* fix item 2: All page content should be contained by landmarks

* fix item 4. Elements must only use permitted ARIA attributes

* fix item 6. ARIA attributes must conform to valid values

* fix bug on item 6. and fix item 7. <ul> and <ol> must only directly contain <li>, <script> or <template> elements

* fix item 8. Interactive controls must not be nested

* fix item 10. ARIA toggle fields must have an accessible name

* fix item 11. autocomplete attribute must be used correctly

* fix item 12. Form elements must have labels

* fix item 14. ARIA input fields must have an accessible name

* fix item 15. Buttons must have discernible text

* fix item 16. Images must have alternative text

* working on item 17

* finish fix item 17. ARIA role should be appropriate for the element

* fix wrong role in hidden inputs

* address pr comments
2025-07-10 10:09:09 +01:00
Cody Jackson b0d4deca70 Adds the new detail page TitleBar, Metadata and ResourceDetailDrawer to all of the resources by default 2025-06-25 08:00:15 -07:00
Phillip Rak 7a4b3930e9 Add an e2e test for adding containers to pods form
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-04-02 10:46:16 -07:00
Alexandre Alves 84c234383a
Fix textual descriptions for cluster appearance in multiple places (#13416)
* Fix textual descriptions for cluster appearance in multiple places

* address pr comments

* address pr comments
2025-02-24 09:00:54 +00:00
Phillip Rak badaff88fb Update name for pod storage tab
The `name` prop for tabs assigns an id to a `section` element in the underlying tab. Since ids must be unique in the document, there conflicts can arise when programmatically selecting tabs.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-12-03 12:08:34 -07:00
Nancy f28214f9c6
Vue3 fix workload storage (#12070)
* fix workload storage codemirror not rendering

* workload storage default component  yamleditor instead of codemirror

* test editing projected vols

* add container mount test

* fix lint

* refactor deployment tests to improve retry-ability

* add to workoad storage tests and improve retry
2024-10-03 15:00:34 -07:00
Nancy 5607114e5d
update all instances of LabeledInput using v-model.number to use v-model:value.number (#11902)
* update all instances of LabeledInput using v-model.number

* add probe http headers unit test

* add hookoption test

* remove codemirror focus change
2024-09-19 14:46:37 -07:00
codyrancher 3fde3d5144
Merge pull request #11964 from codyrancher/emits
Enabling `vue/require-explicit-emits` linting rule
2024-09-19 12:31:25 -07:00
Cody Jackson 5052c2a8e8 Enabling `vue/require-explicit-emits` linting rule
https://github.com/rancher/dashboard/issues/11961
2024-09-19 09:58:53 -07:00
Evgeniya Vashkevich 6f0b5935ff
Vue3: Fixed validation errors shown prematurely for Workload and Service forms (#11945) 2024-09-18 14:43:13 -07:00
Richard Cox db8f873d94 Remove breaking `template` from Workload Pod Resource tab 2024-09-06 17:41:58 +01:00
Cody Jackson 381e20ab15 Fixing data binding for image containers in workloads 2024-08-22 16:09:55 -07:00
Cody Jackson 9b829c55ea Ran `yarn lint --fix` 2024-08-22 16:05:36 -07:00
Cody Jackson d5ce4fff2e Run the vue3 migration script
Commands run:

➤ yarn migrate
➤ git clean -fdx
➤ nvm use 20
➤ yarn
2024-08-22 16:05:36 -07:00
Cody Jackson f2f014597c Removing prop mutation in v-model usage 2024-08-12 14:47:52 -07:00
Richard Cox 9a72508748 Add a tooltip to Workload image pull secret select
- This makes it clearer we only show certain types of secrets
2023-11-09 15:32:29 +00:00
Giuseppe Leo 01eeb0548f
Add recommended lint rules globally (#8997)
* Update configuration

* Create default config for eslint

* Restore plugin:vue/recommended

* Add exceptions and overrides

* Correct manually remaining issues

* Adding further picked exceptions groupped up

* Fix or disable specific cases manually and singularly

* Add naming linting exception

* Remove unused variable in component

* Move rules to default

* Autocorrect rancher/components linting issues

* Configure VSCode to use multiple files, to display linting for rancher components

* Disable jest lint hook restriction for string list component

* Autofix
2023-06-23 17:02:55 +02:00
Phillip Rak ade3c9f4e7 Replace all instances of `v-tooltip` with `v-clean-tooltip`
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2023-05-18 15:39:14 -07:00
Alexandre Alves 7b0ddb522a
invalid error handling creating workload (#8263)
* change condition to check if buttons for scale up/scale down deployment are enabled

* revert changes

* fix error handling

* address PR comments

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
2023-02-27 10:12:12 +00:00
Richard Cox 80e5c4f304 Fix broken workload `Add Container` button
- Also fixed text flush to icon
2023-02-03 13:51:18 +00:00
Phillip Rak fe58a9075c
Merge pull request #7990 from catherineluse/ingress-service-text
Add text to help with Services and Ingresses
2023-01-27 15:45:10 -07:00
Giuseppe Leo 7d699742fc
Home page not load in safari: positive lookhead unsupported (#8029)
* Add generic Workload view tests for error mapping

* Replace regular expression for supported browsers cases
2023-01-26 21:35:30 +01:00
Catherine Luse 1d885b8588 Add text to help with Services and Ingresses 2023-01-21 22:51:28 -07:00
Giuseppe Leo e03f28358d
Add support for Pod Security Admission in the Clusters and Workloads (#7787)
* Add PSA template dropdown to RKE2 cluster editor

* Add tests for RKE2 custom cluster editor to display options for PSA

* Remove TODO and hardcoded value for k8s PSA 1.25+

* Allow CRU editor to have error maps

* Fix linting on destructured arrays for unused values in Workloads erorr map

* Allow to change PSP and reset values accordingly

* Correct banner HTML for reprovisioning

* Replace default term with none in cluster creation policies

* Replace PSA ID with Name for the template in the cluster creation

* Remove extra condition for PSA options

* Add i18n with separated values for RKE default optins

* Restore default option for no PSP template in RKE2
2023-01-20 16:27:30 +01:00
LiuYan 8b559b1e97
fix(workload): fix duplicate add containers (#7400) 2023-01-13 09:52:38 +00:00
richa c792d21dd9
Fixed icon size (#7557)
* Fixed icon size

* Add node inactive warning indicator (#7548)

* StringList, delete item on editing

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Bump @rancher/components version

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Add manage button to home page (#7546)

* Add manage button to home page

* Fix button spacing

* Make buttons smaller - looks better with extra button

* Fixed icon size in simplebox

* icon fix in GrowlManager.vue

* Add node inactive warning indicator (#7548)

* StringList, delete item on editing

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Bump @rancher/components version

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Add manage button to home page (#7546)

* Add manage button to home page

* Fix button spacing

* Make buttons smaller - looks better with extra button

* Fixed close icon size

* Fixed more icons sizes

* Fixed icon size in namespaces filter

* Reverd css changes in LabeledSelect component

* Fix on Header

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
Co-authored-by: Francesco Torchia <francesco.torchia@suse.com>
Co-authored-by: Richa Bisht <RBISHT@Richas-MacBook-Pro.local>
2022-12-08 16:52:53 +01:00
LiuYan f25957055e
fix(workload): select the newly added sidecar tab (#7403) 2022-12-05 09:10:23 -08:00
Phillip Rak 3d410d0974 Apply linter auto-fixes
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2022-11-16 18:38:20 -07:00
Giuseppe Leo d2d4122bc0
Review HTML formatting rules (#6805)
* Prevent ESLint to format generated paths

* Add HTML ESLint Rules

* Format all the Vue HTML templates except Harvester

* Exclude Harvester package from linting HTML, keeping old formatting rules
2022-11-11 17:04:22 +01:00
Giuseppe Leo 09b4e9580f
Replace styling with explicit configuration for flat cases as in nested tabs (#7136) 2022-10-10 23:36:18 +02:00
Shavindra 7fd3a742fe
Edit labels and annotations. (#7105)
* Edit labels and annotations.
2022-10-10 14:02:18 +02:00
Shavindra e94b5a26ba
Prevent blocking effect secondary resources on workloads (#6860)
* move secondary data requests to a non-blocking ui method + pass loading props to the correct labeled selects

* main data loading procedure for secondary data done

* use pvcs from secondary resource fetch on storage component

* rename loading props to asyncDataLoading for better context

* cleanup

* move secondary resources data loading logic to a mixin

* cleaning up resource-manager mixin

* fix issue where namespace  wasnt being updated on secondary requests

* add doc description for data structure for resourceData

* minor change

* add plural option to resource-manager + remove loading var from workloads for sec resources + optimise persistentvolume edit view

* improve persistentvolumeclaim edit view

* add loading flag

* addressing PR comments

* fix latest PR comments

* doc on classify option for resourceManagerFetchSecondaryResources param

* Ensure reponse for namespace resources mimics non-namespaced
- The resources returned when requesting namespaced types do not contain id, type and links properties.
- This isn't perfect, or universally applicable, but will work for the current set of use cases

* working on merge conflicts

* Remove files from bad merge

* Handle new namespaces
- The secondary resource manager fetches some resources by namespace
- The user however can supply a new namespace
- When in `new namespace` mode we need to
  - avoid trying to fetch namespaced resource
  - clear any cached namespaced resource
- this only currently applies to workloads, PV and PVC pages don't fetch namespaced resources

Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
Co-authored-by: Richard Cox <richard.cox@suse.com>
2022-10-09 10:40:32 +01:00
Shavindra 447fe42cc4
Workload page updates (#7041)
Fixes #6800 - Workload storage mount point for volumes should be on containers
Fixes #7021 - Allow user to change the volume name
Fixes #7027 - Pod details page broken

These all works on 2.6.9 because PRs were merged after the branch separation. So this is applying the same changes to 2.7.0

For Release 2.6.9
#6800 -> release 2.6.9 PR fix #6886
#7021 -> release 2.6.9 PR fix #7022
#7027 -> release 2.6.9 PR fix #6952
2022-09-30 01:43:07 +02:00
Shavindra 0980ba4687
fix(workload): fix some forms are not updated when switching container tabs (#6841) 2022-09-12 11:11:16 +02:00
huacheng-git 681be22a2f
fix(imagePullSecrets): Fix the contents of the drop-down option (#6733)
Co-authored-by: huacheng <cheng@HuachengdeMacBook-Pro.local>
2022-09-12 10:09:32 +01:00
LiuYan eb0c53e941 fix(workload): fix some forms are not updated when switching container tabs 2022-09-09 15:58:56 +08:00
Shavindra 35c51c7f47
Improve workload screens - #6455 (#6632)
* Make container tabs horizontal.

* Update cronjobs, DaemonSets, Jobs, StatefulSets to use same Workload component.

* Fix 6755 - Wrong sidecar config edit not shown in UI.

* Set Persistent Volume claim capacity as required.
2022-09-02 18:12:31 +02:00
Shavindra 2047f74c92
Improve Deployment creations screen - #5734 (#6214)
* Improve workload deployments view.
2022-07-22 18:04:53 +01:00
Sean ddab180ecc Adds in form validation mixin, error reporting on inputs, a few examples 2022-07-07 13:18:43 -04:00
Richard Cox 371a7ab17f Only show field for `spec.serviceName` for StatefulSets
- This previously matched the original check for both isReplicable && isStatefulSet
- These work off of the `type` field which does not overlap between types
- It looks like the field `spec.serviceName` is only application to type StatefulSets
  - see https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.22/#statefulset-v1-apps
2022-06-14 09:44:24 +01:00
Richard Cox c8549c0d56 Align margin bottom of NameNsDescription and workload field rows
- Also ensure row (with margin) only shows when it has to
2022-06-13 12:52:28 +01:00
Richard Cox f70e512b89 Fix visibility of Replicase field
- Currently not shown for deployments
- Change to match original replaced code
  ```
      if (this.isCronJob) {
        out.push('schedule');
      } else if (this.isReplicable) {
        out.push('replicas');

        if (this.isStatefulSet) {
          out.push('service');
        }
      }
   ```
  (Not quite sure on the service clause, but it matches original functionality)

Also reduced size to align with components above
2022-06-13 12:44:38 +01:00
Catherine Luse 8709f99ba7 Can select or create a namespace in create resource forms 2022-06-02 19:49:16 -07:00
Phillip Rak 72b36cb360
Create Rancher Component Library (#5504)
This adds a new project for Rancher Components under `pkg/rancher-components` and replaces components used throughout dashboard with the versions used here. All imports for the following components have been updated:

```
  |- BadgeState.vue
  |- Banner.vue
  |- Card.vue
  |- Form
    |- Checkbox.vue
    |- LabeledInput.vue
    |- LabeledTooltip.vue
    |- RadioButton.vue
    |- RadioGroup.vue
    |- TextAreaAutoGrow.vue
```
2022-05-24 15:09:53 -07:00
Richard Cox 25acc1f8eb Plugins: Rejig files to new shell locations (#5623)
* Doc

* v0.7.0

* v0.7.1

* v0.7.2

* Add creators

* v0.1.14

* v0.1.17

* Add Yarn link

* Tidy ups and typos

* Allow models to be loaded from plugins

* v0.1.15

* v0.1.18

* v0.6.6

* Improve readme, fix cyperss log msg

* v0.1.17

* v0.1.19

* v0.6.7

* v0.6.8

* Fix logo ref when in shell

* Fix lint issues

* Fix error in example

* Fix script to work on linux

* Add ability to revert moves without losing changes

* Fix bug with custom models in a plugin

* Fix build of UI packages

* Add dist-pkg to .eslintignore

* Pull out util from extend-router to prevent router being pulled in UI packages

* Update PLUGINS.md

* Remove duplicate dependency

* Reduce size of built UI packages

* Share codemirror. Other tidy ups

* Further improvements

* Tidy ups to support i18n in plugins

* Clen up add comments

* More clean-ups and comments added

* Rename from extension to plugin

* Missed file in rename

* v0.6.9

* TIdy ups following rename

* v0.1.20

* v0.1.21

* More refactor and tidy up

* v0.1.22

* v0.1.18

* v0.1.19

* v0.1.23

* v0.6.10

* Version Packages. Improve naming. Unload.

* v0.6.11

* v0.1.20

* v0.1.21

* v0.1.24

* v0.6.12

* v0.1.25

* v0.1.22

* v0.6.13

* Fix issues when plugin is builtin

* Add missing files

* Fix lint issues and watcher ignores

* Fixes following review

* v0.1.28

* v0.1.31

* v0.6.20

* Fix coer.js version

* Fix bug where plugins included via npm don't work

* Changes post merge

* Move plugins doc to dev guide, add note at top of README

* Update cypress version

* Add note about the reset --hard in rejig -d

* Fixes post merge

* Rename @ranch to @rancher and ad plugins

* Improve routes support, add package assets support

* Add uninstall hooks and pass interal opts

* Fix rejig script

* Minor fixes

* Routing tweaks
- attempted to improve `addRoutes` typing, failed a lot
- improved typings in plugins.ts
- added "@pkg/*" entry and vue-shim (for importing components) to the pkg creator
- fixed some linting
- safely fail when Verdaccio isn't running
- fixed some typos

* Remove frontmatter-markdown-loader reference from nuxt-config

* Revert "Remove frontmatter-markdown-loader reference from nuxt-config"

This reverts commit 29ef6f2f7b.

* Exclude creators from dashboard build

* Revert "Exclude creators from dashboard build"

This reverts commit 8ede93ee7c.

* Ingore creators via tsconfig
- We're still susceptible with vue shims in multiple packages
- Need to determine why packages can't use shim from route
- Probably need to move `./vue-shim.d.ts` in to `./shell`. Needs testing with a pkg that imports a component

* After rejig

Co-authored-by: Neil MacDougall <nmacdougall@suse.com>
Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
2022-05-10 10:04:02 +01:00