mirror of https://github.com/rancher/dashboard.git
5 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
Richard Cox
|
a90029638a
|
Re-enable vai support for side nav and home page cluster lists (#15262)
* generic changes from https://github.com/rancher/dashboard/pull/14492/files * VERY WIP - move out watch event stuff into own file - improve typing - start resolving core unwatch & unwatchIncompatible of side nav cluster watches (not going to store) being seen as incompatible with find cluster action that does go into store * very wip, vaguely working * starting to tidy up * more tidying * wip - pre-pivot * maybe... instead of upfront unwatch with lots of complicated logic... only do it if we hit the issue (i.e. no page entry into page ) * tidying up * asd * Remove now uneeded sideNavCache * big refactor, untested * tidying up * tidying * more tidying * more tidying * add some super basic unit tests, fix another * remove debug logger and last todos * more unit test fixes * Fix two bugs, and fix e2e tests - we don't always have the mgmt cluster, so take this into account - i've checked all usages of `['management/byId'](MANAGEMENT.CLUSTER` * more e2e fixes * Tidying up following review - more comments - rename of method to something more sensisble * Disable support for ssp in side bar and clusters |
|
|
Richard Cox
|
1c402501d2
|
Improve support with Vai on and Rancher HA - Lite (#15134)
* wip * tests - wip * wip - tidying * wip * wip * tweaks * fix and expand sub tests * backoff tests * tidying up * more tidying up * WIP * address backoff find wiping findPage res after nav from detail to list * add more docs * fixes * comments and logs updates * remove debug |
|
Giuseppe Leo
|
01eeb0548f
|
Add recommended lint rules globally (#8997)
* Update configuration * Create default config for eslint * Restore plugin:vue/recommended * Add exceptions and overrides * Correct manually remaining issues * Adding further picked exceptions groupped up * Fix or disable specific cases manually and singularly * Add naming linting exception * Remove unused variable in component * Move rules to default * Autocorrect rancher/components linting issues * Configure VSCode to use multiple files, to display linting for rancher components * Disable jest lint hook restriction for string list component * Autofix |
|
Sean-McQ
|
e256669e74
|
cluster and rancher stores now use advanced worker (#8717)
* cluster and rancher stores now use advanced worker * Addressing feedback * addressing PR feedback and unit tests * Fixed sticky footer in Helm Chart Install Yaml (#8497) * Remove dependency: nuxt Signed-off-by: Francesco Torchia <francesco.torchia@suse.com> * Remove dependency @nuxt/types Signed-off-by: Francesco Torchia <francesco.torchia@suse.com> * fix lint Signed-off-by: Francesco Torchia <francesco.torchia@suse.com> * Remove dependency: @nuxt/typescript-build Signed-off-by: Francesco Torchia <francesco.torchia@suse.com> * Remove dependency: @nuxtjs/eslint-module Remove dependency: @nuxtjs/proxy Remove dependency: @nuxtjs/style-resources Signed-off-by: Francesco Torchia <francesco.torchia@suse.com> * align package.log Signed-off-by: Francesco Torchia <francesco.torchia@suse.com> * Storybook, add vue-loader dependency Signed-off-by: Francesco Torchia <francesco.torchia@suse.com> * Added placeholder in url input (#8036) * Added placeholder in url input * Added format checker for Url input * Update test * Fixed lint * Fixed breaking for other providers * Fixed lint * Update vue options to preserve whitespace (#8742) * Update vue options to preserve whitespace * Bug fix with tidy-up * Fix response times for multiple clusters (#8720) * Update extensions publish workflow for assets in gh-pages branch (#8618) * Update extensions workflow to move assets into gh-pages branch Fix gh-pages check * Move bundle execution - add default basename and ext version * Fix basename op * PR changes * [v2.7] Update Chinese translation (#8731) * Upgrade to Vue 2.7 (#8654) * upgrade @vue/cli-xxx * Update Vue to latest 2.7 * Update eslint-plugin-vue * Disable new linting rules * Remove linting issue * Pin Dom purify library version * Add resolution to avoid conflicts with packages * Update yarn/lock after the enforced resolution * Exclude node 16 types resolution * Fixed extra space bug in the generic cluster-page (#8626) * Fixed extra space bug in the generic cluster-page * Fixed space issue in banner * Revert changes * Removed extra div * Fixed selected rows counter (#8419) * Fixed selected rows counter * Fixed lint * Fixed counter in selection.js * Small fix in toAdd condition * Lints * Fixed condition for selected row counter * Changes in focusAdjacent function * Fixed lints * Improve OPA Gatekeeper constraint detail page (#8586) This adds the following functionality to the violations list on the OPA Gatekeeper constraint detail page: * Add a namespace column to the violations * Make the violations list searchable * Allow to download the violations as a CSV, similar to CIS scanner violations Signed-off-by: Bastian Hofmann <mail@bastianhofmann.de> * Increase memory on build (#8751) * Remove extension autoLoad functionality (#8700) * fix(BrandImage): remove async fetch method (#8432) * Removed hasClass method (#8752) * Removed hasClass method * Clean code * Two minor tweaks - supported store types now a const - WORKERMODES --> WORKER_MODES * Fix two bugs - Ensure advanced worker runs in cluster manager with no current cluster context - Ensure `resource.stop` from advanced worker successfully kicks off watch Also - make rancher, managment and cluster store names a const * Tweaks - Fix some comments (jsdoc --> standard, todos) - Made the web worker redispatch requirement clearer * Fix unit tests * Fix resource.stop / resource.error TOO_OLD bugs - Persist watcher error state after resource.stop - this will ensure the resource.stop given alongside the resource.error TOO_OLD is ignored - Ensure any errors are cleared when we succesfully connect (given above) - Should fix the next resource.stop being ignored after recovering from TOO_OLD - Fix resync watch params - these weren't correct, so the resync after TOO_OLD never worked - the format could be slimmer, but i thinkg it matches how other socket's data works Note - I manufactored the TOO_OLD by setting a revision of 1 in subscribe resource.stop if it came from the advanced worker --------- Signed-off-by: Francesco Torchia <francesco.torchia@suse.com> Signed-off-by: Bastian Hofmann <mail@bastianhofmann.de> Co-authored-by: richa <richa.bisht@suse.com> Co-authored-by: Francesco Torchia <francesco.torchia@suse.com> Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com> Co-authored-by: Jordon Leach <40806497+jordojordo@users.noreply.github.com> Co-authored-by: vickyhella <vickyhella@hotmail.com> Co-authored-by: Giuseppe Leo <giuseppe.leo@suse.com> Co-authored-by: Bastian Hofmann <mail@bastianhofmann.de> Co-authored-by: LiuYan <361112237@qq.com> Co-authored-by: Richard Cox <richard.cox@suse.com> |
|
|
Sean-McQ
|
ca1b810c7b
|
Moves sockets into the advanced worker (#7760)
* Moves sockets into the advanced worker
* worker can die peacefully now, making switching between cluster work.
* Make waitFor generic, wire in to waitForTestFn
* General Changes
- Fixes for switching cluster
- includes using common getPerformanceSetting
- avoid new code to unsub before socket disconnect
- handle `watch` `stop` requests
- lots of TODO's (questions, work, checks, test, etc)
- use common
* Switch socket fixes
- isAdvancedWorker should only be true for cluster store
- advancedWorker to be wired in
* Fix socket id for cluster workers
- sockets use an incremented local var for id
- when we nuke the socket file within the worker this resets, so they all ahve id of 1
- work around this by applying the unix time
* Fix handling of new partical counts response
- seen in dex cluster explorer dashboard
- count cards would be removed when partial counts response received
* Make resourceWatcher the sole location for watch state
- getters canWatch, watchStarted now are worked around (they look at state in the UI thread)
- we now don't call resource.stop or restart.start in subscription
- tidied up `forgetType`
- moved clearFromQueue from steve mutations into subscription mutations (better location)
- added and removed some TODOs
- fixed watch (stop handler should be higher up, include force watch handling)
* pushes the csrf value into worker and adds it to fetch request headers.
* refactors batchChanges to address ref concerns and be more performant
* Maintain schema reference whilst updating
- This change mutates input in a function, which is bad...
- but ensures the reference isn't broken, which is needed to maintain similar functionality as before
* Fix waitForTestFn
- Seen when creating or viewing clusters
* On unwatch ensure any pending watch requests are removed from the queue
- the probably would have been a problem if the worker wasn't nuked
- however as the codes there lets make it safe
Also added `trace` feature in advanced worker, will probably bring out to other places as well
* Fix navigation from cluster manager world to any cluster
- Ensure that we handle the case where the advanced worker was created but the resource watcher wasn't
- ... but fix case where this was happening (aka ensure that a blank cluster context is ignored)
* Tidy some TODOs
* Add perf settings page
- This will help test normal flow (when advanced worker is disabled)
- Note - setting is now in a bag. This may help us better support further settings (enable client side pagination, etc)
```
advancedWorker: { enabled: false },
```
* FIX - Nav from cluster dashboard --> specific event --> cluster dashboard and events not re-subbed
- Ensure we block default handling of resource.start (keep state in resource watcher)
* Tidying up some TODOs
* Adds in a cache and uses it to validate SCHEMA messages before batching.
* Forgot to actually save CSRF to the resourceWatcher when instantiated.
* an empty resource in a batchChange to signal remove
* Move addSchemaIndexFields to and created removeSchemaIndexFields in new file
- this avoids bringing class files into the worker
* Fix disconnect/reconnect
- Remove `syncWatch` (do the watch/unwatch straight away)
- Test/Fix re-sub on reconnect
- Test/Fix growls on disconnect
* Tidying up some TODO's
- including clean of workerQueue on resource.stop (this is SUPER defensive)
* batchChanges will now handle aliases
* Fix pods list - WIP
- ensure podsByNamespace is updated on batchChange
TODO
- the final update to the pod is ignored
- removing a namespace cleans the cache correctly
- disabling advanced worker still works
* Fix pods list - fixes
- ensure podsByNamespace is updated on batchChange
Tested / Fixed
- the final update to the pod is ignored
- removing a namespace cleans the cache correctly
- disabling advanced worker still works
* Tidying TODOs
* Remove default same-origin header
- https://developer.mozilla.org/en-US/docs/Web/API/Request/credentials
* Fixed TODO description
* Refactor subscribe, make it clear which vuex feature relates to what
* Lots of Fixes
- batchChanges fixes
- fix index is 0 issues (!/!!index)
- only `set` if we have to
- ensure we set the correct index after pushing to list
- ensure map is updated after reducing list size with limit
- podsByNamespace fixes
- ensure when ew replace... we don't use the same referenced object
- general service resource fixes
- ensure service's pods list stays up to date with store
* Multiple improvements/fixes
- resourceCache - store the hash instead of the whole object. This means longer load time be reduces memory footprint
- resourceWatcher
- don't re-sub on socket reconnect if watcher is in error
- don't sub if watcher is in error
- don't unwatch for 'failed to find schema' and 'too old' errors
- this clears the error, we won't to keep it to ensure we don't watch
- Remove #5997 comments, follow on work #7917
* toggle debug, remap alias types, cleaned up comments and console
* Unit tests for batchChanges
Much more scope for some crazy content
* Logging tweaks
- disable logging by default
- initWorker comes in too late to affect initial trace, so just rely on the `debug` to toggle at runtime
Co-authored-by: Richard Cox <richard.cox@suse.com>
|