- Basically, don't auto-select first group entry if we're already expanded
- covers cases where group is pseudo expanded (root, always open)
- this removes almost all nav warnings
- Tested
- Auth and Settings products (top level, no visual group root)
- auth providers double click
- cluster explorer all sections ('More Resource' doesn't autoselct as before)
- cluster manager embedded pages
- resource search (on click this doesn't auto-expand host group as before)
- Core Problem
- Type component selects an item in the side menu... which then fires off groupSelected in Groups component
- Group component groupSelected then replaces route with first item in group, regardless of the route Type that was just selected
- Page however still stays on the Type's route and not what the $route now thinks is the current one
- This leads to all sorts of errors when clicking around types in a group
- Problem from Issue #3989
- There is a guard in Type that normally prevents the groupSelected from firing if you're on the same page
- However for the auth provider, where we change the route to a configured provider on click, this compares '/c/local/auth/config' with '/c/local/auth/config/github'
- This means we try to change the page, and GlobalLoading somehow gets stuck (we never receive the `finish` call, or even `failure` - https://nuxtjs.org/docs/2.x/features/loading#using-a-custom-loading-component
- Fix
- Fixed for this specific issue by avoiding groupSelected when the group is the root (which means it's not a true group where the first should be selected)
- This fixes the error, but also the error logs for the auth and setting products
- This does not fix the error logs in groups where it's not root
- Future Fix?
- Break the link between Type select and Group groupSelected. I have a feeling this is very situational and to do with automatic selection rather than user clicking on a specific type
Port the Ember Version Modal
- Previously this was reached via clicking on the version text in the footer, now it's reached via the user menu top right
- This also previously was a modal whereas now it's a page as per other user menu items
Minor Changes
- i10n - User menu text
- Fix - Size of side menu's group menu down arrow now fills menu hover area (no more thin hover colour below down arrow when in dark mode)
- Fix - Cluster Dashboard - Hide metrics Tabbed element if there are no Tabs (no more empty faded square at bottom when no metrics)
- Update support links
- Home Page - Commercial Support - Link now goes to support page
- Support Page - Contains links to both rancher support info and contact pages