- Basically, don't auto-select first group entry if we're already expanded
- covers cases where group is pseudo expanded (root, always open)
- this removes almost all nav warnings
- Tested
- Auth and Settings products (top level, no visual group root)
- auth providers double click
- cluster explorer all sections ('More Resource' doesn't autoselct as before)
- cluster manager embedded pages
- resource search (on click this doesn't auto-expand host group as before)
- Core Problem
- Type component selects an item in the side menu... which then fires off groupSelected in Groups component
- Group component groupSelected then replaces route with first item in group, regardless of the route Type that was just selected
- Page however still stays on the Type's route and not what the $route now thinks is the current one
- This leads to all sorts of errors when clicking around types in a group
- Problem from Issue #3989
- There is a guard in Type that normally prevents the groupSelected from firing if you're on the same page
- However for the auth provider, where we change the route to a configured provider on click, this compares '/c/local/auth/config' with '/c/local/auth/config/github'
- This means we try to change the page, and GlobalLoading somehow gets stuck (we never receive the `finish` call, or even `failure` - https://nuxtjs.org/docs/2.x/features/loading#using-a-custom-loading-component
- Fix
- Fixed for this specific issue by avoiding groupSelected when the group is the root (which means it's not a true group where the first should be selected)
- This fixes the error, but also the error logs for the auth and setting products
- This does not fix the error logs in groups where it's not root
- Future Fix?
- Break the link between Type select and Group groupSelected. I have a feeling this is very situational and to do with automatic selection rather than user clicking on a specific type
- This also fixes the blip when drop down is open and the selected value is clicked on again
- Investigated other fixes...
- slot'ing a new open indicator in (doesn't handle clickes)
- using document.activeElement (already set away from drop down)
- this.raised (not applicable in some cases)
[master] Add more width to protocols dropdown
This adds a little more spacing to the protocol column by increasing the width to 90px. This also adds the col class to the labeled selects in order to satisfy the requirements for the style that defines minimum height.
#3662
- on auth/logout ensure the iframe is removed instead of waiting for the timer
- solution probably over implemented, but wanted to ensure timer is also cleared on logout
- Non-admin create was blocked (create button disabled) given their lack of rights to the binding type
- When non-admins create their project they get this binding automatically, so count case as valid
Also
- Disable remove of a member binding if there is only one user
- covers case where a non-admin can remove themselves when editing their project and not re-add
- Previously nav away was occurring inside `this.save` before we could wait for the mgmt cluster
- This meant some info was missing when we arrived at the next page
- So move wait and role change into after hook and rely on native nav in this.save again
Richard Cox
Richard Cox
Vincent Fiduccia
Jordon Leach
reemus
Cody Jackson
Nancy
codyrancher
Phillip
Phillip Rak
Neil MacDougall
Neil MacDougall