- Basically, don't auto-select first group entry if we're already expanded
- covers cases where group is pseudo expanded (root, always open)
- this removes almost all nav warnings
- Tested
- Auth and Settings products (top level, no visual group root)
- auth providers double click
- cluster explorer all sections ('More Resource' doesn't autoselct as before)
- cluster manager embedded pages
- resource search (on click this doesn't auto-expand host group as before)
- Core Problem
- Type component selects an item in the side menu... which then fires off groupSelected in Groups component
- Group component groupSelected then replaces route with first item in group, regardless of the route Type that was just selected
- Page however still stays on the Type's route and not what the $route now thinks is the current one
- This leads to all sorts of errors when clicking around types in a group
- Problem from Issue #3989
- There is a guard in Type that normally prevents the groupSelected from firing if you're on the same page
- However for the auth provider, where we change the route to a configured provider on click, this compares '/c/local/auth/config' with '/c/local/auth/config/github'
- This means we try to change the page, and GlobalLoading somehow gets stuck (we never receive the `finish` call, or even `failure` - https://nuxtjs.org/docs/2.x/features/loading#using-a-custom-loading-component
- Fix
- Fixed for this specific issue by avoiding groupSelected when the group is the root (which means it's not a true group where the first should be selected)
- This fixes the error, but also the error logs for the auth and setting products
- This does not fix the error logs in groups where it's not root
- Future Fix?
- Break the link between Type select and Group groupSelected. I have a feeling this is very situational and to do with automatic selection rather than user clicking on a specific type
- Normally this is the local cluster for admins
- For non-admins (restricted-admins, standard users, etc) who don't have access to the local cluster this causes this causes 403 errors
- So for cases where we don't have a cluster default to a 'blank' one which we don't fetch
- Still need to check places where we assume 'local' cluster, including in routes, where we should use the new blank cluster... and pages/components that assume we have a currentCluster
- for resources in error or transitioning states show the associated message underneath the row
- message is placed as default content in list's sub-row (currently only used for cis reports)
- also allow override of resource state object used to determine resource state and state message
- only used in provisioning cluster to swap state with management cluster if not rke2
- this will be reverted once backend correctly syncs state of legacy/rke1 clusters correctly
Also fixed indentation of unconnected clusters in side nav
Richard Cox
Vincent Fiduccia
Nancy Butler
Neil MacDougall
Richard Cox
Neil MacDougall
Neil MacDougall
Westly Wright
codyrancher
Cody Jackson
Neill Somerville