Commit Graph

34 Commits

Author SHA1 Message Date
Evgeniya Vashkevich 6f21443dd4
[2.12.1] Fixed Harvester detail page access through Cluster Management (#15059) 2025-08-05 14:54:47 -07:00
codyrancher 63d2bccaa1
Fixing a couple issues around the ResourceDetailDrawer and Harvester while giving the option to disable the drawer and/or the config tab for a resource (#14782)
Fixes #14718
2025-07-13 07:46:51 -07:00
Alexandre Alves faa7fe3b60
A11y report fixes (#14530)
* fix item 2: All page content should be contained by landmarks

* fix item 4. Elements must only use permitted ARIA attributes

* fix item 6. ARIA attributes must conform to valid values

* fix bug on item 6. and fix item 7. <ul> and <ol> must only directly contain <li>, <script> or <template> elements

* fix item 8. Interactive controls must not be nested

* fix item 10. ARIA toggle fields must have an accessible name

* fix item 11. autocomplete attribute must be used correctly

* fix item 12. Form elements must have labels

* fix item 14. ARIA input fields must have an accessible name

* fix item 15. Buttons must have discernible text

* fix item 16. Images must have alternative text

* working on item 17

* finish fix item 17. ARIA role should be appropriate for the element

* fix wrong role in hidden inputs

* address pr comments
2025-07-10 10:09:09 +01:00
Alexandre Alves 116e8c41ff
Fix scrolling issue (#14739)
* remove hash usage as we cannot prevent the scrolling with scrollbehaviour of vue-router

* proper fix

* proper fix now
2025-07-09 09:35:00 +01:00
Cody Jackson b0d4deca70 Adds the new detail page TitleBar, Metadata and ResourceDetailDrawer to all of the resources by default 2025-06-25 08:00:15 -07:00
Alexandre Alves 904cf072c8
reconnect resource to Tabbed component via resourceTabs (#14357) 2025-05-16 17:17:19 +01:00
Alexandre Alves 6ca778b991
fix tab component keyboard navigation (#13439)
* fix tab component keyboard navigation

* address pr comments

* improve tabs focused state
2025-02-21 08:52:41 +00:00
Alexandre Alves 0c411e96d3
Keyboard nav for extensions main screen (#13176)
* working on focus trap composable

* working on slide in panel refactor

* add change so that we dont have a change on the component diff

* fix slidein extension details panel key nav

* fine tune cluster badge trigger btn

* finish work on extensions page

* fix lint errors

* address pr comments

* fix problems of propagation

* update return focus for some modals in the extensions main screen

* remove dead code + fix focus selector return for add extensions repo and developer install modals
2025-02-11 10:47:55 +00:00
Alexandre Alves 13496483fe
keyboard navigation for cluster badge appearance modal (#13021)
* working on key nav for cluster badge appearance

* color input is now key nav friendly + tooltip works on focus + trying to get focus trap to work properly

* remove console logs + add focus trap to card component with prop control + fix element for config badge button

* fix lint problem

* fix TS errors on pkg build

* remove step of building the skeleton app in the check-plugins-build step, which imo doesnt serve any purpose whatsoever

* add focus-trap as a shell dependency + revert publish script change

* remove focus-trap directive + improve chaining event handler modifiers

* pin focus-trap to 7.6.2 + replace link for button on cluster explorer main page + remove unused ev

* address pr comments
2025-01-24 09:33:00 +00:00
Alexandre Alves 8698cb8dd1
Fix Unable to add extension tab to Edit Storage Class page (#12886)
* first iteration to improve extension point for tabs (missing default mode = VIEW)

* add default _DETAIL for the extension tabs extension point so that they are not added to EDIT views as well, unless specified otherwise

* revert harvester change
2024-12-26 12:08:12 +00:00
Cody Jackson 5052c2a8e8 Enabling `vue/require-explicit-emits` linting rule
https://github.com/rancher/dashboard/issues/11961
2024-09-19 09:58:53 -07:00
Cody Jackson 9ba44490ad Updated how we access currentRoute inside Tabbed component
We may want to investigate further why we have to access it using ._value. This most likely should've been taken care of inside entry.js
2024-08-22 16:09:55 -07:00
cnotv 3a3c849b21 Fix all the :key binding issues 2024-08-22 16:07:03 -07:00
Cody Jackson 26218b1dc3 Fixed a problem where we had :key twice in the tabbed component 2024-08-22 16:07:03 -07:00
Cody Jackson 9b829c55ea Ran `yarn lint --fix` 2024-08-22 16:05:36 -07:00
Cody Jackson d5ce4fff2e Run the vue3 migration script
Commands run:

➤ yarn migrate
➤ git clean -fdx
➤ nvm use 20
➤ yarn
2024-08-22 16:05:36 -07:00
Richard Cox 9ac5e32a4a e2e tests for certificates page 2024-05-07 17:25:35 +01:00
Alexandre Alves 764fa6087d
add e2e tests for #10389 and #9926 (#10745)
* add e2e tests for #10389 and #9926

* disable eslint for massive blueprint schema file

* fix e2e test issue + sneaky improvement for carousel unit test

* uncomment missing e2e test

* simplify schemas data and logic to generate a V2 monitoring on a local cluster for e2e tests

* minor code cleanup
2024-04-10 08:41:18 +01:00
Alexandre Alves 7fce213bd8
Fix chart installation question groups are "None" if there is only 1 group defined (#10203)
* fix issue where if tabbed=multiple and only 1 group would show a tab called None

* create flag to hide tabs if there is only one group in questions + add e2e tests to verify questions tabs

* update v-if condition

* change chart install page from Epinio to NeuVector

* address pr comments

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
2024-01-04 19:02:19 +00:00
Giuseppe Leo 01eeb0548f
Add recommended lint rules globally (#8997)
* Update configuration

* Create default config for eslint

* Restore plugin:vue/recommended

* Add exceptions and overrides

* Correct manually remaining issues

* Adding further picked exceptions groupped up

* Fix or disable specific cases manually and singularly

* Add naming linting exception

* Remove unused variable in component

* Move rules to default

* Autocorrect rancher/components linting issues

* Configure VSCode to use multiple files, to display linting for rancher components

* Disable jest lint hook restriction for string list component

* Autofix
2023-06-23 17:02:55 +02:00
Shavindra c1e3897792
Remove empty selector from prometheus. (#8889)
* Remove empty prometheus selector values from API request.
* Add E2E for Prometheus selector.
2023-06-01 20:13:33 +02:00
Phillip Rak ade3c9f4e7 Replace all instances of `v-tooltip` with `v-clean-tooltip`
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2023-05-18 15:39:14 -07:00
Alexandre Alves 6516e094b8
Extensions enhancements (#7777)
* add extensions API methods
---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
Co-authored-by: Alexandre Alves <aalves@Alexandres-MacBook-Pro.local>
Co-authored-by: Neil MacDougall <nmacdougall@suse.com>
Co-authored-by: Richard Cox <richard.cox@suse.com>
2023-02-09 10:58:29 +00:00
richa c792d21dd9
Fixed icon size (#7557)
* Fixed icon size

* Add node inactive warning indicator (#7548)

* StringList, delete item on editing

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Bump @rancher/components version

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Add manage button to home page (#7546)

* Add manage button to home page

* Fix button spacing

* Make buttons smaller - looks better with extra button

* Fixed icon size in simplebox

* icon fix in GrowlManager.vue

* Add node inactive warning indicator (#7548)

* StringList, delete item on editing

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Bump @rancher/components version

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Add manage button to home page (#7546)

* Add manage button to home page

* Fix button spacing

* Make buttons smaller - looks better with extra button

* Fixed close icon size

* Fixed more icons sizes

* Fixed icon size in namespaces filter

* Reverd css changes in LabeledSelect component

* Fix on Header

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
Co-authored-by: Francesco Torchia <francesco.torchia@suse.com>
Co-authored-by: Richa Bisht <RBISHT@Richas-MacBook-Pro.local>
2022-12-08 16:52:53 +01:00
richa 56ff6d7018
Tabs component storybook (#7604)
* Created tab stories page

* Chaanges in Tab.stories.mdx

* Added atert stories

* Added content

* Fixed in tabs components

* Added new stories

* Added Add/Remove tab story

* Removed duplicate tab.js file

* Removed Alert and ButtonDropdown stories, fixes in tab stories

* Removed storybook devDependencies

* Added commets for changes in the Tab components

* Fixed comment text

* Bump @rancher/components version

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* do not attempt to hide recent events tab when there are no events (#7540)

* feat(workload/storage): support add emptyDir volume

* workloads rollback fix

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* CI, add steps for rancher-components

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Fix role form input event handling (#7562)

* allow cloning roles; fix unlabaled taggable select style

* fix role edit/view config style inconsistency

* fix role form input event handling

* Add icon option to Banner and Error component (#7586)

* Add icon option for the Banner

* Add icon option for the Error

* Fix CruResource tests

* Apply @rancher/components linting rules

* set default container securityContext (#7539)

* Add manage button to home page (#7546)

* Add manage button to home page

* Fix button spacing

* Make buttons smaller - looks better with extra button

* Allow KeyValue component to disable defined keys and conditionally filter from the view (#7587)

* Allow KeyValue to disable and hide protected keys

* Add KeyValue stories to the style guide

* Restrict retry on run mode and allow to change test timeout by env var (#7592)

* Add nuxt-link mocked component to render in Storybook setup (#7606)

* Fix storybook build (#7600)

* Extend DetailTop component to have icon and tooltip (#7605)

* Add icon and tooltip option for DetailTop; Add story

* Add icon and tooltip option for DetailTop; Add story

* Add export for DraggableZone

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Fix test plugins script to avoid version issues with rancher components lib

* Need to build after yarn install

* Improve performance of pod logs (#7511)

* use a virtual list to render fewer log lines; restrict total number of lines kept when user has selected a 'show the last n lines' opt

* Fixed code in Tabbed component

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Co-authored-by: Richa Bisht <RBISHT@Richas-MacBook-Pro.local>
Co-authored-by: Francesco Torchia <francesco.torchia@suse.com>
Co-authored-by: Nancy <42977925+mantis-toboggan-md@users.noreply.github.com>
Co-authored-by: LiuYan <361112237@qq.com>
Co-authored-by: Giuseppe Leo <giuseppe.leo@suse.com>
Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
Co-authored-by: Phillip Rak <rak.phillip@gmail.com>
Co-authored-by: Neil MacDougall <nmacdougall@suse.com>
2022-12-07 17:04:18 +01:00
Giuseppe Leo d2d4122bc0
Review HTML formatting rules (#6805)
* Prevent ESLint to format generated paths

* Add HTML ESLint Rules

* Format all the Vue HTML templates except Harvester

* Exclude Harvester package from linting HTML, keeping old formatting rules
2022-11-11 17:04:22 +01:00
Giuseppe Leo 377c8b342f
Correct box shadow issue with nested tabs (#7155) 2022-10-11 21:18:08 +02:00
Giuseppe Leo 09b4e9580f
Replace styling with explicit configuration for flat cases as in nested tabs (#7136) 2022-10-10 23:36:18 +02:00
Giuseppe Leo f2c11db58b
Remove negative margin for Tabbed component, causing issues in Network policies (#7108) 2022-10-06 19:05:09 +02:00
Neil MacDougall 80eeacfb41
Plugins: Add UI to manage plugins (#6973)
* WIP: Working version

* Further refinement

* Working version

* Refactor to a product

* i18n

* Fix lint and tidy comments

* Empty-Commit

* Bump e2e

* Latest fixes, i18n

* Fix lint

* Fix lint issues

* Fix imports for standlone plugin build

* Only load plugins in dev

* Fix lint issue

* Fix template errors

* Fix operator setup

* Fix menu actions

* Address PR feedback

* Address PR feedback

* Add new preference for plugin developer

* Update icon support

* Add third-party and experimental banners to slide-in

* Add support for update/rollback of a plugin

* Address PR feedback - i18n

* i18n - one more string localised

* i18n - one more string localised

* Minor visual tidy ups

* Use banner for install warning

* Fix saefMode

* Fix lint

* Add some responsiveness to the cards page

* Fix lint

* Bump PR

* Add debug to list coverage reports
2022-10-04 13:16:54 +01:00
Shavindra 2047f74c92
Improve Deployment creations screen - #5734 (#6214)
* Improve workload deployments view.
2022-07-22 18:04:53 +01:00
Richard Cox 2f165ef23c Updates to cluster list and failed condition indicators
- Make `Explore` button role-secondary
- Better vertical alignment of cluster list conditions fail icon
- Align spacing and icon type of cluster list and detail condition icons
2022-07-15 10:30:22 +01:00
Sean ddab180ecc Adds in form validation mixin, error reporting on inputs, a few examples 2022-07-07 13:18:43 -04:00
Richard Cox 25acc1f8eb Plugins: Rejig files to new shell locations (#5623)
* Doc

* v0.7.0

* v0.7.1

* v0.7.2

* Add creators

* v0.1.14

* v0.1.17

* Add Yarn link

* Tidy ups and typos

* Allow models to be loaded from plugins

* v0.1.15

* v0.1.18

* v0.6.6

* Improve readme, fix cyperss log msg

* v0.1.17

* v0.1.19

* v0.6.7

* v0.6.8

* Fix logo ref when in shell

* Fix lint issues

* Fix error in example

* Fix script to work on linux

* Add ability to revert moves without losing changes

* Fix bug with custom models in a plugin

* Fix build of UI packages

* Add dist-pkg to .eslintignore

* Pull out util from extend-router to prevent router being pulled in UI packages

* Update PLUGINS.md

* Remove duplicate dependency

* Reduce size of built UI packages

* Share codemirror. Other tidy ups

* Further improvements

* Tidy ups to support i18n in plugins

* Clen up add comments

* More clean-ups and comments added

* Rename from extension to plugin

* Missed file in rename

* v0.6.9

* TIdy ups following rename

* v0.1.20

* v0.1.21

* More refactor and tidy up

* v0.1.22

* v0.1.18

* v0.1.19

* v0.1.23

* v0.6.10

* Version Packages. Improve naming. Unload.

* v0.6.11

* v0.1.20

* v0.1.21

* v0.1.24

* v0.6.12

* v0.1.25

* v0.1.22

* v0.6.13

* Fix issues when plugin is builtin

* Add missing files

* Fix lint issues and watcher ignores

* Fixes following review

* v0.1.28

* v0.1.31

* v0.6.20

* Fix coer.js version

* Fix bug where plugins included via npm don't work

* Changes post merge

* Move plugins doc to dev guide, add note at top of README

* Update cypress version

* Add note about the reset --hard in rejig -d

* Fixes post merge

* Rename @ranch to @rancher and ad plugins

* Improve routes support, add package assets support

* Add uninstall hooks and pass interal opts

* Fix rejig script

* Minor fixes

* Routing tweaks
- attempted to improve `addRoutes` typing, failed a lot
- improved typings in plugins.ts
- added "@pkg/*" entry and vue-shim (for importing components) to the pkg creator
- fixed some linting
- safely fail when Verdaccio isn't running
- fixed some typos

* Remove frontmatter-markdown-loader reference from nuxt-config

* Revert "Remove frontmatter-markdown-loader reference from nuxt-config"

This reverts commit 29ef6f2f7b.

* Exclude creators from dashboard build

* Revert "Exclude creators from dashboard build"

This reverts commit 8ede93ee7c.

* Ingore creators via tsconfig
- We're still susceptible with vue shims in multiple packages
- Need to determine why packages can't use shim from route
- Probably need to move `./vue-shim.d.ts` in to `./shell`. Needs testing with a pkg that imports a component

* After rejig

Co-authored-by: Neil MacDougall <nmacdougall@suse.com>
Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
2022-05-10 10:04:02 +01:00