Commit Graph

31 Commits

Author SHA1 Message Date
Richard Cox 614a820bba Show a warning on the project/namespace role create/edit and detail pages for upgradepsa verb 2025-06-05 14:25:21 +01:00
Alexandre Alves 6facd60a9f
remove all mentions for the restricted admin role (#12708) 2024-11-28 17:57:59 +00:00
Giuseppe Leo ab2244cf8e
Clone of global admin role not a 100% carbon copy (#12235)
* Add comment about the logic behind the goToClone methods

* Remove verbs key manipulation and map verbs with methods

* Add tests to ensure verbs are not manipulated

* Fix linters
2024-10-18 17:45:31 +02:00
Cody Jackson 5052c2a8e8 Enabling `vue/require-explicit-emits` linting rule
https://github.com/rancher/dashboard/issues/11961
2024-09-19 09:58:53 -07:00
Richard Cox fd515f29b4 Improve the height of Create Role Resource Tab's input fields
- Remove custom code, use new generic code that follows 'compact' concept
- Apply to all four fields in row
- Also fix a bug where selected verbs such that another row is shown would grow height of other inputs

Fix height of Create Project Resource Quotes input fields
- Vue2
  - Component would inherit attributes, such as class from owning element. For example classes applied to `<Select` would be applied to the first element within the Select component
  - $attrs property does not contain some properties from the parent, such as class
- Vue3
  - Component does not inherit attributes of owning element
  - $attrs property contains all propertiesof parrent, including class
- Bug
  - We fixed part one, but not part two
  - in Select we were applying class twice, manually to parent and then automatically to v-select
  - solution is to fix part two (chop out class)
2024-09-06 14:12:18 +01:00
Phillip Rak b68adb3833 Revert "Refactoring the plain element <input> data bindings"
This reverts commit 7f1536d9cf.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-08-27 15:39:02 -07:00
Cody Jackson 9b829c55ea Ran `yarn lint --fix` 2024-08-22 16:05:36 -07:00
Cody Jackson d5ce4fff2e Run the vue3 migration script
Commands run:

➤ yarn migrate
➤ git clean -fdx
➤ nvm use 20
➤ yarn
2024-08-22 16:05:36 -07:00
Cody Jackson 7f1536d9cf Refactoring the plain element <input> data bindings
Performing this change so the vue3 migration script can modify all @input, @v-model of components without changing plain elements. This will reduce the number of vue3 compiler errors.
2024-08-22 16:04:52 -07:00
Richard Cox 62f7f77d3e Fix duplicate group and options when creating global, cluster and project/namespace roles 2024-08-15 11:59:24 +01:00
Cody Jackson f2f014597c Removing prop mutation in v-model usage 2024-08-12 14:47:52 -07:00
wlin d6ba153647 Change from api.neuvector.com to permission.neuvector.com api group and leverage CRD, not CR, for NeuVector-realted resource in role creation 2024-07-24 16:55:01 -07:00
Jordon Leach d8e7769339
Add api.neuvector.com api group resources to role creation (#11184) 2024-06-26 09:26:44 -04:00
Alexandre Alves 15dd8956ff
add deprecation notice for restricted-admin role (#9912)
* add deprecation notice for restricted-admin role

* address pr comments

* add banner to edit/detail page for restricted-admin

* revert changes to v-clean directive

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
2023-10-16 11:36:39 +01:00
Nancy Butler 3b561b2eaa allow saving global roles with no displayName; fix global role edit when no resourceURLs 2023-09-28 16:20:54 -07:00
Sean-McQ 6f0a3d436a
save method in model fixes payload, validator catches the rest (#9758) 2023-09-27 13:40:36 -04:00
yonasberhe23 5be8469e6f
ui automation: users and roles tests (#9355)
* Add users and roles tests

* Refactor: split user-and-auth.po into user.po and roles.po and added roles tests

* Refactor users to reflect underlying list, create/edit and detail components
- Make Users PO root page for users list.
  - contains list po which extends BaseResourceList
  - contains user specific list stuff
- Move create edit stuff to own PO
- Move detail stuff to own PO, extend ResourceDetailPo

* Update roles as per previous changes to users
- different to users given different resource types

* split users and roles tests

* Remove unrequried command.ts, make http 200 check more lenient

---------

Co-authored-by: Yonas Berhe <yberhe@Yonass-MacBook-Pro.local>
Co-authored-by: Richard Cox <richard.cox@suse.com>
2023-08-01 09:32:06 -07:00
Alexandre Alves d3b802ab15
fix issue with Resources Select in globalRoles edit/create interface (#9210)
* fix issue with Resources Select in globalRoles edit/create interface

* address PR comments

* add missing check

* Minor improvement, add comments
- Did a deep dive on what this should actually be doing, added comments to explain
- We should prioritise methods to find a key via config before falling back on label and random string
- The opt.optionKey has been (previously) applied incorrectly. It should be the actual option key, rather than a key to find the option key
  - This is the root of the issue.
  - I don't think we should fix this here in case of breaking somewhere else
  - The changes in the PR are one's we should be doing anyway

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
Co-authored-by: Richard Cox <richard.cox@suse.com>
2023-07-17 13:23:02 +01:00
Giuseppe Leo 01eeb0548f
Add recommended lint rules globally (#8997)
* Update configuration

* Create default config for eslint

* Restore plugin:vue/recommended

* Add exceptions and overrides

* Correct manually remaining issues

* Adding further picked exceptions groupped up

* Fix or disable specific cases manually and singularly

* Add naming linting exception

* Remove unused variable in component

* Move rules to default

* Autocorrect rancher/components linting issues

* Configure VSCode to use multiple files, to display linting for rancher components

* Disable jest lint hook restriction for string list component

* Autofix
2023-06-23 17:02:55 +02:00
Alexandre Alves 0df3eba2b2
add e2e tests for users/roles list view for standard user (#9097)
* redoing the PR

* address PR comments

* address PR comments

---------

Co-authored-by: Alexandre Alves <aalves@Alexandres-MBP.lan>
2023-06-22 09:31:21 +01:00
Phillip Rak ade3c9f4e7 Replace all instances of `v-tooltip` with `v-clean-tooltip`
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2023-05-18 15:39:14 -07:00
richa 7c3b34d863
Fixed remove button style and alignments (#8122)
* Fixed remove button style and alignments

* Added column-gutter variable

* Removed imp from css
2023-04-14 13:14:36 +02:00
richa 3bad0ae7db
Removed required from ApiGroup feild (#7323)
* Removed required from ApiGroup feild

* Replace double quote api groups

* Removed required from ApiGroup feild

* Remove test text

* Removed required field mark

* Added unit test for card (#7411)

* Added unit test for card

* Improved test

* Corrected test

* Add logging output forms for OpenSearch and Redis

Signed-off-by: Bastian Hofmann <bashofmann@gmail.com>

* Minor changes to ClusterOutputs

* String List, add story

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* StringList, fix story

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* StringList story, update props value on change

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Bump gates

* Application card test (#7402)

* Application card unit-test

* allow cloning roles; fix unlabeled multi-select style (#7258)

* allow cloning roles; fix unlabaled taggable select style

* fix role edit/view config style inconsistency

* Fix linting issue after rule changes due merge overlapping (#7521)

* StringList, type:item event

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* pkg/rancher-components, fix lint errors

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

* Remove required on apiGroup field

Signed-off-by: Bastian Hofmann <bashofmann@gmail.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Co-authored-by: Neil MacDougall <nmacdougall@suse.com>
Co-authored-by: Bastian Hofmann <mail@bastianhofmann.de>
Co-authored-by: Catherine Luse <catherine.luse@gmail.com>
Co-authored-by: Francesco Torchia <francesco.torchia@suse.com>
Co-authored-by: Richard Cox <richard.cox@suse.com>
Co-authored-by: Sorin <scurescu@suse.com>
Co-authored-by: Nancy <42977925+mantis-toboggan-md@users.noreply.github.com>
Co-authored-by: Giuseppe Leo <giuseppe.leo@suse.com>
2022-12-19 11:28:08 +01:00
Nancy bc17dea8d5
Fix role form input event handling (#7562)
* allow cloning roles; fix unlabaled taggable select style

* fix role edit/view config style inconsistency

* fix role form input event handling
2022-11-30 08:57:31 -07:00
Nancy 8a0f8211bd
allow cloning roles; fix unlabeled multi-select style (#7258)
* allow cloning roles; fix unlabaled taggable select style

* fix role edit/view config style inconsistency
2022-11-22 08:29:47 -07:00
Giuseppe Leo d2d4122bc0
Review HTML formatting rules (#6805)
* Prevent ESLint to format generated paths

* Add HTML ESLint Rules

* Format all the Vue HTML templates except Harvester

* Exclude Harvester package from linting HTML, keeping old formatting rules
2022-11-11 17:04:22 +01:00
Richard Cox b5ca4919c3 Ensure roles that inherit from many many other roles can be edited
- For roles that inherit from 1000s of roles the edit experience becomes horrible
  - Getting to the detail/edit page of the role is a bit sluggish
  - Viewing the 'inherit from' tab in edit view is sluggish
  - Leaving the page after viewing `inherit from` tab causes dashboard to hang
- Root issue addressed in this commit is performance of the inherit from tab, specifically the tab hang one
- On a system with a cluster role that inherits from 1100 other roles
  - Tab shows one drop down for every role it inherits (1100)
  - Each drop down contains 1100 entries
  - Each slot that shows the drop down is passed 1100 roles as well
- To Address
  - Fix the primary issue of 1000s of selects with 1000s of entries
  - Reduce this to 1000s selects with 1 entry.... except when the user clicks on it
2022-09-14 17:10:51 +01:00
Jordon Leach c0b225fef1
Restore builtin role actions - disable rules for builtin roles (#6776) 2022-08-31 08:10:23 -04:00
Cody Jackson ef96317605 Lowercasing the resource values of built in roles
The previous implementation had the lowercasing and I think it was missed when making changes.

fixes rancher/dashboard#6137
2022-06-14 08:48:29 -07:00
Phillip Rak 72b36cb360
Create Rancher Component Library (#5504)
This adds a new project for Rancher Components under `pkg/rancher-components` and replaces components used throughout dashboard with the versions used here. All imports for the following components have been updated:

```
  |- BadgeState.vue
  |- Banner.vue
  |- Card.vue
  |- Form
    |- Checkbox.vue
    |- LabeledInput.vue
    |- LabeledTooltip.vue
    |- RadioButton.vue
    |- RadioGroup.vue
    |- TextAreaAutoGrow.vue
```
2022-05-24 15:09:53 -07:00
Richard Cox 25acc1f8eb Plugins: Rejig files to new shell locations (#5623)
* Doc

* v0.7.0

* v0.7.1

* v0.7.2

* Add creators

* v0.1.14

* v0.1.17

* Add Yarn link

* Tidy ups and typos

* Allow models to be loaded from plugins

* v0.1.15

* v0.1.18

* v0.6.6

* Improve readme, fix cyperss log msg

* v0.1.17

* v0.1.19

* v0.6.7

* v0.6.8

* Fix logo ref when in shell

* Fix lint issues

* Fix error in example

* Fix script to work on linux

* Add ability to revert moves without losing changes

* Fix bug with custom models in a plugin

* Fix build of UI packages

* Add dist-pkg to .eslintignore

* Pull out util from extend-router to prevent router being pulled in UI packages

* Update PLUGINS.md

* Remove duplicate dependency

* Reduce size of built UI packages

* Share codemirror. Other tidy ups

* Further improvements

* Tidy ups to support i18n in plugins

* Clen up add comments

* More clean-ups and comments added

* Rename from extension to plugin

* Missed file in rename

* v0.6.9

* TIdy ups following rename

* v0.1.20

* v0.1.21

* More refactor and tidy up

* v0.1.22

* v0.1.18

* v0.1.19

* v0.1.23

* v0.6.10

* Version Packages. Improve naming. Unload.

* v0.6.11

* v0.1.20

* v0.1.21

* v0.1.24

* v0.6.12

* v0.1.25

* v0.1.22

* v0.6.13

* Fix issues when plugin is builtin

* Add missing files

* Fix lint issues and watcher ignores

* Fixes following review

* v0.1.28

* v0.1.31

* v0.6.20

* Fix coer.js version

* Fix bug where plugins included via npm don't work

* Changes post merge

* Move plugins doc to dev guide, add note at top of README

* Update cypress version

* Add note about the reset --hard in rejig -d

* Fixes post merge

* Rename @ranch to @rancher and ad plugins

* Improve routes support, add package assets support

* Add uninstall hooks and pass interal opts

* Fix rejig script

* Minor fixes

* Routing tweaks
- attempted to improve `addRoutes` typing, failed a lot
- improved typings in plugins.ts
- added "@pkg/*" entry and vue-shim (for importing components) to the pkg creator
- fixed some linting
- safely fail when Verdaccio isn't running
- fixed some typos

* Remove frontmatter-markdown-loader reference from nuxt-config

* Revert "Remove frontmatter-markdown-loader reference from nuxt-config"

This reverts commit 29ef6f2f7b.

* Exclude creators from dashboard build

* Revert "Exclude creators from dashboard build"

This reverts commit 8ede93ee7c.

* Ingore creators via tsconfig
- We're still susceptible with vue shims in multiple packages
- Need to determine why packages can't use shim from route
- Probably need to move `./vue-shim.d.ts` in to `./shell`. Needs testing with a pkg that imports a component

* After rejig

Co-authored-by: Neil MacDougall <nmacdougall@suse.com>
Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
2022-05-10 10:04:02 +01:00