Commit Graph

13 Commits

Author SHA1 Message Date
Francesco Torchia e863d6778f
[2.12.3] Fix LabeledSelect and Select dropdown behavior
- fix LabeledSelect component when removing tagged elements
- remove onClickOption to avoid duplicate update:value emit from LabeledSelect.vue and Select.vue
- fix Select component when removing tagged elements

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2025-09-10 18:36:25 +02:00
Neil MacDougall f8a6ddf25d
Fix select controls do not close when clicking on arrow (#14217)
* Fix select controls do not close when clicking on arrow

* Rebase

* Control vue-select state via labeledSelect

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Control vue-select state via Select.vue

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Set isOpen to false when select closes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Move focus back to select wrapper on close

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Defer more select open state logic to wrapper

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Close when no selection is made

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Allow for multiselect

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Fix failing e2e test

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

---------

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Co-authored-by: Phillip Rak <rak.phillip@gmail.com>
2025-07-02 13:33:43 -07:00
Phillip Rak ade0a1f9d9
Simplify spacebar prevent behavior when focusing LabeledSelect (#14553)
* Simplify spacebar prevent behavior when focusing LabeledSelect

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Fix unit test

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Simplify spacebar prevent behavior when focusing Select

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

---------

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-06-26 08:57:30 -07:00
Alexandre Alves 20827a1943
fix problem with space key on searchable selects (#14362)
* fix problem with space key on searchable selects + add unit tests

* fix lint issue
2025-05-19 11:49:44 +01:00
Alexandre Alves 809c9d0301
add aria-required attribute to LabeledSelect and LabeledInput components (#14256) 2025-05-07 08:44:58 +01:00
Alexandre Alves fd14379936
Improve Banners settings screen reader output (#14093)
* fix a few components for a11y + add unit tests related to a11y

* fix issues with sr output for banners settings with ColorInput and RadioGroup + update unit tests + fix lint issues

* fix lint issue
2025-05-05 09:25:53 +01:00
Francesco Torchia 04026144c7
Add LabeledSelect unit tests
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2025-02-18 14:45:56 +01:00
Alexandre Alves 24568dc109
fix bug with LabeledSelect with "multiple" attribute (#12129)
* fix issue with labeledSelect in mode multiple by allowing the binding of the attribute to the element v-select

* Add test for component to emit the correct value as array

---------

Co-authored-by: cnotv <giuseppe.leo@suse.com>
2024-10-04 16:33:32 +01:00
cnotv 78d70353c5 Unit test: Migrate unit tests with the script 2024-08-22 16:07:03 -07:00
Nancy 13f2e5fe00
Improve LabeledSelect performance (#10650)
* remove labeledselect ability to detect stale option labels in order to improve performance

* add key rerender hack to fix psa dropdown option labels not refreshing

* fix lint
2024-03-20 08:04:44 -07:00
Nancy 371524f732
Reduce performance impact of LabeledSelect getOptionLabel (#9689)
* imrpove labeledSelect getOptionLabel performance when options are strings

* refactor labeledselect getOptionLabel and write test

* remove redundant if block in ls getOPtionLabel

* refactor getUpdatedOption
2023-09-12 12:58:02 -07:00
Nancy 21167e1dc9
fix labeledselect getOptionLabel to use reduce prop when labels change (#8176)
* fix labeledselect getOptionLabel to use reduce prop when labels change

* Add unit tests

---------

Co-authored-by: cnotv <giuseppe.leo@suse.com>
2023-02-15 09:19:48 -07:00
Giuseppe Leo fb590d2539
LabeledSelect: Displayed label does not update with options (#8154)
* Update displayed value in labeled select inputs if option labe changes but not the value

* Replace generic label and key with props

* Add i18n
2023-02-14 10:42:30 +01:00