Commit Graph

311 Commits

Author SHA1 Message Date
Phillip Rak d41fc165a3
Merge pull request #15103 from rancher/gha-portpr-16815492177-1
[backport v2.12.1] add unique :key to each component
2025-08-08 10:16:22 -06:00
Siva Kanakala 678e15f626 add unique :key to each component 2025-08-07 13:53:08 -07:00
Phillip Rak 9b8a120c4b Move `scrollIntoView()` implementation to `useDropdownItem()`
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-08-07 20:51:00 +00:00
Alexandre Alves 07b14e8d71
fix bug with empty space above side menu (#14764) 2025-07-10 15:38:28 +01:00
Alexandre Alves faa7fe3b60
A11y report fixes (#14530)
* fix item 2: All page content should be contained by landmarks

* fix item 4. Elements must only use permitted ARIA attributes

* fix item 6. ARIA attributes must conform to valid values

* fix bug on item 6. and fix item 7. <ul> and <ol> must only directly contain <li>, <script> or <template> elements

* fix item 8. Interactive controls must not be nested

* fix item 10. ARIA toggle fields must have an accessible name

* fix item 11. autocomplete attribute must be used correctly

* fix item 12. Form elements must have labels

* fix item 14. ARIA input fields must have an accessible name

* fix item 15. Buttons must have discernible text

* fix item 16. Images must have alternative text

* working on item 17

* finish fix item 17. ARIA role should be appropriate for the element

* fix wrong role in hidden inputs

* address pr comments
2025-07-10 10:09:09 +01:00
Richard Cox 28c58ad5a1
Merge pull request #14674 from richard-cox/fix-stale-ns-filter
Ensure ns filter selection is updated when stale entries are removed
2025-07-04 09:47:04 +01:00
Richard Cox 2800ae04ec Ensure ns filter selection is updated when stale entries are removed
- when we calculate the value of a filter we remove entries that no longer exist
- ensure that this new version of the filter is persisted
- this means whilst on vai supported lists it correctly kicks off a http request
  - this also avoids removed namespaces being used in filters if the list changes

Also
- improved some comments
2025-07-03 15:15:29 +01:00
Neil MacDougall 533bcb3ec2
Notification Centre: Update 3: Simplify storage/encryption in local storage (#14642)
* Simplification of encryption

* Address PR feedback
2025-07-02 08:22:58 +01:00
Neil MacDougall 25f1df9a80
Notification Centre: Update 2: UX Improvements (#14646)
* Update styling as per UX, allow up/down to exit focus and move to previous/next item

* Fix lint

* Fix lint
2025-07-01 16:57:52 +01:00
Neil MacDougall 12339bfa7c
Notification Centre: Update 1: Performance improvements (#14610)
* Fix lint issue

* Bug fix, simplify load mutation, remove load action (not needed)

* Fix lint
2025-07-01 13:28:14 +01:00
Neil MacDougall 59a08dfa07
Add support for vue route and extension init (#14590)d
* Add support for vue route and extension init

* Fix lint

* Minor doc fix, fix issue with buttons when scrolled

* Ensure onReady is only called once

* Address PD feedback

* Address more PR feedback - simplify close on action

* Add support for vue route and extension init

* Fix lint

* Ensure onReady is only called once

* Address PD feedback

* Tidy ups

* Add one missing tidy up
2025-06-26 16:40:12 +01:00
Neil MacDougall a0d725938c
Add Notification Center (#14419)
* Initial version

* Improve growl integration

* Fix lint issues

* Tidy ups and lint fixes

* Add a maxiumum number of notifications

* Add some notes

* Localisations

* Avoid using general 'actions' class name

* Remove clear all button

* Further fixes

* Remove test code

* Always show a read notification indicator

* Address feedback from walk through

* Add test ids and updated e2e tests, fix lint

* Bump version number to match backend

* Work around version issues

* Fix lint issue

* Fix e2e test

* Fix release notes seen issue breading login landing page

* Update .gitignore

* Remove dev readme file

* Remove todo and tweak comments

* Add simple developer docs, update type comments, bump icon package version number

* Update lock file

* Address PR feedback

* Address PR feedback 2nd round

* Fix lint

* Fix broken import

* PR feedback

* Used partial

* PR review feedback

* Use user id hash in the local storage key

* Encrypt the notifications in local storage

* Remove persist stuff from store

* Fix bug with initialization of the store and release notes

* Bug fix - store encryption key

* Debounce setting of notifications to avoid loop
- tab 1 can fight tab 2 if tab 2 progresses whilst tab 1 processes stale content

---------

Co-authored-by: Richard Cox <ricox@suse.com>
2025-06-19 19:47:50 +01:00
Cody Jackson 4f79f1c3f3 Add the flag/switching mechanism to allow us to render new details pages
By doing the flagging we can check the pages in slowly without causing disruption, it will also allow us to roll things back if a bug is found last minute. By default we're still showing legacy pages but we will flip that once pages are added.
2025-06-18 08:53:53 -07:00
Francesco Torchia 11ab3988ca
Merge pull request #14160 from torchiaf/13172-fleet-dashboard
Fleet, implement Dashboard
2025-06-12 10:38:27 +02:00
Richard Cox 75afc17979
Handle new vai-on updates to resources (#13150)
* port of wip

* asdassad

* Update vai / sql cache based api filtering to match latest changes

* Revert "Pin Rancher version to v2.11-2053ce644a31cd8053d1f58e2487154b0b8513b6-head for e2e tests"

This reverts commit 60f62107e7.

* sdfdsf

* dsfdsf

* asdsad

* fix dynamic hide local cluster changes

* improvements

* aaaa

* Working through todo's/tidys

* Remove debug / tidy up

* resolving todos

* remove some debug

* Tidying up #1

* Make manual refresh and auto-refresh visible on perf setting, disabled by default

* Remove dev stuff

* Fix some e2e tests

* Updated comment

* Wire in resource.changes debounce, clearer label for feature `listAutoRefreshToggle`

* Temporarily disable all watches when vai enable
- remove once rancher/rancher#40773 is resolved, which will then finally fix #12734

* Revert "Temporarily disable all watches when vai enable"

This reverts commit c708f468e4.

* Fix nextResourceVersion
- Ensure it handles resource revisions (in both LIST or individual resources) that are strings
- add unit tests

* Update after review
2025-06-11 18:11:35 +01:00
Francesco Torchia f0fd555c45
Fleet add showWorkspaceSwitcher store action and wire it in dashboard page to hide the selector
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
2025-06-10 18:22:04 +02:00
Phillip Rak 55b5900cd7
Add self modifier to namespace keydown (#14437)
This adds the `.self` modifier to the namespace keydown event so that the handler only triggers if `event.target` is the element itself. This allows the child input to accept space as an input.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-06-05 11:12:01 -07:00
Alexandre Alves f206b540e8
fix problem with extra space and scroll on settings banner page (#14320)
* fix problem with extra space and scroll on settings banner page

* add v-if to windowmanager + prevent focus on slideInPanelManager close button if there is no slide in panel visible

* remove weird trigger-focus-trap on close button

* address flaky e2e tests
2025-05-15 08:45:17 +01:00
Phillip Rak dc30093509
Replace container logs actions with new dropdown menu component (#14172)
* Create new `useDropdownItem` composable

This composable defines common methods that can be shared across different dropdown menu item types.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Create new `RcDropdownMenuItemCheckbox` component

`RcDropdownMenuItemCheckbox` specifies the styles and behaviors for a menu items that acts as a checkbox.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Create a select item dropdown component

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Move container actions into dedicated component

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Toggle container logs actions based on environment

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Fix type for labeledSelect component ref

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Replace trigger mixin data with event.stop

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Fix typo: LocaleSelector

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

---------

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-05-06 10:50:09 -07:00
Phillip Rak 3ab9fb6b03
Update `namespaceFilter` accessibility features (#14214)
* Fix roles for namespace filter options

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Replace namespace filter icons with buttons

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Fix RcButton classes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Update namespace filter roles and keyboard behavior

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Update aria attributes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Fix issue with button label

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Update aria labels

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Update keyboard behavior

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Make close icons in chips buttons

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

* Add prevent modifier to namespace filter open event

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

---------

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-05-06 07:47:44 -07:00
Alexandre Alves d1dc8b2e21
refactor import and search header modals as a prompt modals (#14197)
* refactor import and search header modals as a prompt modal + add unit tests

* fix lint issue

* remove unused prop + fix e2e test

* fix merge conflicts
2025-05-06 09:52:14 +01:00
Neil MacDougall 9d25512ce8
Resource Search: Add ability to search by group (#14216)
* Resource Search: Search by group

* Improve clarity of feature text

* Fix lint

* Use different search
2025-05-02 09:03:54 +01:00
Alexandre Alves cb7cb52dbe
add role 'none' to hr elements in TopLevelMenu (#14121)
* add role 'none' to hr elements in TopLevelMenu

* add missing role and label to SideNav

* add aria-label to show/hide button in the Password component

* add role 'none' to hr elements

* add missing alt to user avatar image
2025-04-16 10:23:38 +01:00
Phillip Rak fd0ce57380
Remove deleted props from tooltips (#14054)
This change removes warnings that were printed to the console when hovering over primary navigation items. The `popperOptions` props was removed from floating-vue[^1] and hasn't done anything since we migrated to Vue3.

[^1]: https://floating-vue.starpad.dev/migration/migration-from-v3#removed-props

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-04-15 10:29:50 -07:00
Neil MacDougall 5ec05348e8
Ensure product-level navigation highlights the correct item (#14070)
* Improve navigation highlighting

* Tidy ups

* Add automated tests
2025-04-10 09:27:40 +01:00
Alexandre Alves 4af23f6d6a
working on issues reported in the a11y tests (#13609) 2025-04-02 09:57:46 +01:00
Alexandre Alves 76e92a803e
fix unclear functionality for filter inputs for a11y (#13836) 2025-03-23 18:03:37 +00:00
Alexandre Alves 913983e2df
fix issue with aria-role (#13813)
* fix issue with aria-role

* fix aria-checked by replacing with appropriate aria-pressed
2025-03-21 09:20:43 +00:00
Alexandre Alves 9ac4bb65c5
add missing aria-current to nav links (#13821) 2025-03-21 09:20:00 +00:00
Alexandre Alves 6b63952cbc
add missing arias to favorite action on masthead (#13800) 2025-03-19 09:18:48 +00:00
Cody Jackson e969b910cc Adding another indentation level in our navigation menu
Fixes https://github.com/rancher/dashboard/issues/11228
2025-03-18 11:03:15 -07:00
Cody Jackson 7847d5cd07 Fix FixedBanner so that we can show the appropriate stylized text also fix multi-line functionality
Fixes https://github.com/rancher/dashboard/issues/11951
2025-03-17 14:41:53 -07:00
Yonas Berhe 8f6e91e7ac add more accessibility tests 2025-03-10 17:22:04 -07:00
Phillip Rak dcad2cc321 Make terminal and editor escape sequence `Shift+Escape`
The escape key conflicts with modal editing when working in VIM mode. Using `Shift+Escape` helps to prevent that conflict.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-03-05 14:38:08 -07:00
Alexandre Alves 871ebd1b9f
fix issue (#13571) 2025-03-04 12:22:50 +00:00
Alexandre Alves 3970a9ff63
fix misc issues for a11y (#13519)
* fix misc issues for a11y

* fix prop + fix issue with white area not resizing as whole shell window

* improve aria labels for shell resize
2025-02-28 15:56:18 +00:00
Richard Cox 7f2c00143e Wire in newly supported mgmt cluster status.connected property 2025-02-26 14:54:31 +00:00
Alexandre Alves 9664a29373
Fix issue with configmap description and pressing `space` shifting focus (#13509)
* update computed patterns that use refs

* update pattern
2025-02-26 09:45:34 +00:00
Cody Jackson d6c6778e16 Change the way we size the ns-glass element responsible for closing the dropdown if you click outside of the element
Fixes https://github.com/rancher/dashboard/issues/6748
2025-02-24 07:59:34 -07:00
Alexandre Alves 84c234383a
Fix textual descriptions for cluster appearance in multiple places (#13416)
* Fix textual descriptions for cluster appearance in multiple places

* address pr comments

* address pr comments
2025-02-24 09:00:54 +00:00
Alexandre Alves 52b516a5d9
Fix Header keyboard navigation (#13369)
* address header accessibility issues

* fix codemirror component not using refs + improve logic to check yaml editor focus on app modal

* add missing optional chaining

* fix unit test

* fix some failing e2e tests

* fix lint issue

* revert changes to namespaceFilter + revert changes to e2e tests

* revert e2e changes

* revert e2e changes

* add fix for configmap e2e test

* add unique name for configmap resource creation test

* test e2e fix

* address pr comments
2025-02-21 08:51:39 +00:00
Phillip Rak ea176eb358 Fix data-testid usage in RcDropdownMenu
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>

Fix

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-02-18 17:18:36 -07:00
Phillip Rak 620e75ec1f Fix failing e2e tests
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-02-14 15:11:51 -07:00
Phillip Rak 5e5d95f7a1 Replace HeaderPageActionMenu dropdown with RcDropdownMenu
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-02-14 08:03:07 -07:00
Alexandre Alves 2786ad7612
add missing alt to image elements (#13383) 2025-02-13 11:44:10 +00:00
Phillip Rak e9b6d1967d Fix regression in NamespaceFilter selected items
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-02-05 15:03:36 -07:00
Phillip Rak ca3220a0db Remove top/bottom padding for user info
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-02-05 15:03:36 -07:00
Phillip Rak 6ef6147dbd Update avatar styles
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-02-04 10:00:04 -07:00
Phillip Rak 1dc914b697 Add new ghost button role
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-02-04 09:44:03 -07:00
Phillip Rak b9b1004a7b Add aria-labels for dropdown triggers
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2025-02-04 09:44:02 -07:00