Commit Graph

4 Commits

Author SHA1 Message Date
Alexandre Alves 49123807b5 Reintroduce "Write tests for `useCompactInput` and `useLabeledFormElement`"
This reverts commit 8eae0e78f9.
2024-03-13 10:10:26 -07:00
Alexandre Alves c7b94ef829
Revert "Write tests for `useCompactInput` and `useLabeledFormElement`" (#10346) 2024-01-29 17:22:19 +00:00
Phillip Rak 30207d3dda Write tests for `useCompactInput` and `useLabeledFormElement`
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-01-10 10:38:30 -07:00
Phillip Rak fcbd73d24b Replace `Vue.extend` with `defineComponent` in `LabeledInput.vue`
Rewrote `compact-input.ts` and `labeled-form-element.ts` mixins as composables to address TypeScript issues when using mixins with `defineComponent`. The new composables are written to adhere to the conventions and best practices [^1] as best as possible, taking into consideration what's available to us in Vue 2.7.14.

Moving to composables positions us for a smoother Vue 3 migration.

[^1]: https://vuejs.org/guide/reusability/composables.html#conventions-and-best-practices

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2024-01-05 09:11:25 -07:00